Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up vestige of useOpaqueIdentifier (#25587)

Browse Source 
Found some code that was left over from the experimental
useOpaqueIdentifier hook, which we eventually replaced with useId.

This deletes it.
This commit is contained in:
Andrew Clark
2022-10-29 17:46:54 -07:00
committed by Rick Hanlon
parent a5629e96ba
commit 6de70ef00a
4 changed files with 2 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-reconciler/src/ReactFiberHooks.new.js
-9
View File
@@ -767,8 +767,6 @@ export function resetHooksAfterThrow(): void {
hookTypesUpdateIndexDev = -1;
currentHookNameInDev = null;
isUpdatingOpaqueValueInRenderPhase = false;
}
didScheduleRenderPhaseUpdateDuringThisPass = false;
@@ -2380,13 +2378,6 @@ function rerenderTransition(): [
return [isPending, start];
}
let isUpdatingOpaqueValueInRenderPhase = false;
export function getIsUpdatingOpaqueValueInRenderPhaseInDEV(): boolean | void {
if (__DEV__) {
return isUpdatingOpaqueValueInRenderPhase;
}
}
function mountId(): string {
const hook = mountWorkInProgressHook();
packages/react-reconciler/src/ReactFiberHooks.old.js
-9
View File
@@ -767,8 +767,6 @@ export function resetHooksAfterThrow(): void {
hookTypesUpdateIndexDev = -1;
currentHookNameInDev = null;
isUpdatingOpaqueValueInRenderPhase = false;
}
didScheduleRenderPhaseUpdateDuringThisPass = false;
@@ -2380,13 +2378,6 @@ function rerenderTransition(): [
return [isPending, start];
}
let isUpdatingOpaqueValueInRenderPhase = false;
export function getIsUpdatingOpaqueValueInRenderPhaseInDEV(): boolean | void {
if (__DEV__) {
return isUpdatingOpaqueValueInRenderPhase;
}
}
function mountId(): string {
const hook = mountWorkInProgressHook();
packages/react-reconciler/src/ReactFiberWorkLoop.new.js
+1 -5
View File
@@ -205,7 +205,6 @@ import {resetContextDependencies} from './ReactFiberNewContext.new';
import {
resetHooksAfterThrow,
ContextOnlyDispatcher,
getIsUpdatingOpaqueValueInRenderPhaseInDEV,
} from './ReactFiberHooks.new';
import {DefaultCacheDispatcher} from './ReactFiberCache.new';
import {
@@ -3638,10 +3637,7 @@ if (__DEV__) {
function warnAboutRenderPhaseUpdatesInDEV(fiber) {
if (__DEV__) {
if (
ReactCurrentDebugFiberIsRenderingInDEV &&
!getIsUpdatingOpaqueValueInRenderPhaseInDEV()
) {
if (ReactCurrentDebugFiberIsRenderingInDEV) {
switch (fiber.tag) {
case FunctionComponent:
case ForwardRef:
packages/react-reconciler/src/ReactFiberWorkLoop.old.js
+1 -5
View File
@@ -205,7 +205,6 @@ import {resetContextDependencies} from './ReactFiberNewContext.old';
import {
resetHooksAfterThrow,
ContextOnlyDispatcher,
getIsUpdatingOpaqueValueInRenderPhaseInDEV,
} from './ReactFiberHooks.old';
import {DefaultCacheDispatcher} from './ReactFiberCache.old';
import {
@@ -3638,10 +3637,7 @@ if (__DEV__) {
function warnAboutRenderPhaseUpdatesInDEV(fiber) {
if (__DEV__) {
if (
ReactCurrentDebugFiberIsRenderingInDEV &&
!getIsUpdatingOpaqueValueInRenderPhaseInDEV()
) {
if (ReactCurrentDebugFiberIsRenderingInDEV) {
switch (fiber.tag) {
case FunctionComponent:
case ForwardRef: