Facebook/react
1
0 Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove emoji prefix from Firefox extension tab labels

Browse Source 
Firefox adds these already for React, so the extra emoji character was confusing. For now, we still prepend it for Chrome
This commit is contained in:
Brian Vaughn committed 2019-08-21 14:23:51 -07:00
1 parent 2843a1556e
commit 6dda816102
1 file changed
+48 -36
Download Patch File Download Diff File Expand all files Collapse all files
shells/browser/shared/src/main.js
+48 -36
View File
@@ -21,6 +21,8 @@ import DevTools from 'src/devtools/views/DevTools';
const LOCAL_STORAGE_SUPPORTS_PROFILING_KEY =
'React::DevTools::supportsProfiling';
const isChrome = getBrowserName() === 'Chrome';
let panelCreated = false;
// The renderer interface can't read saved component filters directly,
@@ -123,7 +125,7 @@ function createPanelIfReactLoaded() {
store = new Store(bridge, {
isProfiling,
supportsReloadAndProfile: getBrowserName() === 'Chrome',
supportsReloadAndProfile: isChrome,
supportsProfiling,
});
store.profilerStore.profilingData = profilingData;
@@ -226,47 +228,57 @@ function createPanelIfReactLoaded() {
let currentPanel = null;
let needsToSyncElementSelection = false;
chrome.devtools.panels.create('⚛ Components', '', 'panel.html', panel => {
panel.onShown.addListener(panel => {
if (needsToSyncElementSelection) {
needsToSyncElementSelection = false;
bridge.send('syncSelectionFromNativeElementsPanel');
}
chrome.devtools.panels.create(
isChrome ? '⚛ Components' : 'Components',
'',
'panel.html',
panel => {
panel.onShown.addListener(panel => {
if (needsToSyncElementSelection) {
needsToSyncElementSelection = false;
bridge.send('syncSelectionFromNativeElementsPanel');
}
if (currentPanel === panel) {
return;
}
if (currentPanel === panel) {
return;
}
currentPanel = panel;
componentsPortalContainer = panel.container;
currentPanel = panel;
componentsPortalContainer = panel.container;
if (componentsPortalContainer != null) {
ensureInitialHTMLIsCleared(componentsPortalContainer);
render('components');
panel.injectStyles(cloneStyleTags);
}
});
panel.onHidden.addListener(() => {
// TODO: Stop highlighting and stuff.
});
});
if (componentsPortalContainer != null) {
ensureInitialHTMLIsCleared(componentsPortalContainer);
render('components');
panel.injectStyles(cloneStyleTags);
}
});
panel.onHidden.addListener(() => {
// TODO: Stop highlighting and stuff.
});
}
);
chrome.devtools.panels.create('⚛ Profiler', '', 'panel.html', panel => {
panel.onShown.addListener(panel => {
if (currentPanel === panel) {
return;
}
chrome.devtools.panels.create(
isChrome ? '⚛ Profiler' : 'Profiler',
'',
'panel.html',
panel => {
panel.onShown.addListener(panel => {
if (currentPanel === panel) {
return;
}
currentPanel = panel;
profilerPortalContainer = panel.container;
currentPanel = panel;
profilerPortalContainer = panel.container;
if (profilerPortalContainer != null) {
ensureInitialHTMLIsCleared(profilerPortalContainer);
render('profiler');
panel.injectStyles(cloneStyleTags);
}
});
});
if (profilerPortalContainer != null) {
ensureInitialHTMLIsCleared(profilerPortalContainer);
render('profiler');
panel.injectStyles(cloneStyleTags);
}
});
}
);
chrome.devtools.network.onNavigated.removeListener(checkPageForReact);