Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #330 from spicyj/warn-class-for

Browse Source 
Warn for 'class' and 'for' property names
This commit is contained in:
Paul O’Shannessy
2013-09-10 16:21:33 -07:00
parent 7a6a508066 232b61044c
commit 6d77ad4be3
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/dom/DOMProperty.js
+6 -2
View File
@@ -85,8 +85,12 @@ var DOMPropertyInjection = {
var lowerCased = propName.toLowerCase();
DOMProperty.getPossibleStandardName[lowerCased] = propName;
DOMProperty.getAttributeName[propName] =
DOMAttributeNames[propName] || lowerCased;
var attributeName = DOMAttributeNames[propName];
if (attributeName) {
DOMProperty.getPossibleStandardName[attributeName] = propName;
}
DOMProperty.getAttributeName[propName] = attributeName || lowerCased;
DOMProperty.getPropertyName[propName] =
DOMPropertyNames[propName] || propName;
src/dom/__tests__/DOMPropertyOperations-test.js
+10
View File
@@ -68,6 +68,16 @@ describe('DOMPropertyOperations', function() {
expect(console.warn.argsForCall[0][0]).toContain('tabIndex');
});
it('should warn about class', function() {
spyOn(console, 'warn');
expect(DOMPropertyOperations.createMarkupForProperty(
'class',
'muffins'
)).toBe(null);
expect(console.warn.argsForCall.length).toBe(1);
expect(console.warn.argsForCall[0][0]).toContain('className');
});
it('should create markup for boolean properties', function() {
expect(DOMPropertyOperations.createMarkupForProperty(
'checked',