Small cleanup in ReactFiberCompleteWork (#27681)

These are all functionally equivalent changes.

- remove double negation and more explicit naming of
`hadNoMutationsEffects`
- use docblock syntax that's consumed by Flow
- remove useless cast

DiffTrain build for [c4c87e049b](https://github.com/facebook/react/commit/c4c87e049b891ebc38a7a14b8c93285c877e90af)
This commit is contained in:
kassens
2023-11-10 15:25:47 +00:00
parent c9079646c0
commit 6bab074fd2
12 changed files with 52 additions and 28 deletions
+1 -1
View File
@@ -1 +1 @@
0e352ea01c0209b6c5e23f0e857af4e01c783024
c4c87e049b891ebc38a7a14b8c93285c877e90af
+1 -1
View File
@@ -587,4 +587,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-classic-93c0536e";
exports.version = "18.3.0-www-classic-b6e8ec88";
+1 -1
View File
@@ -579,4 +579,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-modern-bd02fc79";
exports.version = "18.3.0-www-modern-7fb93a7a";
@@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}
var ReactVersion = "18.3.0-www-classic-6755280f";
var ReactVersion = "18.3.0-www-classic-845b4481";
var LegacyRoot = 0;
var ConcurrentRoot = 1;
@@ -18667,9 +18667,12 @@ if (__DEV__) {
};
}
/**
* Tag the fiber with an update effect. This turns a Placement into
* a PlacementAndUpdate.
*/
function markUpdate(workInProgress) {
// Tag the fiber with an update effect. This turns a Placement into
// a PlacementAndUpdate.
workInProgress.flags |= Update;
}
+6 -3
View File
@@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}
var ReactVersion = "18.3.0-www-modern-adf7c13c";
var ReactVersion = "18.3.0-www-modern-b4d8ae24";
var LegacyRoot = 0;
var ConcurrentRoot = 1;
@@ -18340,9 +18340,12 @@ if (__DEV__) {
};
}
/**
* Tag the fiber with an update effect. This turns a Placement into
* a PlacementAndUpdate.
*/
function markUpdate(workInProgress) {
// Tag the fiber with an update effect. This turns a Placement into
// a PlacementAndUpdate.
workInProgress.flags |= Update;
}
@@ -23663,9 +23663,12 @@ if (__DEV__) {
};
}
/**
* Tag the fiber with an update effect. This turns a Placement into
* a PlacementAndUpdate.
*/
function markUpdate(workInProgress) {
// Tag the fiber with an update effect. This turns a Placement into
// a PlacementAndUpdate.
workInProgress.flags |= Update;
}
@@ -34881,7 +34884,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-classic-a5cdf515";
var ReactVersion = "18.3.0-www-classic-d456dfab";
function createPortal$1(
children,
+6 -3
View File
@@ -23522,9 +23522,12 @@ if (__DEV__) {
};
}
/**
* Tag the fiber with an update effect. This turns a Placement into
* a PlacementAndUpdate.
*/
function markUpdate(workInProgress) {
// Tag the fiber with an update effect. This turns a Placement into
// a PlacementAndUpdate.
workInProgress.flags |= Update;
}
@@ -34702,7 +34705,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-modern-b881b4d4";
var ReactVersion = "18.3.0-www-modern-81cc9bc4";
function createPortal$1(
children,
@@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");
var ReactVersion = "18.3.0-www-modern-adf7c13c";
var ReactVersion = "18.3.0-www-modern-b4d8ae24";
// This refers to a WWW module.
var warningWWW = require("warning");
@@ -23800,9 +23800,12 @@ if (__DEV__) {
};
}
/**
* Tag the fiber with an update effect. This turns a Placement into
* a PlacementAndUpdate.
*/
function markUpdate(workInProgress) {
// Tag the fiber with an update effect. This turns a Placement into
// a PlacementAndUpdate.
workInProgress.flags |= Update;
}
@@ -35505,7 +35508,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-classic-488f91a4";
var ReactVersion = "18.3.0-www-classic-adaf3ac3";
function createPortal$1(
children,
@@ -23659,9 +23659,12 @@ if (__DEV__) {
};
}
/**
* Tag the fiber with an update effect. This turns a Placement into
* a PlacementAndUpdate.
*/
function markUpdate(workInProgress) {
// Tag the fiber with an update effect. This turns a Placement into
// a PlacementAndUpdate.
workInProgress.flags |= Update;
}
@@ -35326,7 +35329,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-modern-bd02fc79";
var ReactVersion = "18.3.0-www-modern-7fb93a7a";
function createPortal$1(
children,
@@ -16702,9 +16702,12 @@ if (__DEV__) {
};
}
/**
* Tag the fiber with an update effect. This turns a Placement into
* a PlacementAndUpdate.
*/
function markUpdate(workInProgress) {
// Tag the fiber with an update effect. This turns a Placement into
// a PlacementAndUpdate.
workInProgress.flags |= Update;
}
@@ -25810,7 +25813,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-classic-93c0536e";
var ReactVersion = "18.3.0-www-classic-b6e8ec88";
// Might add PROFILE later.
@@ -16702,9 +16702,12 @@ if (__DEV__) {
};
}
/**
* Tag the fiber with an update effect. This turns a Placement into
* a PlacementAndUpdate.
*/
function markUpdate(workInProgress) {
// Tag the fiber with an update effect. This turns a Placement into
// a PlacementAndUpdate.
workInProgress.flags |= Update;
}
@@ -25810,7 +25813,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-modern-b9808d6c";
var ReactVersion = "18.3.0-www-modern-73e7dcee";
// Might add PROFILE later.