Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

StrictMode should call sCU twice in DEV (#17942)

Browse Source
This commit is contained in:
Brian Vaughn
2020-01-30 13:03:44 -08:00
committed by GitHub
parent 9dbe1c54df
commit 6ae2c33a75
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-reconciler/src/ReactFiberClassComponent.js
Vendored
+9
View File
@@ -262,6 +262,15 @@ function checkShouldComponentUpdate(
) {
const instance = workInProgress.stateNode;
if (typeof instance.shouldComponentUpdate === 'function') {
if (__DEV__) {
if (
debugRenderPhaseSideEffectsForStrictMode &&
workInProgress.mode & StrictMode
) {
// Invoke the function an extra time to help detect side-effects.
instance.shouldComponentUpdate(newProps, newState, nextContext);
}
}
startPhaseTimer(workInProgress, 'shouldComponentUpdate');
const shouldUpdate = instance.shouldComponentUpdate(
newProps,
packages/react/src/__tests__/ReactStrictMode-test.js
+4
View File
@@ -138,6 +138,7 @@ describe('ReactStrictMode', () => {
'getDerivedStateFromProps',
'getDerivedStateFromProps',
'shouldComponentUpdate',
'shouldComponentUpdate',
'render',
'render',
'componentDidUpdate',
@@ -166,6 +167,7 @@ describe('ReactStrictMode', () => {
'getDerivedStateFromProps',
'getDerivedStateFromProps',
'shouldComponentUpdate',
'shouldComponentUpdate',
]);
} else {
expect(log).toEqual([
@@ -283,6 +285,7 @@ describe('ReactStrictMode', () => {
'getDerivedStateFromProps',
'getDerivedStateFromProps',
'shouldComponentUpdate',
'shouldComponentUpdate',
'render',
'render',
'componentDidUpdate',
@@ -305,6 +308,7 @@ describe('ReactStrictMode', () => {
'getDerivedStateFromProps',
'getDerivedStateFromProps',
'shouldComponentUpdate',
'shouldComponentUpdate',
]);
} else {
expect(log).toEqual([