Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Start warning when calling a legacy factory

Browse Source 
Let's start warning when a legacy factory is called as a plain function call.
This commit is contained in:
Sebastian Markbage
2014-08-19 23:16:41 -07:00
committed by Paul O’Shannessy
parent 989e6b618e
commit 68b7b82145
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/ReactLegacyDescriptor.js
+9 -2
View File
@@ -31,12 +31,19 @@ function warnForLegacyFactoryCall() {
return;
}
var owner = ReactCurrentOwner.current;
var name = owner && owner.constructor ? owner.constructor.displayName : 'N/A';
var name = owner && owner.constructor ? owner.constructor.displayName : '';
if (!name) {
name = 'Something';
}
if (legacyFactoryLogs.hasOwnProperty(name)) {
return;
}
legacyFactoryLogs[name] = true;
// TODO: Warn for this.
warning(
false,
name + ' is calling a React component directly. ' +
'Use a factory or JSX instead. See: http://fb.me/react-legacyfactory'
);
monitorCodeUse('react_legacy_factory_call', { name: name });
}