Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Gate DevTools test to fix CI (#26742)

Browse Source 
This test started failing recently in older versions of React because
the Scheduler priority inside a microtask is Normal instead of
Immediate. This is expected because microtasks are not Scheduler tasks;
it's an implementation detail.

I gated the test to only run in v17 because it's a regression test for
legacy Suspense behavior, and the implementation details of the snapshot
changed in v18.

Test plan
---------

Using latest:

```
yarn test --build --project devtools --release-channel=experimental profilingcache
```

Using v17 (typically runs in a timed CI workflow):

```
/scripts/circleci/download_devtools_regression_build.js 17.0 --replaceBuild
yarn test --build --project devtools --release-channel=experimental --reactVersion 17.0 profilingcache
```

DiffTrain build for commit https://github.com/facebook/react/commit/86b0e91998a04b22bb54a95d54f4a7632efa902f.
This commit is contained in:
acdlite
2023-04-29 15:19:59 +00:00
parent 1ef6880988
commit 66cdfab809
13 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
Vendored
+1 -1
View File
@@ -23894,7 +23894,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-next-b12bea62d-20230428";
var ReactVersion = "18.3.0-next-86b0e9199-20230429";
// Might add PROFILE later.
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
Vendored
+2 -2
View File
@@ -8608,7 +8608,7 @@ var devToolsConfig$jscomp$inline_1024 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-next-b12bea62d-20230428",
version: "18.3.0-next-86b0e9199-20230429",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1209 = {
@@ -8639,7 +8639,7 @@ var internals$jscomp$inline_1209 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1210 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
Vendored
+2 -2
View File
@@ -9034,7 +9034,7 @@ var devToolsConfig$jscomp$inline_1066 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-next-b12bea62d-20230428",
version: "18.3.0-next-86b0e9199-20230429",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1250 = {
@@ -9065,7 +9065,7 @@ var internals$jscomp$inline_1250 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1251 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js
Vendored
+1 -1
View File
@@ -27,7 +27,7 @@ if (
}
"use strict";
var ReactVersion = "18.3.0-next-b12bea62d-20230428";
var ReactVersion = "18.3.0-next-86b0e9199-20230429";
// ATTENTION
// When adding new symbols to this file,
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js
Vendored
+1 -1
View File
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-next-b12bea62d-20230428";
exports.version = "18.3.0-next-86b0e9199-20230429";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js
Vendored
+1 -1
View File
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-next-b12bea62d-20230428";
exports.version = "18.3.0-next-86b0e9199-20230429";
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
+1 -1
View File
@@ -1 +1 @@
b12bea62d9cfd9a925f28cb2c93daeda3865a64e
86b0e91998a04b22bb54a95d54f4a7632efa902f
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js
+1 -1
View File
@@ -27204,7 +27204,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-next-b12bea62d-20230428";
var ReactVersion = "18.3.0-next-86b0e9199-20230429";
function createPortal$1(
children,
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js
+2 -2
View File
@@ -9479,7 +9479,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1048 = {
findFiberByHostInstance: getInstanceFromNode,
bundleType: 0,
version: "18.3.0-next-b12bea62d-20230428",
version: "18.3.0-next-86b0e9199-20230429",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
@@ -9521,7 +9521,7 @@ var internals$jscomp$inline_1279 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1280 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js
+2 -2
View File
@@ -10188,7 +10188,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1126 = {
findFiberByHostInstance: getInstanceFromNode,
bundleType: 0,
version: "18.3.0-next-b12bea62d-20230428",
version: "18.3.0-next-86b0e9199-20230429",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
@@ -10243,7 +10243,7 @@ var roots = new Map(),
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
});
exports.createPortal = function (children, containerTag) {
return createPortal$1(
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js
+1 -1
View File
@@ -27717,7 +27717,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-next-b12bea62d-20230428";
var ReactVersion = "18.3.0-next-86b0e9199-20230429";
function createPortal$1(
children,
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js
+2 -2
View File
@@ -9738,7 +9738,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1103 = {
findFiberByHostInstance: getInstanceFromTag,
bundleType: 0,
version: "18.3.0-next-b12bea62d-20230428",
version: "18.3.0-next-86b0e9199-20230429",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
@@ -9780,7 +9780,7 @@ var internals$jscomp$inline_1348 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1349 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js
+2 -2
View File
@@ -10447,7 +10447,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1181 = {
findFiberByHostInstance: getInstanceFromTag,
bundleType: 0,
version: "18.3.0-next-b12bea62d-20230428",
version: "18.3.0-next-86b0e9199-20230429",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
@@ -10502,7 +10502,7 @@ var roots = new Map(),
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
computeComponentStackForErrorReporting: function (reactTag) {