Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adjust Error stack columns numbers by 1 (#21865)

Browse Source 
To account for differences between error stacks (1-based) and ASTs (0-based). In practice this change should not make an observable difference.
This commit is contained in:
Brian Vaughn
2021-07-13 13:28:01 -04:00
committed by GitHub
parent 464f275724
commit 64bbd7a7f1
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-devtools-extensions/src/astUtils.js
Vendored
+11
View File
@@ -40,6 +40,17 @@ function checkNodeLocation(
return false;
}
// Column numbers are representated differently between tools/engines.
// Error.prototype.stack columns are 1-based (like most IDEs) but ASTs are 0-based.
//
// In practice this will probably never matter,
// because this code matches the 1-based Error stack location for the hook Identifier (e.g. useState)
// with the larger 0-based VariableDeclarator (e.g. [foo, setFoo] = useState())
// so the ranges should always overlap.
//
// For more info see https://github.com/facebook/react/pull/21833#discussion_r666831276
column -= 1;
if (
(line === start.line && column < start.column) ||
(line === end.line && column > end.column)
packages/react-devtools-extensions/src/parseHookNames.js
Vendored
+2
View File
@@ -378,6 +378,7 @@ function findHookNames(
line: lineNumber,
// Column numbers are representated differently between tools/engines.
// Error.prototype.stack columns are 1-based (like most IDEs) but ASTs are 0-based.
// For more info see https://github.com/facebook/react/issues/21792#issuecomment-873171991
column: columnNumber - 1,
});
@@ -476,6 +477,7 @@ async function parseSourceAST(
line: lineNumber,
// Column numbers are representated differently between tools/engines.
// Error.prototype.stack columns are 1-based (like most IDEs) but ASTs are 0-based.
// For more info see https://github.com/facebook/react/issues/21792#issuecomment-873171991
column: columnNumber - 1,
});