Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Elide empty if alternate blocks in codegen

Browse Source
This commit is contained in:
Joe Savona
2023-05-17 15:55:51 -07:00
parent 84a356274a
commit 5ee23af1a6
4 changed files with 10 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/ReactiveScopes/CodegenReactiveFunction.ts
+10 -7
View File
@@ -385,13 +385,16 @@ function codegenTerminal(
);
}
case "if": {
return t.ifStatement(
codegenPlace(cx, terminal.test),
codegenBlock(cx, terminal.consequent),
terminal.alternate !== null
? codegenBlock(cx, terminal.alternate)
: null
);
const test = codegenPlace(cx, terminal.test);
const consequent = codegenBlock(cx, terminal.consequent);
let alternate: t.Statement | null = null;
if (terminal.alternate !== null) {
const block = codegenBlock(cx, terminal.alternate);
if (block.body.length !== 0) {
alternate = block;
}
}
return t.ifStatement(test, consequent, alternate);
}
case "return": {
const value = codegenPlace(cx, terminal.value);
compiler/forget/src/__tests__/fixtures/compiler/constant-propagation-phi.expect.md
-1
View File
@@ -23,7 +23,6 @@ function foo(a, b, c) {
```javascript
function foo(a, b, c) {
if (a) {
} else {
}
return b;
}
compiler/forget/src/__tests__/fixtures/compiler/reverse-postorder.expect.md
-1
View File
@@ -51,7 +51,6 @@ function Component(props) {
}
} else {
if (props.cond2) {
} else {
}
}
}
compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/rules-of-hooks-c1e8c7f4c191.expect.md
-40
View File
@@ -147,124 +147,84 @@ function MyComponent() {
// Is valid but hard to compute by brute-forcing
function MyComponent() {
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
if (c) {
} else {
}
useHook();