Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add Circle CI API token to request header if available (#26519)

Browse Source 
Follow up of #26499
A Circle CI team member got back to me. It is indeed not necessary, but
they had a regression not long ago on fetching without token.

https://discuss.circleci.com/t/is-api-token-required-when-fetching-artifacts/47606/5

To mitigate the impact of this kind of issues, let's add this token to
requests' header when it's available.
This commit is contained in:
Mengdi Chen
2023-03-30 16:06:56 -04:00
committed by GitHub
parent 73deff0d51
commit 5b8cf20b38
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/release/shared-commands/download-build-artifacts.js
+7 -1
View File
@@ -22,9 +22,15 @@ const run = async ({build, cwd, releaseChannel}) => {
}
// Download and extract artifact
const {CIRCLE_CI_API_TOKEN} = process.env;
let header = '';
// Add Circle CI API token to request header if available.
if (CIRCLE_CI_API_TOKEN != null) {
header = '-H "Circle-Token: ${CIRCLE_CI_API_TOKEN}" ';
}
await exec(`rm -rf ./build`, {cwd});
await exec(
`curl -L $(fwdproxy-config curl) ${buildArtifacts.url} | tar -xvz`,
`curl -L $(fwdproxy-config curl) ${buildArtifacts.url} ${header}| tar -xvz`,
{
cwd,
}
scripts/release/utils.js
+6 -1
View File
@@ -59,8 +59,13 @@ const extractCommitFromVersionNumber = version => {
};
const getArtifactsList = async buildID => {
const headers = {};
const {CIRCLE_CI_API_TOKEN} = process.env;
if (CIRCLE_CI_API_TOKEN != null) {
headers['Circle-Token'] = CIRCLE_CI_API_TOKEN;
}
const jobArtifactsURL = `https://circleci.com/api/v1.1/project/github/facebook/react/${buildID}/artifacts`;
const jobArtifacts = await fetch(jobArtifactsURL);
const jobArtifacts = await fetch(jobArtifactsURL, {headers});
return jobArtifacts.json();
};