Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support more properties for image maps

Browse Source 
Supporting the `<area>` tag is pretty useless if we don't support the necessary properties.
This commit is contained in:
Paul O'Shannessy
2014-06-30 20:54:44 -07:00
committed by Paul O’Shannessy
parent 5eb57fa51b
commit 5b17e75707
2 changed files with 141 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/browser/ui/dom/HTMLDOMPropertyConfig.js
+3
View File
@@ -82,6 +82,7 @@ var HTMLDOMPropertyConfig = {
contentEditable: null,
contextMenu: MUST_USE_ATTRIBUTE,
controls: MUST_USE_PROPERTY | HAS_BOOLEAN_VALUE,
coords: null,
crossOrigin: null,
data: null, // For `<object />` acts as `src`.
dateTime: MUST_USE_ATTRIBUTE,
@@ -133,6 +134,7 @@ var HTMLDOMPropertyConfig = {
scrollTop: MUST_USE_PROPERTY,
seamless: MUST_USE_ATTRIBUTE | HAS_BOOLEAN_VALUE,
selected: MUST_USE_PROPERTY | HAS_BOOLEAN_VALUE,
shape: null,
size: MUST_USE_ATTRIBUTE | HAS_POSITIVE_NUMERIC_VALUE,
span: HAS_POSITIVE_NUMERIC_VALUE,
spellCheck: null,
@@ -146,6 +148,7 @@ var HTMLDOMPropertyConfig = {
target: null,
title: null,
type: null,
useMap: null,
value: MUST_USE_PROPERTY | HAS_SIDE_EFFECTS,
width: MUST_USE_ATTRIBUTE,
wmode: MUST_USE_ATTRIBUTE,
vendor/fbtransform/transforms/__tests__/react-displayName-test.js
Vendored
+138
View File
@@ -0,0 +1,138 @@
/**
* Copyright 2004-present Facebook. All Rights Reserved.
*
* @emails jeffmo@fb.com
*/
"use strict";
require('mock-modules').autoMockOff();
var transformAll = require('../../syntax.js').transformAll;
function transform(source) {
return transformAll(source, {}, ['allocate']);
}
describe('react displayName jsx', function() {
it('should only inject displayName if missing', function() {
var code = [
'/** @jsx React.DOM */',
'"use strict";',
'var Whateva = React.createClass({',
' displayName: \'Whateva\',',
' render: function() {',
' return <div className=\'whateva\'>...whateva.</div>;',
' }',
'});'
].join('\n');
var result = [
'/** @jsx React.DOM */',
'"use strict";',
'var Whateva = React.createClass({',
' displayName: \'Whateva\',',
' render: function() {',
' return React.DOM.div({className: "whateva"}, "...whateva.");',
' }',
'});'
].join('\n');
expect(transform(code).code).toEqual(result);
});
it('should inject displayName in simple assignment', () => {
var code = [
'/** @jsx React.DOM */',
'var Component = React.createClass({',
' render: function() {',
' return <div/>;',
' }',
'});'
].join('\n');
var result = [
'/** @jsx React.DOM */',
'var Component = React.createClass({displayName: \'Component\',',
' render: function() {',
' return React.DOM.div(null);',
' }',
'});'
].join('\n');
expect(transform(code).code).toEqual(result);
});
it('should inject displayName in simple assignment without var', () => {
var code = [
'/** @jsx React.DOM */',
'var Component;',
'Component = React.createClass({',
' render: function() {',
' return <div/>;',
' }',
'});'
].join('\n');
var result = [
'/** @jsx React.DOM */',
'var Component;',
'Component = React.createClass({displayName: \'Component\',',
' render: function() {',
' return React.DOM.div(null);',
' }',
'});'
].join('\n');
expect(transform(code).code).toEqual(result);
});
it('should inject displayName in property assignment', () => {
var code = [
'/** @jsx React.DOM */',
'exports.Component = React.createClass({',
' render: function() {',
' return <div/>;',
' }',
'});'
].join('\n');
var result = [
'/** @jsx React.DOM */',
'exports.Component = React.createClass({displayName: \'Component\',',
' render: function() {',
' return React.DOM.div(null);',
' }',
'});'
].join('\n');
expect(transform(code).code).toEqual(result);
});
it('should inject displayName in object declaration', () => {
var code = [
'/** @jsx React.DOM */',
'exports = {',
' Component: React.createClass({',
' render: function() {',
' return <div/>;',
' }',
' })',
'};'
].join('\n');
var result = [
'/** @jsx React.DOM */',
'exports = {',
' Component: React.createClass({displayName: \'Component\',',
' render: function() {',
' return React.DOM.div(null);',
' }',
' })',
'};'
].join('\n');
expect(transform(code).code).toEqual(result);
});
});