Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5003 from spicyj/gh-4996

Browse Source 
Improve warning for old element objects
This commit is contained in:
Ben Alpert
2015-09-29 22:52:08 -07:00
parent 35f731b012 d561949711
commit 5a4b92d8c5
2 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/addons/__tests__/ReactFragment-test.js
+11
View File
@@ -60,6 +60,17 @@ describe('ReactFragment', function() {
);
});
it('should throw if a plain object looks like an old element', function() {
var oldEl = {_isReactElement: true, type: 'span', props: {}};
var container = document.createElement('div');
expect(() => ReactDOM.render(<div>{oldEl}</div>, container)).toThrow(
'Invariant Violation: Objects are not valid as a React child (found: ' +
'object with keys {_isReactElement, type, props}). It looks like ' +
'you\'re using an element created by a different version of React. ' +
'Make sure to use only one copy of React.'
);
});
it('warns for numeric keys on objects as children', function() {
spyOn(console, 'error');
src/shared/utils/traverseAllChildren.js
+11 -4
View File
@@ -181,19 +181,26 @@ function traverseAllChildrenImpl(
} else if (type === 'object') {
var addendum = '';
if (__DEV__) {
addendum =
' If you meant to render a collection of children, use an array ' +
'instead or wrap the object using createFragment(object) from the ' +
'React add-ons.';
if (children._isReactElement) {
addendum =
' It looks like you\'re using an element created by a different ' +
'version of React. Make sure to use only one copy of React.';
}
if (ReactCurrentOwner.current) {
var name = ReactCurrentOwner.current.getName();
if (name) {
addendum = ' Check the render method of `' + name + '`.';
addendum += ' Check the render method of `' + name + '`.';
}
}
}
var childrenString = String(children);
invariant(
false,
'Objects are not valid as a React child (found: %s). If you meant to ' +
'render a collection of children, use an array instead or wrap the ' +
'object using createFragment(object) from the React add-ons.%s',
'Objects are not valid as a React child (found: %s).%s',
childrenString === '[object Object]' ?
'object with keys {' + Object.keys(children).join(', ') + '}' :
childrenString,