Improve eslint derived fixtures

compiler/forget/scripts/build-react-hooks-fixures.js

@@ -16,6 +16,8 @@ const path = require("path");
 const prettier = require("prettier");
 const prettierConfigPath = require.resolve("../.prettierrc");
 const process = require("process");
+const { createHash } = require("crypto");
+const { create } = require("domain");
 
 const FIXTURES_DIR = path.join(
   process.cwd(),
@@ -26,6 +28,10 @@ const FIXTURES_DIR = path.join(
   "rules-of-hooks"
 );
 
+const PRETTIER_OPTIONS = prettier.resolveConfig.sync(FIXTURES_DIR, {
+  config: prettierConfigPath,
+});
+
 const fixtures = [];
 for (const test of tests.valid) {
   fixtures.push({ code: test.code, valid: true });
@@ -34,7 +40,6 @@ for (const test of tests.invalid) {
   fixtures.push({ code: test.code, valid: false });
 }
 
-let index = 0;
 for (const fixture of fixtures) {
   let error = null;
   let passes = true;
@@ -63,29 +68,29 @@ for (const fixture of fixtures) {
   } catch (e) {
     error = e;
   }
-  let name = `rules-of-hooks-${index}.js`;
   let code = fixture.code;
+  let prefix = "";
   if (error !== null) {
-    name = `todo.${name}`;
-    code = `// @skip\n${code}`;
+    prefix = `todo.`;
+    code = `// @skip\n// Unsupported input\n${code}`;
   } else if (fixture.valid === false) {
-    name = `error.${name}`;
+    prefix = `error.`;
     if (passes) {
       // oops, passed when we expected an error
-      name = `todo.${name}`;
-      code = `// @skip\n${code}`;
+      prefix = `todo.error.`;
+      code = `// @skip\n// Passed but should have errored\n${code}`;
     }
   } else if (!passes) {
     // oops, error when it should have passed
-    name = `todo.${name}`;
-    code = `// @skip\n${code}`;
+    prefix = `todo.`;
+    code = `// @skip\n// Failed but should have passed\n${code}`;
   }
-
+  const formatted = prettier.format(code, PRETTIER_OPTIONS);
+  const hmac = createHash("sha256");
+  hmac.update(formatted, "utf8");
+  let name = `${prefix}rules-of-hooks-${hmac
+    .digest("hex")
+    .substring(0, 12)}.js`;
   const fixturePath = path.join(FIXTURES_DIR, name);
-  const options = prettier.resolveConfig.sync(fixturePath, {
-    config: prettierConfigPath,
-  });
-  const formatted = prettier.format(code, options);
   fs.writeFileSync(fixturePath, formatted, "utf8");
-  index++;
 }

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/rules-of-hooks-0e2214abc294.expect.md

@@ -0,0 +1,28 @@
+
+## Input
+
+```javascript
+// Valid because exceptions abort rendering
+function RegressionTest() {
+  if (page == null) {
+    throw new Error("oh no!");
+  }
+  useState();
+}
+
+```
+
+## Code
+
+```javascript
+// Valid because exceptions abort rendering
+function RegressionTest() {
+  if (page == null) {
+    throw new Error("oh no!");
+  }
+
+  useState();
+}
+
+```
+      

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/rules-of-hooks-0e2214abc294.js

@@ -1,5 +1,3 @@
-// @skip
-
 // Valid because exceptions abort rendering
 function RegressionTest() {
   if (page == null) {

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-0a42415d4990.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // This is invalid because "use"-prefixed functions used in named
 // functions are assumed to be hooks.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-112dd48477e6.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's dangerous and might not warn otherwise.
 // This *must* be invalid.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-1a1e29f21a79.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's a common misunderstanding.
 // We *could* make it valid but the runtime error could be confusing.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-251e67613de1.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's dangerous and might not warn otherwise.
 // This *must* be invalid.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-310a4e022130.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's a common misunderstanding.
 // We *could* make it valid but the runtime error could be confusing.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-3d8726664cf7.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Currently invalid because it violates the convention and removes the "taint"
 // from a hook. We *could* make it valid to avoid some false positives but let's

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-42576e5c5613.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 class ClassComponentWithFeatureFlag extends React.Component {
   render() {

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-429b3b1a8ee4.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // These are neither functions nor hooks.
 function _normalFunctionWithHook() {

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-4d1a9ed4d44a.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's dangerous and might not warn otherwise.
 // This *must* be invalid.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-52cd6055b4fb.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's a common misunderstanding.
 // We *could* make it valid but the runtime error could be confusing.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-60e23f3caf5b.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's dangerous and might not warn otherwise.
 // This *must* be invalid.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-7451860cd46f.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 (class {
   useHook() {

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-7bcc5c5c0416.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 Hook.useState();
 Hook._useState();

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-880ce4a7e686.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's dangerous.
 // Normally, this would crash, but not if you use inline requires.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-92503f581023.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's dangerous and might not warn otherwise.
 // This *must* be invalid.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-b4af90990150.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's a common misunderstanding.
 // We *could* make it valid but the runtime error could be confusing.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-be9bff592ca0.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 (class {
   h = () => {

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-c0069d062d50.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 class C {
   m() {

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-c277f25e7c03.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Technically this is a false positive.
 // We *could* make it valid (and it used to be).

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-cdcb36730551.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // Invalid because it's dangerous and might not warn otherwise.
 // This *must* be invalid.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-de96bb13ad47.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 class ClassComponentWithHook extends React.Component {
   render() {

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-e803203d651b.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 (class {
   useHook = () => {

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-f486864c4bec.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 // This is a false positive (it's valid) that unfortunately
 // we cannot avoid. Prefer to rename it to not start with "use"

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.error.rules-of-hooks-fbe12b5ccfce.js

@@ -1,4 +1,5 @@
 // @skip
+// Passed but should have errored
 
 (class {
   i() {

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.rules-of-hooks-279ac76f53af.js

@@ -1,4 +1,5 @@
 // @skip
+// Unsupported input
 
 // Valid -- this is a regression test.
 jest.useFakeTimers();

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.rules-of-hooks-27c18dc8dad2.js

@@ -1,4 +1,5 @@
 // @skip
+// Unsupported input
 
 // Invalid because it's dangerous and might not warn otherwise.
 // This *must* be invalid.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.rules-of-hooks-28a78701970c.js

@@ -1,4 +1,5 @@
 // @skip
+// Unsupported input
 
 // Valid because hooks can be used in anonymous function arguments to
 // React.memo.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.rules-of-hooks-3d692676194b.js

@@ -1,4 +1,5 @@
 // @skip
+// Unsupported input
 
 // Invalid because it's a common misunderstanding.
 // We *could* make it valid but the runtime error could be confusing.

compiler/forget/src/__tests__/fixtures/compiler/rules-of-hooks/todo.rules-of-hooks-6949b255e7eb.js

@@ -1,4 +1,5 @@
 // @skip
+// Unsupported input
 
 // Valid because the neither the conditions before or after the hook affect the hook call
 // Failed prior to implementing BigInt because pathsFromStartToEnd and allPathsFromStartToEnd were too big and had rounding errors