Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[be] Tidy up some mutableRange logic

Browse Source
This commit is contained in:
Joe Savona
2023-02-13 15:26:07 -08:00
parent 225fe0835c
commit 5673588be4
2 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/Inference/InferMutableLifetimes.ts
+3 -3
View File
@@ -102,14 +102,14 @@ export function inferMutableLifetimes(
for (const [_, block] of func.body.blocks) {
for (const phi of block.phis) {
let start = Number.MAX_SAFE_INTEGER;
let end = Number.MIN_SAFE_INTEGER;
let end = phi.id.mutableRange.end as number;
for (const [_, operand] of phi.operands) {
start = Math.min(start, operand.mutableRange.start);
end = Math.max(end, operand.mutableRange.end);
}
invariant(
start !== Number.MAX_SAFE_INTEGER && end !== Number.MIN_SAFE_INTEGER,
"Expected phi to have set start/end range values"
start !== Number.MAX_SAFE_INTEGER,
"Expected phi to have a start range value"
);
phi.id.mutableRange = {
start: makeInstructionId(start),
compiler/forget/src/ReactiveScopes/InferReactiveScopeVariables.ts
-9
View File
@@ -148,15 +148,6 @@ export function inferReactiveScopeVariables(fn: HIRFunction): void {
}
vars.add(identifier);
});
// Copy scope ranges to identifier ranges: not strictly required but this is useful
// for visualization
for (const [scope, vars] of scopeVariables) {
for (const identifier of vars) {
identifier.mutableRange.start = scope.range.start;
identifier.mutableRange.end = scope.range.end;
}
}
}
// Is the operand mutable at this given instruction