Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Transition Tracing] Fix Cache and Transitions Pop Order (#24719)

Browse Source 
We push the Cache before the transition so we should pop the transition before the cache. This PR fixes this issue.
This commit is contained in:
Luna Ruan
2022-06-14 11:48:01 -07:00
committed by GitHub
parent be229c5655
commit 54f17e490f
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-reconciler/src/ReactFiberTransition.new.js
+4 -4
View File
@@ -139,13 +139,13 @@ export function pushTransition(
export function popTransition(workInProgress: Fiber, current: Fiber | null) {
if (current !== null) {
if (enableCache) {
pop(resumedCache, workInProgress);
}
if (enableTransitionTracing) {
pop(transitionStack, workInProgress);
}
if (enableCache) {
pop(resumedCache, workInProgress);
}
}
}
packages/react-reconciler/src/ReactFiberTransition.old.js
+4 -4
View File
@@ -139,13 +139,13 @@ export function pushTransition(
export function popTransition(workInProgress: Fiber, current: Fiber | null) {
if (current !== null) {
if (enableCache) {
pop(resumedCache, workInProgress);
}
if (enableTransitionTracing) {
pop(transitionStack, workInProgress);
}
if (enableCache) {
pop(resumedCache, workInProgress);
}
}
}