Change ReactVersion from CJS to ES module (#18181)

This commit is contained in:
Sebastian Markbåge
2020-02-28 13:09:02 -08:00
committed by GitHub
parent 58eedbb024
commit 4469700bb6
4 changed files with 10 additions and 10 deletions
+1 -3
View File
@@ -5,7 +5,5 @@
* LICENSE file in the root directory of this source tree.
*/
'use strict';
// TODO: this is special because it gets imported during build.
module.exports = '16.13.0';
export default '16.13.0';
@@ -44,7 +44,7 @@ const run = async ({cwd, packages, skipPackages, tags}) => {
const sourceReactVersion = readFileSync(
sourceReactVersionPath,
'utf8'
).replace(/module\.exports = '[^']+';/, `module.exports = '${version}';`);
).replace(/export default '[^']+';/, `export default '${version}';`);
writeFileSync(sourceReactVersionPath, sourceReactVersion);
}
};
+1 -4
View File
@@ -209,10 +209,7 @@ const updateVersionsForNext = async (cwd, reactVersion, version) => {
const sourceReactVersion = readFileSync(
sourceReactVersionPath,
'utf8'
).replace(
/module\.exports = '[^']+';/,
`module.exports = '${reactVersion}';`
);
).replace(/export default '[^']+';/, `export default '${reactVersion}';`);
writeFileSync(sourceReactVersionPath, sourceReactVersion);
// Update the root package.json.
+7 -2
View File
@@ -7,7 +7,12 @@
'use strict';
const reactVersion = require('../../package.json').version;
const fs = require('fs');
const ReactVersionSrc = fs.readFileSync(
require.resolve('../../packages/shared/ReactVersion')
);
const reactVersion = /export default '([^']+)';/.exec(ReactVersionSrc)[1];
const versions = {
'packages/react/package.json': require('../../packages/react/package.json')
.version,
@@ -15,7 +20,7 @@ const versions = {
.version,
'packages/react-test-renderer/package.json': require('../../packages/react-test-renderer/package.json')
.version,
'packages/shared/ReactVersion.js': require('../../packages/shared/ReactVersion'),
'packages/shared/ReactVersion.js': reactVersion,
};
let allVersionsMatch = true;