Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

DevTools refactor Profiler commit tree reconstruction to be iterative (#21383)

Browse Source
This commit is contained in:
Brian Vaughn
2021-04-28 16:32:35 -04:00
committed by GitHub
parent 9e9dac6505
commit 3c21aa855a
1 changed files with 28 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js
Vendored
+28 -35
View File
@@ -56,7 +56,6 @@ export function getCommitTree({
const commitTrees = ((rootToCommitTreeMap.get(
rootID,
): any): Array<CommitTree>);
if (commitIndex < commitTrees.length) {
return commitTrees[commitIndex];
}
@@ -72,52 +71,46 @@ export function getCommitTree({
}
const {operations} = dataForRoot;
if (operations.length <= commitIndex) {
throw Error(
`getCommitTree(): Invalid commit "${commitIndex}" for root "${rootID}". There are only "${operations.length}" commits.`,
);
}
// Commits are generated sequentially and cached.
// If this is the very first commit, start with the cached snapshot and apply the first mutation.
// Otherwise load (or generate) the previous commit and append a mutation to it.
if (commitIndex === 0) {
const nodes = new Map();
let commitTree: CommitTree = ((null: any): CommitTree);
for (let index = commitTrees.length; index <= commitIndex; index++) {
// Commits are generated sequentially and cached.
// If this is the very first commit, start with the cached snapshot and apply the first mutation.
// Otherwise load (or generate) the previous commit and append a mutation to it.
if (index === 0) {
const nodes = new Map();
// Construct the initial tree.
recursivelyInitializeTree(rootID, 0, nodes, dataForRoot);
// Construct the initial tree.
recursivelyInitializeTree(rootID, 0, nodes, dataForRoot);
// Mutate the tree
if (operations != null && commitIndex < operations.length) {
const commitTree = updateTree({nodes, rootID}, operations[commitIndex]);
// Mutate the tree
if (operations != null && index < operations.length) {
commitTree = updateTree({nodes, rootID}, operations[index]);
if (__DEBUG__) {
__printTree(commitTree);
}
commitTrees.push(commitTree);
}
} else {
const previousCommitTree = commitTrees[index - 1];
commitTree = updateTree(previousCommitTree, operations[index]);
if (__DEBUG__) {
__printTree(commitTree);
}
commitTrees.push(commitTree);
return commitTree;
}
} else {
const previousCommitTree = getCommitTree({
commitIndex: commitIndex - 1,
profilerStore,
rootID,
});
if (operations != null && commitIndex < operations.length) {
const commitTree = updateTree(
previousCommitTree,
operations[commitIndex],
);
if (__DEBUG__) {
__printTree(commitTree);
}
commitTrees.push(commitTree);
return commitTree;
}
}
throw Error(
`getCommitTree(): Unable to reconstruct tree for root "${rootID}" and commit "${commitIndex}"`,
);
return commitTree;
}
function recursivelyInitializeTree(