Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move some tests from failing to passing except dev (#9711)

Browse Source 
These throw because we're asserting on the warnings. Make this not throw
so that they instead only fail to assert the warnings.
This commit is contained in:
Sebastian Markbåge
2017-05-17 23:54:26 -07:00
committed by GitHub
parent e5e874d0e8
commit 39671ba45b
3 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/fiber/tests-failing.txt
-5
View File
@@ -1,8 +1,3 @@
src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
* gives source code refs for unknown prop warning (ssr)
* gives source code refs for unknown prop warning for exact elements (ssr)
* gives source code refs for unknown prop warning for exact elements in composition (ssr)
src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
* renders a blank div with client render on top of good server markup
* renders a div with inline styles with client render on top of good server markup
scripts/fiber/tests-passing-except-dev.txt
+3
View File
@@ -1,4 +1,7 @@
src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
* gives source code refs for unknown prop warning (ssr)
* gives source code refs for unknown prop warning for exact elements (ssr)
* gives source code refs for unknown prop warning for exact elements in composition (ssr)
* should suggest property name if available (ssr)
src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js
src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
+17 -14
View File
@@ -1592,10 +1592,10 @@ describe('ReactDOMComponent', () => {
ReactTestUtils.renderIntoDocument(<div class="paladin" />);
ReactTestUtils.renderIntoDocument(<input type="text" onclick="1" />);
expectDev(console.error.calls.count()).toBe(2);
expect(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
'Warning: Unknown DOM property class. Did you mean className?\n in div (at **)',
);
expect(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toBe(
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toBe(
'Warning: Unknown event handler property onclick. Did you mean ' +
'`onClick`?\n in input (at **)',
);
@@ -1606,10 +1606,10 @@ describe('ReactDOMComponent', () => {
ReactDOMServer.renderToString(<div class="paladin" />);
ReactDOMServer.renderToString(<input type="text" onclick="1" />);
expectDev(console.error.calls.count()).toBe(2);
expect(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
'Warning: Unknown DOM property class. Did you mean className?\n in div (at **)',
);
expect(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toBe(
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toBe(
'Warning: Unknown event handler property onclick. Did you mean ' +
'`onClick`?\n in input (at **)',
);
@@ -1624,7 +1624,7 @@ describe('ReactDOMComponent', () => {
ReactTestUtils.renderIntoDocument(<div class="paladin" />, container);
expectDev(console.error.calls.count()).toBe(1);
expect(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
'Warning: Unknown DOM property class. Did you mean className?\n in div (at **)',
);
});
@@ -1674,15 +1674,16 @@ describe('ReactDOMComponent', () => {
expectDev(console.error.calls.argsFor(0)[0]).toContain('className');
var matches = console.error.calls.argsFor(0)[0].match(/.*\(.*:(\d+)\).*/);
var previousLine = matches[1];
var previousLine = (matches || [])[1];
expectDev(console.error.calls.argsFor(1)[0]).toContain('onClick');
matches = console.error.calls.argsFor(1)[0].match(/.*\(.*:(\d+)\).*/);
var currentLine = matches[1];
matches = console.error.calls.argsFor(1)[0].match(/.*\(.*:(\d+)\).*/) || {
};
var currentLine = (matches || [])[1];
//verify line number has a proper relative difference,
//since hard coding the line number would make test too brittle
expect(parseInt(previousLine, 10) + 2).toBe(parseInt(currentLine, 10));
expectDev(parseInt(previousLine, 10) + 2).toBe(parseInt(currentLine, 10));
});
it('gives source code refs for unknown prop warning for exact elements in composition', () => {
@@ -1725,11 +1726,11 @@ describe('ReactDOMComponent', () => {
expectDev(console.error.calls.argsFor(0)[0]).toContain('className');
var matches = console.error.calls.argsFor(0)[0].match(/.*\(.*:(\d+)\).*/);
var previousLine = matches[1];
var previousLine = (matches || [])[1];
expectDev(console.error.calls.argsFor(1)[0]).toContain('onClick');
matches = console.error.calls.argsFor(1)[0].match(/.*\(.*:(\d+)\).*/);
var currentLine = matches[1];
var currentLine = (matches || [])[1];
//verify line number has a proper relative difference,
//since hard coding the line number would make test too brittle
@@ -1776,15 +1777,17 @@ describe('ReactDOMComponent', () => {
expectDev(console.error.calls.argsFor(0)[0]).toContain('className');
var matches = console.error.calls.argsFor(0)[0].match(/.*\(.*:(\d+)\).*/);
var previousLine = matches[1];
var previousLine = (matches || [])[1];
expectDev(console.error.calls.argsFor(1)[0]).toContain('onClick');
matches = console.error.calls.argsFor(1)[0].match(/.*\(.*:(\d+)\).*/);
var currentLine = matches[1];
var currentLine = (matches || [])[1];
//verify line number has a proper relative difference,
//since hard coding the line number would make test too brittle
expect(parseInt(previousLine, 10) + 12).toBe(parseInt(currentLine, 10));
expectDev(parseInt(previousLine, 10) + 12).toBe(
parseInt(currentLine, 10),
);
});
it('should suggest property name if available', () => {