Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[compiler] ValidatePreservedManualMemoization reports detailed errors

Browse Source 
This pass didn't previously report the precise difference btw inferred/manual dependencies unless a debug flag was set. But the error message is really good (nice job mofeiz): the only catch is that in theory the inferred dep could be a temporary that can't trivially be reported to the user.

But the messages are really useful for quickly verifying why the compiler couldn't preserve memoization. So here we switch to outputting a detailed message about the discrepancy btw inferred/manual deps so long as the inferred dep root is a named variable. I also slightly adjusted the message to handle the case where there is no diagnostic, which can occur if there were no manual deps but the compiler inferred a dependency.

ghstack-source-id: 534f6f1fec
Pull Request resolved: https://github.com/facebook/react/pull/33095

DiffTrain build for [73d7e816b7](https://github.com/facebook/react/commit/73d7e816b7746c700ab843964aaf11c17351fac1)
This commit is contained in:
josephsavona
2025-05-02 17:15:46 -07:00
parent 4c4b5dcb6f
commit 31e777b1b6
26 changed files with 171 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiled-rn/VERSION_NATIVE_FB
+1 -1
View File
@@ -1 +1 @@
19.2.0-native-fb-ac2cae52-20250503
19.2.0-native-fb-73d7e816-20250503
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js
Vendored
+2 -2
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<3a8e713f412b3794cee2c3089ed3d3c2>>
* @generated SignedSource<<dadf06a20985029b6861a4307fb1da98>>
*/
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
})();
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js
Vendored
+2 -2
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<6a8ce524bc621b2c0f8ab229a0f9eaf0>>
* @generated SignedSource<<1356d4b7847e2241f243d75788b823dc>>
*/
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js
Vendored
+2 -2
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<6a8ce524bc621b2c0f8ab229a0f9eaf0>>
* @generated SignedSource<<1356d4b7847e2241f243d75788b823dc>>
*/
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js
Vendored
+6 -6
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<d999b69864aa6594360027e7244bf1fb>>
* @generated SignedSource<<ee64ceeff7fe57a7c3dd0420d0476eca>>
*/
/*
@@ -26650,11 +26650,11 @@ __DEV__ &&
};
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.2.0-native-fb-ac2cae52-20250503" !== isomorphicReactPackageVersion)
if ("19.2.0-native-fb-73d7e816-20250503" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.2.0-native-fb-ac2cae52-20250503\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.2.0-native-fb-73d7e816-20250503\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
@@ -26691,10 +26691,10 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26838,5 +26838,5 @@ __DEV__ &&
listenToAllSupportedEvents(container);
return new ReactDOMHydrationRoot(initialChildren);
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
})();
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js
Vendored
+6 -6
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<6a7f6ee6e3e54d5c956e50d34914495a>>
* @generated SignedSource<<6d9d3190d467f241fb17f29ff0850020>>
*/
/*
@@ -16748,14 +16748,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_1904 = React.version;
if (
"19.2.0-native-fb-ac2cae52-20250503" !==
"19.2.0-native-fb-73d7e816-20250503" !==
isomorphicReactPackageVersion$jscomp$inline_1904
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1904,
"19.2.0-native-fb-ac2cae52-20250503"
"19.2.0-native-fb-73d7e816-20250503"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16777,10 +16777,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_2388 = {
bundleType: 0,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2389 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16884,4 +16884,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
listenToAllSupportedEvents(container);
return new ReactDOMHydrationRoot(initialChildren);
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js
Vendored
+6 -6
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<c95103b4e5c15fa20d15fdc7236baebc>>
* @generated SignedSource<<c0abbf2f409f4e2593303a82962b6a44>>
*/
/*
@@ -17457,14 +17457,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_2007 = React.version;
if (
"19.2.0-native-fb-ac2cae52-20250503" !==
"19.2.0-native-fb-73d7e816-20250503" !==
isomorphicReactPackageVersion$jscomp$inline_2007
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_2007,
"19.2.0-native-fb-ac2cae52-20250503"
"19.2.0-native-fb-73d7e816-20250503"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17486,10 +17486,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_2014 = {
bundleType: 0,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503",
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503",
getLaneLabelMap: function () {
for (
var map = new Map(), lane = 1, index$305 = 0;
@@ -17608,4 +17608,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
listenToAllSupportedEvents(container);
return new ReactDOMHydrationRoot(initialChildren);
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js
Vendored
+6 -6
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e660219c89547290a57109978206e297>>
* @generated SignedSource<<8b4ad26c11c18be45d376afb6d7cf2d6>>
*/
/*
@@ -26711,11 +26711,11 @@ __DEV__ &&
};
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.2.0-native-fb-ac2cae52-20250503" !== isomorphicReactPackageVersion)
if ("19.2.0-native-fb-73d7e816-20250503" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.2.0-native-fb-ac2cae52-20250503\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.2.0-native-fb-73d7e816-20250503\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
@@ -26752,10 +26752,10 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -27215,7 +27215,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js
Vendored
+6 -6
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<184c3d14507009449d6281a2251dd50f>>
* @generated SignedSource<<e029fcb0c9ead7bd9bc6565bb7136915>>
*/
/*
@@ -16759,14 +16759,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_1905 = React.version;
if (
"19.2.0-native-fb-ac2cae52-20250503" !==
"19.2.0-native-fb-73d7e816-20250503" !==
isomorphicReactPackageVersion$jscomp$inline_1905
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1905,
"19.2.0-native-fb-ac2cae52-20250503"
"19.2.0-native-fb-73d7e816-20250503"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16788,10 +16788,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_2391 = {
bundleType: 0,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2392 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17049,4 +17049,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js
Vendored
+6 -6
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<6bed75389bb636f888f94799d1e7e022>>
* @generated SignedSource<<f32349997f1a98bef7fc91ebd98f2658>>
*/
/*
@@ -17472,14 +17472,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
};
var isomorphicReactPackageVersion$jscomp$inline_2008 = React.version;
if (
"19.2.0-native-fb-ac2cae52-20250503" !==
"19.2.0-native-fb-73d7e816-20250503" !==
isomorphicReactPackageVersion$jscomp$inline_2008
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_2008,
"19.2.0-native-fb-ac2cae52-20250503"
"19.2.0-native-fb-73d7e816-20250503"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17501,10 +17501,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
};
var internals$jscomp$inline_2015 = {
bundleType: 0,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503",
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503",
getLaneLabelMap: function () {
for (
var map = new Map(), lane = 1, index$305 = 0;
@@ -17777,7 +17777,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js
Vendored
+4 -4
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<2d8c2ccd0c8b9504dc651fc1fc02fd73>>
* @generated SignedSource<<218a27c88420439d9243a0160c350659>>
*/
"use strict";
@@ -15630,10 +15630,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-test-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -15778,5 +15778,5 @@ __DEV__ &&
flushSyncWorkAcrossRoots_impl(0, !0));
}
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
})();
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js
Vendored
+4 -4
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<abb7e7559c1257ba79eb209405a6ed8a>>
* @generated SignedSource<<f54ff26e2fbda42407cc6de4ca611452>>
*/
"use strict";
@@ -9885,10 +9885,10 @@ function wrapFiber(fiber) {
}
var internals$jscomp$inline_1439 = {
bundleType: 0,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-test-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1440 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -10024,4 +10024,4 @@ exports.unstable_batchedUpdates = function (fn, a) {
flushSyncWorkAcrossRoots_impl(0, !0));
}
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js
Vendored
+4 -4
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<3b0ba8c0b9fed96a41db1b427580e305>>
* @generated SignedSource<<ecf2fdc36869476f78a75102d1308e95>>
*/
"use strict";
@@ -10502,10 +10502,10 @@ function wrapFiber(fiber) {
}
var internals$jscomp$inline_1247 = {
bundleType: 0,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-test-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503",
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503",
getLaneLabelMap: function () {
for (
var map = new Map(), lane = 1, index$155 = 0;
@@ -10656,4 +10656,4 @@ exports.unstable_batchedUpdates = function (fn, a) {
flushSyncWorkAcrossRoots_impl(0, !0));
}
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js
Vendored
+2 -2
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<40b05f43a39445fc6bde13151a5a395a>>
* @generated SignedSource<<504484e273d1da549a13ed75a00fbcb1>>
*/
"use strict";
@@ -1412,7 +1412,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js
Vendored
+2 -2
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<3dd6f3dc24d4b89bf026e341d634531a>>
* @generated SignedSource<<0e3c2be9f7cd5e3c3c24caf046f24430>>
*/
"use strict";
@@ -587,4 +587,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js
Vendored
+2 -2
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<beb9b6f7bb09117f6bde397c3d074123>>
* @generated SignedSource<<5d40ceda0635286a54100a4001cfa068>>
*/
"use strict";
@@ -591,7 +591,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.2.0-native-fb-ac2cae52-20250503";
exports.version = "19.2.0-native-fb-73d7e816-20250503";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
+1 -1
View File
@@ -1 +1 @@
ac2cae524576b8091a6d78d9ab05627053949df1
73d7e816b7746c700ab843964aaf11c17351fac1
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js
+3 -3
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<a03bd3d62045e17ea4a582c46f0cb25b>>
* @generated SignedSource<<1432ef8debf0338ec417b165da1596cd>>
*/
"use strict";
@@ -17469,10 +17469,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
null !== extraDevToolsConfig &&
(internals.rendererConfig = extraDevToolsConfig);
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js
+3 -3
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<afd7c57f6857a894986bd5a7ec6c0e8c>>
* @generated SignedSource<<73023b20a9732b247453c77f8fe08e63>>
*/
"use strict";
@@ -11210,10 +11210,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1251 = {
bundleType: 0,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1251.rendererConfig = extraDevToolsConfig);
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js
+3 -3
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<379595a5f286b9343623d2a926777951>>
* @generated SignedSource<<ae30f68578e2ed5866a86c9a5e0c4f29>>
*/
"use strict";
@@ -11911,10 +11911,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1352 = {
bundleType: 0,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1352.rendererConfig = extraDevToolsConfig);
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js
+5 -5
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<033aab756eac0a7f1dd9203c53b69aab>>
* @generated SignedSource<<d0b5a33ed825504d52734655f229aa3c>>
*/
"use strict";
@@ -17622,11 +17622,11 @@ __DEV__ &&
shouldSuspendImpl = newShouldSuspendImpl;
};
var isomorphicReactPackageVersion = React.version;
if ("19.2.0-native-fb-ac2cae52-20250503" !== isomorphicReactPackageVersion)
if ("19.2.0-native-fb-73d7e816-20250503" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-native-renderer: 19.2.0-native-fb-ac2cae52-20250503\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-native-renderer: 19.2.0-native-fb-73d7e816-20250503\nLearn more: https://react.dev/warnings/version-mismatch")
);
if (
"function" !==
@@ -17652,10 +17652,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
null !== extraDevToolsConfig &&
(internals.rendererConfig = extraDevToolsConfig);
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js
+5 -5
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<31a98c0952ee0b8c5644898aec3c1455>>
* @generated SignedSource<<b37b8dff97192c1cde34bb9f3d0a9fbe>>
*/
"use strict";
@@ -11243,11 +11243,11 @@ function updateContainer(element, container, parentComponent, callback) {
return lane;
}
var isomorphicReactPackageVersion = React.version;
if ("19.2.0-native-fb-ac2cae52-20250503" !== isomorphicReactPackageVersion)
if ("19.2.0-native-fb-73d7e816-20250503" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-native-renderer: 19.2.0-native-fb-ac2cae52-20250503\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-native-renderer: 19.2.0-native-fb-73d7e816-20250503\nLearn more: https://react.dev/warnings/version-mismatch")
);
if (
"function" !==
@@ -11296,10 +11296,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1299 = {
bundleType: 0,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1299.rendererConfig = extraDevToolsConfig);
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js
+5 -5
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<2d05fcafa5382311e54e41a4f055f76d>>
* @generated SignedSource<<775d8bd1ee5333e8f984ee9021c2ece5>>
*/
"use strict";
@@ -11942,11 +11942,11 @@ function updateContainer(element, container, parentComponent, callback) {
return lane;
}
var isomorphicReactPackageVersion = React.version;
if ("19.2.0-native-fb-ac2cae52-20250503" !== isomorphicReactPackageVersion)
if ("19.2.0-native-fb-73d7e816-20250503" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-native-renderer: 19.2.0-native-fb-ac2cae52-20250503\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-native-renderer: 19.2.0-native-fb-73d7e816-20250503\nLearn more: https://react.dev/warnings/version-mismatch")
);
if (
"function" !==
@@ -11995,10 +11995,10 @@ batchedUpdatesImpl = function (fn, a) {
var roots = new Map(),
internals$jscomp$inline_1400 = {
bundleType: 0,
version: "19.2.0-native-fb-ac2cae52-20250503",
version: "19.2.0-native-fb-73d7e816-20250503",
rendererPackageName: "react-native-renderer",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.2.0-native-fb-ac2cae52-20250503"
reconcilerVersion: "19.2.0-native-fb-73d7e816-20250503"
};
null !== extraDevToolsConfig &&
(internals$jscomp$inline_1400.rendererConfig = extraDevToolsConfig);
compiled-rn/facebook-fbsource/xplat/js/tools/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js
+42 -5
View File
@@ -12,7 +12,7 @@
* @lightSyntaxTransform
* @preventMunge
* @oncall react_core
* @generated SignedSource<<779cdaf32b30e64c4329b58f093932c0>>
* @generated SignedSource<<85ddb959da36c41b641d547b23d8c4d2>>
*/
'use strict';
@@ -50011,7 +50011,7 @@ class ReactiveScopeDependencyTreeHIR {
depCursor = nextDepCursor;
hoistableCursor = nextHoistableCursor;
}
depCursor.accessType = merge(depCursor.accessType, PropertyAccessType.OptionalDependency);
depCursor.accessType = merge$1(depCursor.accessType, PropertyAccessType.OptionalDependency);
}
deriveMinimalDependencies() {
const results = new Set();
@@ -50069,7 +50069,7 @@ function isDependency(access) {
return (access === PropertyAccessType.OptionalDependency ||
access === PropertyAccessType.UnconditionalDependency);
}
function merge(access1, access2) {
function merge$1(access1, access2) {
const resultIsUnconditional = !(isOptional(access1) && isOptional(access2));
const resultIsDependency = isDependency(access1) || isDependency(access2);
if (resultIsUnconditional) {
@@ -50126,7 +50126,7 @@ function makeOrMergeProperty(node, property, accessType) {
node.properties.set(property, child);
}
else {
child.accessType = merge(child.accessType, accessType);
child.accessType = merge$1(child.accessType, accessType);
}
return child;
}
@@ -53320,6 +53320,17 @@ function validatePreservedManualMemoization(fn) {
visitReactiveFunction(fn, new Visitor(), state);
return state.errors.asResult();
}
function prettyPrintScopeDependency(val) {
var _a;
let rootStr;
if (((_a = val.identifier.name) === null || _a === void 0 ? void 0 : _a.kind) === 'named') {
rootStr = val.identifier.name.value;
}
else {
rootStr = '[unnamed]';
}
return `${rootStr}${val.path.map(v => `${v.optional ? '?.' : '.'}${v.property}`).join('')}`;
}
var CompareDependencyResult;
(function (CompareDependencyResult) {
CompareDependencyResult[CompareDependencyResult["Ok"] = 0] = "Ok";
@@ -53328,6 +53339,22 @@ var CompareDependencyResult;
CompareDependencyResult[CompareDependencyResult["Subpath"] = 3] = "Subpath";
CompareDependencyResult[CompareDependencyResult["RefAccessDifference"] = 4] = "RefAccessDifference";
})(CompareDependencyResult || (CompareDependencyResult = {}));
function merge(a, b) {
return Math.max(a, b);
}
function getCompareDependencyResultDescription(result) {
switch (result) {
case CompareDependencyResult.Ok:
return 'Dependencies equal';
case CompareDependencyResult.RootDifference:
case CompareDependencyResult.PathDifference:
return 'Inferred different dependency than source';
case CompareDependencyResult.RefAccessDifference:
return 'Differences in ref.current access';
case CompareDependencyResult.Subpath:
return 'Inferred less specific property than source';
}
}
function compareDeps(inferred, source) {
const rootsEqual = (inferred.root.kind === 'Global' &&
source.root.kind === 'Global' &&
@@ -53405,16 +53432,26 @@ function validateInferredDep(dep, temporaries, declsWithinMemoBlock, validDepsIn
return;
}
}
let errorDiagnostic = null;
for (const originalDep of validDepsInMemoBlock) {
const compareResult = compareDeps(normalizedDep, originalDep);
if (compareResult === CompareDependencyResult.Ok) {
return;
}
else {
errorDiagnostic = merge(errorDiagnostic !== null && errorDiagnostic !== void 0 ? errorDiagnostic : compareResult, compareResult);
}
}
errorState.push({
severity: ErrorSeverity.CannotPreserveMemoization,
reason: 'React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected',
description: null,
description: (dep.identifier.name != null && dep.identifier.name.kind === 'named')
? `The inferred dependency was \`${prettyPrintScopeDependency(dep)}\`, but the source dependencies were [${validDepsInMemoBlock
.map(dep => printManualMemoDependency(dep, true))
.join(', ')}]. ${errorDiagnostic
? getCompareDependencyResultDescription(errorDiagnostic)
: 'Inferred dependency not present in source'}`
: null,
loc: memoLocation,
suggestions: null,
});
compiled-rn/facebook-fbsource/xplat/js/tools/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js
+42 -5
View File
@@ -6,7 +6,7 @@
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
* @generated SignedSource<<f11eb95927bcf6e5fc0334e2cf2e1714>>
* @generated SignedSource<<5876f8f9bad1e2aba5245215e0e99617>>
*/
'use strict';
@@ -49790,7 +49790,7 @@ class ReactiveScopeDependencyTreeHIR {
depCursor = nextDepCursor;
hoistableCursor = nextHoistableCursor;
}
depCursor.accessType = merge(depCursor.accessType, PropertyAccessType.OptionalDependency);
depCursor.accessType = merge$1(depCursor.accessType, PropertyAccessType.OptionalDependency);
}
deriveMinimalDependencies() {
const results = new Set();
@@ -49848,7 +49848,7 @@ function isDependency(access) {
return (access === PropertyAccessType.OptionalDependency ||
access === PropertyAccessType.UnconditionalDependency);
}
function merge(access1, access2) {
function merge$1(access1, access2) {
const resultIsUnconditional = !(isOptional(access1) && isOptional(access2));
const resultIsDependency = isDependency(access1) || isDependency(access2);
if (resultIsUnconditional) {
@@ -49905,7 +49905,7 @@ function makeOrMergeProperty(node, property, accessType) {
node.properties.set(property, child);
}
else {
child.accessType = merge(child.accessType, accessType);
child.accessType = merge$1(child.accessType, accessType);
}
return child;
}
@@ -53099,6 +53099,17 @@ function validatePreservedManualMemoization(fn) {
visitReactiveFunction(fn, new Visitor(), state);
return state.errors.asResult();
}
function prettyPrintScopeDependency(val) {
var _a;
let rootStr;
if (((_a = val.identifier.name) === null || _a === void 0 ? void 0 : _a.kind) === 'named') {
rootStr = val.identifier.name.value;
}
else {
rootStr = '[unnamed]';
}
return `${rootStr}${val.path.map(v => `${v.optional ? '?.' : '.'}${v.property}`).join('')}`;
}
var CompareDependencyResult;
(function (CompareDependencyResult) {
CompareDependencyResult[CompareDependencyResult["Ok"] = 0] = "Ok";
@@ -53107,6 +53118,22 @@ var CompareDependencyResult;
CompareDependencyResult[CompareDependencyResult["Subpath"] = 3] = "Subpath";
CompareDependencyResult[CompareDependencyResult["RefAccessDifference"] = 4] = "RefAccessDifference";
})(CompareDependencyResult || (CompareDependencyResult = {}));
function merge(a, b) {
return Math.max(a, b);
}
function getCompareDependencyResultDescription(result) {
switch (result) {
case CompareDependencyResult.Ok:
return 'Dependencies equal';
case CompareDependencyResult.RootDifference:
case CompareDependencyResult.PathDifference:
return 'Inferred different dependency than source';
case CompareDependencyResult.RefAccessDifference:
return 'Differences in ref.current access';
case CompareDependencyResult.Subpath:
return 'Inferred less specific property than source';
}
}
function compareDeps(inferred, source) {
const rootsEqual = (inferred.root.kind === 'Global' &&
source.root.kind === 'Global' &&
@@ -53184,16 +53211,26 @@ function validateInferredDep(dep, temporaries, declsWithinMemoBlock, validDepsIn
return;
}
}
let errorDiagnostic = null;
for (const originalDep of validDepsInMemoBlock) {
const compareResult = compareDeps(normalizedDep, originalDep);
if (compareResult === CompareDependencyResult.Ok) {
return;
}
else {
errorDiagnostic = merge(errorDiagnostic !== null && errorDiagnostic !== void 0 ? errorDiagnostic : compareResult, compareResult);
}
}
errorState.push({
severity: ErrorSeverity.CannotPreserveMemoization,
reason: 'React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. The inferred dependencies did not match the manually specified dependencies, which could cause the value to change more or less frequently than expected',
description: null,
description: (dep.identifier.name != null && dep.identifier.name.kind === 'named')
? `The inferred dependency was \`${prettyPrintScopeDependency(dep)}\`, but the source dependencies were [${validDepsInMemoBlock
.map(dep => printManualMemoDependency(dep, true))
.join(', ')}]. ${errorDiagnostic
? getCompareDependencyResultDescription(errorDiagnostic)
: 'Inferred dependency not present in source'}`
: null,
loc: memoLocation,
suggestions: null,
});
compiled-rn/facebook-fbsource/xplat/js/tools/eslint-plugin-react-hooks/package.json
+1 -1
View File
@@ -1,7 +1,7 @@
{
"name": "eslint-plugin-react-hooks",
"description": "ESLint rules for React Hooks",
"version": "0.0.0-experimental-ac2cae52-20250503",
"version": "0.0.0-experimental-73d7e816-20250503",
"repository": {
"type": "git",
"url": "https://github.com/facebook/react.git",