Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

useFormState fix: action -> target (#27309)

Browse Source 
I mixed these attributes up in
https://github.com/facebook/react/pull/27302
This commit is contained in:
Andrew Clark
2023-08-29 22:17:15 -04:00
committed by GitHub
parent ddff504695
commit 2fba484cd0
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMForm-test.js
Vendored
+3 -3
View File
@@ -354,7 +354,7 @@ describe('ReactFlightDOMForm', () => {
// @gate enableFormActions
// @gate enableAsyncActions
it("useFormState can change the action's target with the `permalink` argument", async () => {
it('useFormState can change the action URL with the `permalink` argument', async () => {
const serverAction = serverExports(function action(prevState) {
return {state: prevState.count + 1};
});
@@ -386,7 +386,7 @@ describe('ReactFlightDOMForm', () => {
const span = container.getElementsByTagName('span')[0];
expect(span.textContent).toBe('Count: 1');
expect(form.target).toBe('/permalink');
expect(form.action).toBe('http://localhost/permalink');
});
// @gate enableFormActions
@@ -427,6 +427,6 @@ describe('ReactFlightDOMForm', () => {
const span = container.getElementsByTagName('span')[0];
expect(span.textContent).toBe('Count: 1');
expect(form.target).toBe('/permalink');
expect(form.action).toBe('http://localhost/permalink');
});
});
packages/react-server/src/ReactFizzHooks.js
Vendored
+2 -2
View File
@@ -575,12 +575,12 @@ function useFormState<S, P>(
dispatch.$$FORM_ACTION = (prefix: string) => {
// $FlowIgnore[prop-missing]
const metadata: ReactCustomFormAction = boundAction.$$FORM_ACTION(prefix);
// Override the target URL
// Override the action URL
if (permalink !== undefined) {
if (__DEV__) {
checkAttributeStringCoercion(permalink, 'target');
}
metadata.target = permalink + '';
metadata.action = permalink + '';
}
return metadata;
};