Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix <select> check of defaultValue/value type (#21611)

Browse Source
This commit is contained in:
Sebastian Markbåge
2021-06-03 09:13:00 -04:00
committed by GitHub
parent 154a8cf328
commit 2418f24b60
1 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-dom/src/server/ReactDOMServerFormatConfig.js
Vendored
+16 -13
View File
@@ -568,19 +568,22 @@ let didWarnSelectedSetOnOption = false;
function checkSelectProp(props, propName) {
if (__DEV__) {
const array = isArray(props[propName]);
if (props.multiple && !array) {
console.error(
'The `%s` prop supplied to <select> must be an array if ' +
'`multiple` is true.',
propName,
);
} else if (!props.multiple && array) {
console.error(
'The `%s` prop supplied to <select> must be a scalar ' +
'value if `multiple` is false.',
propName,
);
const value = props[propName];
if (value != null) {
const array = isArray(value);
if (props.multiple && !array) {
console.error(
'The `%s` prop supplied to <select> must be an array if ' +
'`multiple` is true.',
propName,
);
} else if (!props.multiple && array) {
console.error(
'The `%s` prop supplied to <select> must be a scalar ' +
'value if `multiple` is false.',
propName,
);
}
}
}
}