Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary temporary in tests

Browse Source 
We previously didn't support ternaries whose value was unused, so we had an 
extraneous temporary and console.log call to ensure the value counted as used. 
We now special-case ternary/conditional expressions which are in an 
ExpressionStatement to not prune them, so the temporary and log are now 
unnecessary.
This commit is contained in:
Joe Savona
2023-04-27 10:43:43 -07:00
parent d2f33dd524
commit 1df89e992a
12 changed files with 18 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-ternary-destruction-with-mutation.expect.md
+2 -7
View File
@@ -5,10 +5,7 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond
? (({ x } = { x: {} }), ([x] = [[]]), x.push(props.foo))
: null;
console.log(_);
props.cond ? (({ x } = { x: {} }), ([x] = [[]]), x.push(props.foo)) : null;
mut(x);
return x;
}
@@ -26,9 +23,7 @@ function foo(props) {
if (c_0) {
x = [];
x.push(props.bar);
const _ = props.cond ? (([x] = [[]]), x.push(props.foo)) : null;
console.log(_);
props.cond ? (([x] = [[]]), x.push(props.foo)) : null;
mut(x);
$[0] = props;
$[1] = x;
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-ternary-destruction-with-mutation.js
+1 -4
View File
@@ -1,10 +1,7 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond
? (({ x } = { x: {} }), ([x] = [[]]), x.push(props.foo))
: null;
console.log(_);
props.cond ? (({ x } = { x: {} }), ([x] = [[]]), x.push(props.foo)) : null;
mut(x);
return x;
}
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-ternary-destruction.expect.md
+2 -7
View File
@@ -5,10 +5,7 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond
? (({ x } = { x: {} }), ([x] = [[]]), x.push(props.foo))
: null;
console.log(_);
props.cond ? (({ x } = { x: {} }), ([x] = [[]]), x.push(props.foo)) : null;
return x;
}
@@ -41,9 +38,7 @@ function foo(props) {
t0 = $[3];
x = $[4];
}
const _ = t0;
console.log(_);
t0;
return x;
}
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-ternary-destruction.js
+1 -4
View File
@@ -1,9 +1,6 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond
? (({ x } = { x: {} }), ([x] = [[]]), x.push(props.foo))
: null;
console.log(_);
props.cond ? (({ x } = { x: {} }), ([x] = [[]]), x.push(props.foo)) : null;
return x;
}
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-ternary-with-mutation.expect.md
+2 -4
View File
@@ -5,8 +5,7 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond ? ((x = {}), (x = []), x.push(props.foo)) : null;
console.log(_);
props.cond ? ((x = {}), (x = []), x.push(props.foo)) : null;
mut(x);
return x;
}
@@ -24,8 +23,7 @@ function foo(props) {
if (c_0) {
x = [];
x.push(props.bar);
const _ = props.cond ? ((x = []), x.push(props.foo)) : null;
console.log(_);
props.cond ? ((x = []), x.push(props.foo)) : null;
mut(x);
$[0] = props;
$[1] = x;
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-ternary-with-mutation.js
+1 -2
View File
@@ -1,8 +1,7 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond ? ((x = {}), (x = []), x.push(props.foo)) : null;
console.log(_);
props.cond ? ((x = {}), (x = []), x.push(props.foo)) : null;
mut(x);
return x;
}
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-ternary.expect.md
+2 -4
View File
@@ -5,8 +5,7 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond ? ((x = {}), (x = []), x.push(props.foo)) : null;
console.log(_);
props.cond ? ((x = {}), (x = []), x.push(props.foo)) : null;
return x;
}
@@ -39,8 +38,7 @@ function foo(props) {
t0 = $[3];
x = $[4];
}
const _ = t0;
console.log(_);
t0;
return x;
}
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-ternary.js
+1 -2
View File
@@ -1,7 +1,6 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond ? ((x = {}), (x = []), x.push(props.foo)) : null;
console.log(_);
props.cond ? ((x = {}), (x = []), x.push(props.foo)) : null;
return x;
}
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-unconditional-ternary-with-mutation.expect.md
+2 -6
View File
@@ -5,10 +5,9 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond
props.cond
? ((x = {}), (x = []), x.push(props.foo))
: ((x = []), (x = []), x.push(props.bar));
console.log(_);
mut(x);
return x;
}
@@ -26,10 +25,7 @@ function foo(props) {
if (c_0) {
x = [];
x.push(props.bar);
const _ = props.cond
? ((x = []), x.push(props.foo))
: ((x = []), x.push(props.bar));
console.log(_);
props.cond ? ((x = []), x.push(props.foo)) : ((x = []), x.push(props.bar));
mut(x);
$[0] = props;
$[1] = x;
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-unconditional-ternary-with-mutation.js
+1 -2
View File
@@ -1,10 +1,9 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond
props.cond
? ((x = {}), (x = []), x.push(props.foo))
: ((x = []), (x = []), x.push(props.bar));
console.log(_);
mut(x);
return x;
}
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-unconditional-ternary.expect.md
+2 -4
View File
@@ -5,10 +5,9 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond
props.cond
? ((x = {}), (x = []), x.push(props.foo))
: ((x = []), (x = []), x.push(props.bar));
console.log(_);
return x;
}
@@ -43,8 +42,7 @@ function foo(props) {
t0 = $[3];
x = $[4];
}
const _ = t0;
console.log(_);
t0;
return x;
}
compiler/forget/src/__tests__/fixtures/compiler/ssa-renaming-unconditional-ternary.js
+1 -2
View File
@@ -1,9 +1,8 @@
function foo(props) {
let x = [];
x.push(props.bar);
const _ = props.cond
props.cond
? ((x = {}), (x = []), x.push(props.foo))
: ((x = []), (x = []), x.push(props.bar));
console.log(_);
return x;
}