mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Remove check in renderDidSuspendDelayIfPossible (#25630)
I don't think we need this anymore. It was added originally because RootSuspended would take priority over RootSuspendedWithDelay. But we've since changed it: any "bad" fallback state is permitted to block a "good" fallback state. The other status flags that this check used to account for are RootDidNotComplete and RootFatalErrored: - RootFatalErrored is like an invariant violation, it means something went really wrong already and we can't recover from it - RootCompleted and RootDidNotComplete are only set at the very end of the work loop, there's no way for renderDidSuspendDelayIfPossible to sneak in after that (at least none that I can think of — it's only called from the render phase) So I think we can just delete this. It's entirely possible there's some scenario I haven't considered, though, which is why I'm submitting this change as its own PR. To preserve the ability to bisect to it later.
This commit is contained in:
committed by
Rick Hanlon
parent
9da7d30360
commit
1bbb353518
@@ -1926,13 +1926,7 @@ export function renderDidSuspend(): void {
|
||||
}
|
||||
|
||||
export function renderDidSuspendDelayIfPossible(): void {
|
||||
if (
|
||||
workInProgressRootExitStatus === RootInProgress ||
|
||||
workInProgressRootExitStatus === RootSuspended ||
|
||||
workInProgressRootExitStatus === RootErrored
|
||||
) {
|
||||
workInProgressRootExitStatus = RootSuspendedWithDelay;
|
||||
}
|
||||
workInProgressRootExitStatus = RootSuspendedWithDelay;
|
||||
|
||||
// Check if there are updates that we skipped tree that might have unblocked
|
||||
// this render.
|
||||
|
||||
@@ -1926,13 +1926,7 @@ export function renderDidSuspend(): void {
|
||||
}
|
||||
|
||||
export function renderDidSuspendDelayIfPossible(): void {
|
||||
if (
|
||||
workInProgressRootExitStatus === RootInProgress ||
|
||||
workInProgressRootExitStatus === RootSuspended ||
|
||||
workInProgressRootExitStatus === RootErrored
|
||||
) {
|
||||
workInProgressRootExitStatus = RootSuspendedWithDelay;
|
||||
}
|
||||
workInProgressRootExitStatus = RootSuspendedWithDelay;
|
||||
|
||||
// Check if there are updates that we skipped tree that might have unblocked
|
||||
// this render.
|
||||
|
||||
Reference in New Issue
Block a user