Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[be][cleanup] Split primitive tests to individual fixtures

Browse Source 
Followup to #1273 

No changes, just moving test functions to their own fixture files.
This commit is contained in:
mofeiZ
2023-03-06 18:25:53 -05:00
parent 8be45e7d4a
commit 0e1bba87ea
8 changed files with 174 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/__tests__/fixtures/hir/allocating-primitive-as-dep-nested-scope.expect.md
+79
View File
@@ -0,0 +1,79 @@
## Input
```javascript
// bar(props.b) is an allocating expression that produces a primitive, which means
// that Forget should memoize it.
// Correctness:
// - y depends on either bar(props.b) or bar(props.b) + 1
function AllocatingPrimitiveAsDepNested(props) {
let x = {};
mutate(x);
let y = foo(bar(props.b) + 1);
mutate(x, props.a);
return [x, y];
}
```
## Code
```javascript
// bar(props.b) is an allocating expression that produces a primitive, which means
// that Forget should memoize it.
// Correctness:
// - y depends on either bar(props.b) or bar(props.b) + 1
function AllocatingPrimitiveAsDepNested(props) {
const $ = React.unstable_useMemoCache(11);
const c_0 = $[0] !== props.b;
const c_1 = $[1] !== props.a;
let x;
let y;
if (c_0 || c_1) {
x = {};
mutate(x);
const c_4 = $[4] !== props.b;
let t0;
if (c_4) {
t0 = bar(props.b);
$[4] = props.b;
$[5] = t0;
} else {
t0 = $[5];
}
const t1 = t0 + 1;
const c_6 = $[6] !== t1;
let t2;
if (c_6) {
t2 = foo(t1);
$[6] = t1;
$[7] = t2;
} else {
t2 = $[7];
}
y = t2;
mutate(x, props.a);
$[0] = props.b;
$[1] = props.a;
$[2] = x;
$[3] = y;
} else {
x = $[2];
y = $[3];
}
const c_8 = $[8] !== x;
const c_9 = $[9] !== y;
let t3;
if (c_8 || c_9) {
t3 = [x, y];
$[8] = x;
$[9] = y;
$[10] = t3;
} else {
t3 = $[10];
}
return t3;
}
```
compiler/forget/src/__tests__/fixtures/hir/allocating-primitive-as-dep-nested-scope.js
+11
View File
@@ -0,0 +1,11 @@
// bar(props.b) is an allocating expression that produces a primitive, which means
// that Forget should memoize it.
// Correctness:
// - y depends on either bar(props.b) or bar(props.b) + 1
function AllocatingPrimitiveAsDepNested(props) {
let x = {};
mutate(x);
let y = foo(bar(props.b) + 1);
mutate(x, props.a);
return [x, y];
}
compiler/forget/src/__tests__/fixtures/hir/allocating-primitive-as-dep.expect.md
-60
View File
@@ -11,14 +11,6 @@ function AllocatingPrimitiveAsDep(props) {
return y;
}
function PrimitiveAsDepNested(props) {
let x = {};
mutate(x);
let y = foo(bar(props.b) + 1);
mutate(x, props.a);
return [x, y];
}
```
## Code
@@ -53,57 +45,5 @@ function AllocatingPrimitiveAsDep(props) {
return y;
}
function PrimitiveAsDepNested(props) {
const $ = React.unstable_useMemoCache(11);
const c_0 = $[0] !== props.b;
const c_1 = $[1] !== props.a;
let x;
let y;
if (c_0 || c_1) {
x = {};
mutate(x);
const c_4 = $[4] !== props.b;
let t0;
if (c_4) {
t0 = bar(props.b);
$[4] = props.b;
$[5] = t0;
} else {
t0 = $[5];
}
const t1 = t0 + 1;
const c_6 = $[6] !== t1;
let t2;
if (c_6) {
t2 = foo(t1);
$[6] = t1;
$[7] = t2;
} else {
t2 = $[7];
}
y = t2;
mutate(x, props.a);
$[0] = props.b;
$[1] = props.a;
$[2] = x;
$[3] = y;
} else {
x = $[2];
y = $[3];
}
const c_8 = $[8] !== x;
const c_9 = $[9] !== y;
let t3;
if (c_8 || c_9) {
t3 = [x, y];
$[8] = x;
$[9] = y;
$[10] = t3;
} else {
t3 = $[10];
}
return t3;
}
```
compiler/forget/src/__tests__/fixtures/hir/allocating-primitive-as-dep.js
-8
View File
@@ -6,11 +6,3 @@ function AllocatingPrimitiveAsDep(props) {
let y = foo(bar(props).b + 1);
return y;
}
function PrimitiveAsDepNested(props) {
let x = {};
mutate(x);
let y = foo(bar(props.b) + 1);
mutate(x, props.a);
return [x, y];
}
compiler/forget/src/__tests__/fixtures/hir/primitive-as-dep-nested-scope.expect.md
+72
View File
@@ -0,0 +1,72 @@
## Input
```javascript
// props.b + 1 is an non-allocating expression, which means Forget can
// emit it trivially and repeatedly (e.g. no need to memoize props.b + 1
// separately from props.b)
// Correctness:
// y depends on either props.b or props.b + 1
function PrimitiveAsDepNested(props) {
let x = {};
mutate(x);
let y = foo(props.b + 1);
mutate(x, props.a);
return [x, y];
}
```
## Code
```javascript
// props.b + 1 is an non-allocating expression, which means Forget can
// emit it trivially and repeatedly (e.g. no need to memoize props.b + 1
// separately from props.b)
// Correctness:
// y depends on either props.b or props.b + 1
function PrimitiveAsDepNested(props) {
const $ = React.unstable_useMemoCache(9);
const c_0 = $[0] !== props.b;
const c_1 = $[1] !== props.a;
let x;
let y;
if (c_0 || c_1) {
x = {};
mutate(x);
const t0 = props.b + 1;
const c_4 = $[4] !== t0;
let t1;
if (c_4) {
t1 = foo(t0);
$[4] = t0;
$[5] = t1;
} else {
t1 = $[5];
}
y = t1;
mutate(x, props.a);
$[0] = props.b;
$[1] = props.a;
$[2] = x;
$[3] = y;
} else {
x = $[2];
y = $[3];
}
const c_6 = $[6] !== x;
const c_7 = $[7] !== y;
let t2;
if (c_6 || c_7) {
t2 = [x, y];
$[6] = x;
$[7] = y;
$[8] = t2;
} else {
t2 = $[8];
}
return t2;
}
```
compiler/forget/src/__tests__/fixtures/hir/primitive-as-dep-nested-scope.js
+12
View File
@@ -0,0 +1,12 @@
// props.b + 1 is an non-allocating expression, which means Forget can
// emit it trivially and repeatedly (e.g. no need to memoize props.b + 1
// separately from props.b)
// Correctness:
// y depends on either props.b or props.b + 1
function PrimitiveAsDepNested(props) {
let x = {};
mutate(x);
let y = foo(props.b + 1);
mutate(x, props.a);
return [x, y];
}
compiler/forget/src/__tests__/fixtures/hir/primitive-as-dep.expect.md
-51
View File
@@ -12,14 +12,6 @@ function PrimitiveAsDep(props) {
return y;
}
function PrimitiveAsDepNested(props) {
let x = {};
mutate(x);
let y = foo(props.b + 1);
mutate(x, props.a);
return [x, y];
}
```
## Code
@@ -46,48 +38,5 @@ function PrimitiveAsDep(props) {
return y;
}
function PrimitiveAsDepNested(props) {
const $ = React.unstable_useMemoCache(9);
const c_0 = $[0] !== props.b;
const c_1 = $[1] !== props.a;
let x;
let y;
if (c_0 || c_1) {
x = {};
mutate(x);
const t0 = props.b + 1;
const c_4 = $[4] !== t0;
let t1;
if (c_4) {
t1 = foo(t0);
$[4] = t0;
$[5] = t1;
} else {
t1 = $[5];
}
y = t1;
mutate(x, props.a);
$[0] = props.b;
$[1] = props.a;
$[2] = x;
$[3] = y;
} else {
x = $[2];
y = $[3];
}
const c_6 = $[6] !== x;
const c_7 = $[7] !== y;
let t2;
if (c_6 || c_7) {
t2 = [x, y];
$[6] = x;
$[7] = y;
$[8] = t2;
} else {
t2 = $[8];
}
return t2;
}
```
compiler/forget/src/__tests__/fixtures/hir/primitive-as-dep.js
-8
View File
@@ -7,11 +7,3 @@ function PrimitiveAsDep(props) {
let y = foo(props.b + 1);
return y;
}
function PrimitiveAsDepNested(props) {
let x = {};
mutate(x);
let y = foo(props.b + 1);
mutate(x, props.a);
return [x, y];
}