Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[hir] Simplify depRoot map

Browse Source 
Use Identifier as a key, which lets us simplify lookup to no longer require an 
index access.
This commit is contained in:
Sathya Gunasekaran
2023-03-01 16:48:54 +00:00
parent 7a6a0e5f72
commit 08c1eda7ff
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/ReactiveScopes/PropagateScopeDependencies.ts
+5 -5
View File
@@ -272,10 +272,10 @@ function deriveMinimalDependenciesInSubtree(
function deriveMinimalDependencies(
initialDeps: Set<ReactiveScopeDependencyInfo>
): Set<ReactiveScopeDependency> {
const depRoots = new Map<IdentifierId, [Identifier, DependencyNode]>();
const depRoots = new Map<Identifier, DependencyNode>();
for (const dep of initialDeps) {
let root = depRoots.get(dep.identifier.id)?.[1];
let root = depRoots.get(dep.identifier);
const path = dep.path ?? [];
if (root == null) {
// roots can always be accessed unconditionally in JS
@@ -283,7 +283,7 @@ function deriveMinimalDependencies(
properties: new Map(),
accessType: PropertyAccessType.UnconditionalAccess,
};
depRoots.set(dep.identifier.id, [dep.identifier, root]);
depRoots.set(dep.identifier, root);
}
let currNode: DependencyNode = root;
@@ -314,7 +314,7 @@ function deriveMinimalDependencies(
}
const results = new Set<ReactiveScopeDependency>();
for (const [_, [rootId, rootNode]] of depRoots) {
for (const [root, rootNode] of depRoots.entries()) {
const deps = deriveMinimalDependenciesInSubtree(rootNode);
invariant(
deps.every(
@@ -325,7 +325,7 @@ function deriveMinimalDependencies(
for (const dep of deps) {
results.add({
identifier: rootId,
identifier: root,
path: dep.relativePath,
});
}