Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[hir] Refactor FunctionExpression lowering into separate function

Browse Source 
This will allow us to reuse all the lowering for FunctionDeclaration.
This commit is contained in:
Sathya Gunasekaran
2023-03-30 15:48:53 +01:00
parent c2154b2785
commit 05f48e2aac
1 changed files with 49 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/HIR/BuildHIR.ts
+49 -40
View File
@@ -1446,46 +1446,7 @@ function lowerExpression(
const expr = exprPath as NodePath<
t.FunctionExpression | t.ArrowFunctionExpression
>;
let name: string | null = null;
if (expr.isFunctionExpression()) {
name = expr.get("id")?.node?.name ?? null;
}
const componentScope: Scope = expr.scope.parent.getFunctionParent()!;
const captured = gatherCapturedDeps(builder, expr, componentScope);
// TODO(gsn): In the future, we could only pass in the context identifiers
// that are actually used by this function and it's nested functions, rather
// than all context identifiers.
//
// This isn't a problem in practice because use Babel's scope analysis to
// identify the correct references.
const lowering = lower(
expr,
builder.environment.options,
[...builder.context, ...captured.identifiers],
builder.parentFunction,
builder.environment
);
let loweredFunc: HIRFunction;
if (lowering.isErr()) {
lowering
.unwrapErr()
.details.forEach((detail) => builder.errors.pushErrorDetail(detail));
return {
kind: "UnsupportedNode",
node: exprNode,
loc: exprLoc,
};
}
loweredFunc = lowering.unwrap();
return {
kind: "FunctionExpression",
name,
loweredFunc,
dependencies: captured.refs,
expr: expr.node,
loc: exprLoc,
};
return lowerFunctionExpression(builder, expr);
}
case "TaggedTemplateExpression": {
const expr = exprPath as NodePath<t.TaggedTemplateExpression>;
@@ -1996,6 +1957,54 @@ function lowerJsxElement(
}
}
function lowerFunctionExpression(
builder: HIRBuilder,
expr: NodePath<t.FunctionExpression | t.ArrowFunctionExpression>
): InstructionValue {
const exprNode = expr.node;
const exprLoc = exprNode.loc ?? GeneratedSource;
let name: string | null = null;
if (expr.isFunctionExpression()) {
name = expr.get("id")?.node?.name ?? null;
}
const componentScope: Scope = expr.scope.parent.getFunctionParent()!;
const captured = gatherCapturedDeps(builder, expr, componentScope);
// TODO(gsn): In the future, we could only pass in the context identifiers
// that are actually used by this function and it's nested functions, rather
// than all context identifiers.
//
// This isn't a problem in practice because use Babel's scope analysis to
// identify the correct references.
const lowering = lower(
expr,
builder.environment.options,
[...builder.context, ...captured.identifiers],
builder.parentFunction,
builder.environment
);
let loweredFunc: HIRFunction;
if (lowering.isErr()) {
lowering
.unwrapErr()
.details.forEach((detail) => builder.errors.pushErrorDetail(detail));
return {
kind: "UnsupportedNode",
node: exprNode,
loc: exprLoc,
};
}
loweredFunc = lowering.unwrap();
return {
kind: "FunctionExpression",
name,
loweredFunc,
dependencies: captured.refs,
expr: expr.node,
loc: exprLoc,
};
}
function lowerExpressionToTemporary(
builder: HIRBuilder,
exprPath: NodePath<t.Expression>