Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Flare] Ensure getAbsoluteBoundingClientRect aligns with offsetParent (#15720)

Browse Source
This commit is contained in:
Dominic Gannaway
2019-05-23 13:51:14 +01:00
committed by GitHub
parent 61f62246c8
commit 025b07b610
2 changed files with 23 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-events/src/Press.js
Vendored
+22 -12
View File
@@ -426,6 +426,18 @@ function calculateDelayMS(delay: ?number, min = 0, fallback = 0) {
return Math.max(min, maybeNumber != null ? maybeNumber : fallback);
}
function isNodeFixedPositioned(node: Node | null | void): boolean {
return (
node != null &&
(node: any).offsetParent === null &&
!isNodeDocumentNode(node.parentNode)
);
}
function isNodeDocumentNode(node: Node | null | void): boolean {
return node != null && node.nodeType === Node.DOCUMENT_NODE;
}
function getAbsoluteBoundingClientRect(
target: Element,
): {left: number, right: number, bottom: number, top: number} {
@@ -440,25 +452,23 @@ function getAbsoluteBoundingClientRect(
const parent = node.parentNode;
const scrollTop = (node: any).scrollTop;
const scrollLeft = (node: any).scrollLeft;
const isParentDocumentNode =
parent != null && parent.nodeType === Node.DOCUMENT_NODE;
// Check if the current node is fixed position, by using
// offsetParent node for a fast-path. Then we need to
// check if it's a scrollable container by checking if
// either scrollLeft or scrollTop are not 0. If it is
// a scrollable container and the parent node is not
// the document, then we can stop traversing the tree.
// We first need to check if it's a scrollable container by
// checking if either scrollLeft or scrollTop are not 0.
// Then we check if either the current node or its parent
// are fixed position, using offsetParent node for a fast-path.
// We need to check both as offsetParent accounts for both
// itself and the parent; so we need to align with that API.
// If these all pass, we can stop traversing the tree.
if (
!isParentDocumentNode &&
(node: any).offsetParent === null &&
(scrollLeft !== 0 || scrollTop !== 0)
(scrollLeft !== 0 || scrollTop !== 0) &&
(isNodeFixedPositioned(parent) || isNodeFixedPositioned(node))
) {
break;
}
offsetX += scrollLeft;
offsetY += scrollTop;
if (isParentDocumentNode) {
if (isNodeDocumentNode(parent)) {
break;
}
node = parent;
packages/react-events/src/__tests__/Press-test.internal.js
+1
View File
@@ -1167,6 +1167,7 @@ describe('Event responder: Press', () => {
// The fixed container is not scrolled
fixedDiv.scrollTop = 0;
fixedDiv.scrollLeft = 0;
ref.current.getBoundingClientRect = getBoundingClientRectMock;
// Emulate the <html> element being offset with scroll
document.firstElementChild.scrollTop = 1000;