mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Rick Hanlon
504fc0c7d0
Summary:
This diff updated the codegen flow types syntax replacing:
```
type Options = {
isDeprecatedPaperComponentNameRCT: true,
};
type ActivityIndicatorNativeType = CodegenNativeComponent<
'ActivityIndicatorView',
NativeProps,
Options,
>;
module.exports = ((requireNativeComponent(
'RCTActivityIndicatorView',
): any): ActivityIndicatorNativeType);
```
with:
```
export default codegenNativeComponent<NativeProps>('ActivityIndicatorView', {
isDeprecatedPaperComponentNameRCT: true,
});
```
This is from Tim's comment in the [View Config Codegen Quip](https://fb.quip.com/jR2aASHad4Se):
> What it CodegenNativeComponent were instead `NativeComponent.fromFlow<T>('…')` that returned `'...'`?
>And the Babel plugin swapped it for NativeComponent.fromSchema('...', {…}) which would both register and return '...'?
I went with `codegenNativeComponent` because it has nice parity with `requireNativeComponent`
I also didn't update the babel output here (we can update that whenever) because I think `registerGeneratedViewConfig` is more clear for what it's doing
Reviewed By: cpojer
Differential Revision: D15602077
fbshipit-source-id: 2d24dc32136ba6d31724f8c929b51417ba625a58
42 lines
1.3 KiB
JavaScript
42 lines
1.3 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @flow
|
|
*/
|
|
// TODO: move this file to shims/ReactNative (requires React update and sync)
|
|
|
|
'use strict';
|
|
|
|
import type {NativeComponent} from '../../Libraries/Renderer/shims/ReactNative';
|
|
import requireNativeComponent from '../../Libraries/ReactNative/requireNativeComponent';
|
|
|
|
// TODO: import from CodegenSchema once workspaces are enabled
|
|
type Options = $ReadOnly<{|
|
|
interfaceOnly?: boolean,
|
|
isDeprecatedPaperComponentNameRCT?: boolean,
|
|
|}>;
|
|
|
|
function codegenNativeComponent<Props>(
|
|
componentName: string,
|
|
options?: Options,
|
|
): Class<NativeComponent<Props>> {
|
|
let componentNameInUse = componentName;
|
|
if (options && options.isDeprecatedPaperComponentNameRCT === true) {
|
|
componentNameInUse = `RCT${componentName}`;
|
|
}
|
|
|
|
// If this function is run at runtime then that means the view configs were not
|
|
// generated with the view config babel plugin, so we need to require the native component.
|
|
//
|
|
// This will be useful during migration, but eventually this will error.
|
|
return ((requireNativeComponent(componentNameInUse): any): Class<
|
|
NativeComponent<Props>,
|
|
>);
|
|
}
|
|
|
|
export default codegenNativeComponent;
|