mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Andrew CoatesandFacebook GitHub Bot
4d87d8c6b2
Summary: react-native-windows runs with a more strict set of warnings as errors. This fixes a bunch of warnings being hit while compiling core react-native code as part of react-native-windows. In particular warnings about mismatched signed/unsigned comparisons, lossy conversions, and variable names that conflict with names in outer scopes (yoga has a global for `leading` and `trailing` that conflicts with some local variable names) ## Changelog [Internal] [Fixed] - Fix various C++ warnings Pull Request resolved: https://github.com/facebook/react-native/pull/31399 Test Plan: I've run these changes in react-native-windows. -- Shouldn't have any functionality difference. Reviewed By: sammy-SC Differential Revision: D28290188 Pulled By: rozele fbshipit-source-id: 2f7cf87f58d73a3f43510ac888dbcb9ab177d134
64 lines
2.0 KiB
C++
64 lines
2.0 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "LeakChecker.h"
|
|
|
|
#include <glog/logging.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
LeakChecker::LeakChecker(
|
|
RuntimeExecutor const &runtimeExecutor,
|
|
GarbageCollectionTrigger const &garbageCollectionTrigger)
|
|
: runtimeExecutor_(runtimeExecutor),
|
|
garbageCollectionTrigger_(garbageCollectionTrigger) {}
|
|
|
|
void LeakChecker::uiManagerDidCreateShadowNodeFamily(
|
|
ShadowNodeFamily::Shared const &shadowNodeFamily) const {
|
|
registry_.add(shadowNodeFamily);
|
|
}
|
|
|
|
void LeakChecker::stopSurface(SurfaceId surfaceId) {
|
|
garbageCollectionTrigger_();
|
|
|
|
if (previouslyStoppedSurface_ > 0) {
|
|
// Dispatch the check onto JavaScript thread to make sure all other
|
|
// cleanup code has had chance to run.
|
|
runtimeExecutor_([previouslySoppedSurface = previouslyStoppedSurface_,
|
|
this](jsi::Runtime &) {
|
|
// For now check the previous surface because React uses double
|
|
// buffering which keeps the surface that was just stopped in
|
|
// memory. This is a documented problem in the last point of
|
|
// https://github.com/facebook/react/issues/16087
|
|
checkSurfaceForLeaks(previouslySoppedSurface);
|
|
});
|
|
}
|
|
|
|
previouslyStoppedSurface_ = surfaceId;
|
|
}
|
|
|
|
void LeakChecker::checkSurfaceForLeaks(SurfaceId surfaceId) const {
|
|
auto weakFamilies = registry_.weakFamiliesForSurfaceId(surfaceId);
|
|
unsigned int numberOfLeaks = 0;
|
|
for (auto const &weakFamily : weakFamilies) {
|
|
auto strong = weakFamily.lock();
|
|
if (strong) {
|
|
++numberOfLeaks;
|
|
}
|
|
}
|
|
if (numberOfLeaks > 0) {
|
|
LOG(ERROR) << "[LeakChecker] Surface with id: " << surfaceId
|
|
<< " has leaked " << numberOfLeaks << " components out of "
|
|
<< weakFamilies.size();
|
|
}
|
|
registry_.removeFamiliesWithSurfaceId(surfaceId);
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|