mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

T

JorenVos e25a9b4c5d Fix support for --sourcemap-output path containing spaces in Xcode projects (#40937 )

Summary:
This PR contains the changes from https://github.com/facebook/react-native/pull/30981 that got closed due to inactivity.

Many thanks to nickdowell for this bug report & fix. We encountered this error in our project when we had an Xcode scheme that contains a space (like `AppName alpha`).

This change fixes the generation of source maps for Xcode projects where the output path contains spaces.

The `EXTRA_ARGS` environment variable, being a plain string, would be split into arguments by whitespace - so a path containing spaces was being treated as several arguments rather than one.

This change uses an array to contain the arguments instead, allowing the proper handling of arguments that may contain spaces.

bypass-github-export-checks

## Changelog:

[iOS] [Fixed] - Fix support for --sourcemap-output path containing spaces

Pull Request resolved: https://github.com/facebook/react-native/pull/40937

Test Plan:
Tested using a sample project with the following "Bundle React Native code and images" Xcode build phase

```
export SOURCEMAP_FILE="$CONFIGURATION_BUILD_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH/main.jsbundle.map"
set -e
export NODE_BINARY=node
../node_modules/react-native/scripts/react-native-xcode.sh
```

and a `CONFIGURATION_BUILD_DIR` that contains spaces - `~/Library/Xcode/Derived Data`. **You can also try an XCode-scheme that contains a space.**

### Before

```
+ EXTRA_ARGS=
+ case "$PLATFORM_NAME" in
+ BUNDLE_PLATFORM=ios
+ EMIT_SOURCEMAP=
+ [[ ! -z /Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/RN064.app/main.jsbundle.map ]]
+ EMIT_SOURCEMAP=true
+ PACKAGER_SOURCEMAP_FILE=
+ [[ true == true ]]
+ [[ '' == true ]]
+ PACKAGER_SOURCEMAP_FILE='/Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/RN064.app/main.jsbundle.map'
+ EXTRA_ARGS=' --sourcemap-output /Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/RN064.app/main.jsbundle.map'
+ node /Users/nick/Desktop/RN064/node_modules/react-native/cli.js bundle --entry-file index.js --platform ios --dev false --reset-cache --bundle-output '/Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/main.jsbundle' --assets-dest '/Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/RN064.app' --sourcemap-output /Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/RN064.app/main.jsbundle.map
                    Welcome to Metro!
              Fast - Scalable - Integrated

info Writing bundle output to:, /Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/main.jsbundle
info Writing sourcemap output to:, /Users/nick/Library/Developer/Xcode/Derived
```
Note the incorrect sourcemap output path.

### After

```
+ EXTRA_ARGS=()
+ case "$PLATFORM_NAME" in
+ BUNDLE_PLATFORM=ios
+ EMIT_SOURCEMAP=
+ [[ ! -z /Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/RN064.app/main.jsbundle.map ]]
+ EMIT_SOURCEMAP=true
+ PACKAGER_SOURCEMAP_FILE=
+ [[ true == true ]]
+ [[ '' == true ]]
+ PACKAGER_SOURCEMAP_FILE='/Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/RN064.app/main.jsbundle.map'
+ EXTRA_ARGS+=("--sourcemap-output")
+ EXTRA_ARGS+=("$PACKAGER_SOURCEMAP_FILE")
+ node /Users/nick/Desktop/RN064/node_modules/react-native/cli.js bundle --entry-file index.js --platform ios --dev false --reset-cache --bundle-output '/Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/main.jsbundle' --assets-dest '/Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/RN064.app' --sourcemap-output '/Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/RN064.app/main.jsbundle.map'
                    Welcome to Metro!
              Fast - Scalable - Integrated

info Writing bundle output to:, /Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/main.jsbundle
info Writing sourcemap output to:, /Users/nick/Library/Developer/Xcode/Derived Data/RN064-cpnwckdferodycbevupbrkjydate/Build/Products/Release-iphonesimulator/RN064.app/main.jsbundle.map
```
sourcemap output path fixed 🎉

Reviewed By: arushikesarwani94

Differential Revision: D52431057

Pulled By: cipolleschi

fbshipit-source-id: 528217c84fe3f467a30baa15cfa4dcb2ed713165

2023-12-28 00:58:17 -08:00

.bundle

Introduce Gemfile, ruby-version (#32303 )

2021-10-01 21:22:26 -07:00

.circleci

RN: Remove Deprecated Prop Types (#42019 )

2023-12-20 16:31:37 -08:00

.github

Adds "Needs: Author Feedback" if "Needs: Repro" is applied

2023-12-07 02:56:49 -08:00

flow-typed/npm

Replace $Call in babel-traverse libdef with conditional type (#41736 )

2023-11-30 19:40:12 -08:00

gradle

Gradle to 8.5 (#41748 )

2023-12-01 08:41:02 -08:00

jest

Enable lint/sort-imports everywhere (#41334 )

2023-11-06 12:59:38 -08:00

packages

Fix support for --sourcemap-output path containing spaces in Xcode projects (#40937 )

2023-12-28 00:58:17 -08:00

scripts

Move legacy tests from OSS to fbandroid/java/com/facebook/fbreact (#41802 )

2023-12-27 17:34:29 -08:00

tools

Update sort-imports lint rule to latest (#41841 )

2023-12-08 11:07:55 -08:00

.babelrc

Move react-native-babel-transformer and react-native-babel-preset from Metro to React Native repo (#38228 )

2023-07-27 11:48:16 -07:00

.buckconfig

Remove dangling reference to preload.bzl file (#41634 )

2023-11-24 03:52:26 -08:00

.buckjavaargs

limiting BUCK's memory for CI

2016-02-01 10:49:33 -08:00

.clang-format

PointerAlignment: Left

2023-09-04 10:55:18 -07:00

.editorconfig

Revert removal of CRLF from Windows bat files (#31398 )

2021-09-09 22:44:32 -07:00

.eslintignore

fix: add build generated files to *ignore config (#41826 )

2023-12-08 10:17:31 -08:00

.eslintrc.js

Enable lint/sort-imports everywhere (#41333 )

2023-11-06 12:59:38 -08:00

.flowconfig

Deploy 0.225.1 to xplat (#42027 )

2023-12-20 19:54:48 -08:00

.gitignore

Move legacy tests from OSS to fbandroid/java/com/facebook/fbreact (#41802 )

2023-12-27 17:34:29 -08:00

.prettierignore

fix: add build generated files to *ignore config (#41826 )

2023-12-08 10:17:31 -08:00

.prettierrc

Also parse js.flow files with hermes-parser (#39048 )

2023-08-16 11:27:13 -07:00

build.gradle.kts

Rename prefix of binaryCompatibilityValidator properties (#42041 )

2023-12-21 15:49:29 -08:00

CHANGELOG-pre-060.md

split the changelog into decades (#38017 )

2023-06-22 04:19:40 -07:00

CHANGELOG-pre-070.md

Remove duplicate changelog entry (#38177 )

2023-07-05 09:32:10 -07:00

CHANGELOG.md

Update CHANGELOG.md (#42011 )

2023-12-20 07:42:05 -08:00

CODE_OF_CONDUCT.md

docs: add new version convenant contribuitor guide link (#32107 )

2021-08-30 10:18:11 -07:00

CONTRIBUTING.md

Update CONTRIBUTING.md, replace wiki links (#34035 )

2022-06-21 19:30:23 -07:00

ECOSYSTEM.md

Add @getsentry to React Native incubating partners list (#38091 )

2023-06-27 10:48:43 -07:00

Gemfile

Bump minimum version of activesupport for CVE-2023-38037 (#42023 )

2023-12-21 10:08:28 -08:00

Gemfile.lock

Bump minimum version of activesupport for CVE-2023-38037 (#42023 )

2023-12-21 10:08:28 -08:00

gradle.properties

Bump AGP to 8.1.1 (#39392 )

2023-09-12 09:21:08 -07:00

gradlew

Bump Gradle to 8.4 (#39960 )

2023-10-06 11:38:59 -07:00

gradlew.bat

Bump Gradle to 8.x (#36269 )

2023-02-27 13:47:09 -08:00

jest.config.js

fix(jest): added sdks dir to testPathIgnorePatterns to prevent hermes specific tests to run (#40734 )

2023-10-09 15:30:00 -07:00

LICENSE

Re-add the top level LICENSE file (#37916 )

2023-06-15 13:14:17 -07:00

LICENSE-docs

More licenses

2015-03-24 19:59:10 -07:00

package.json

Deploy 0.225.1 to xplat (#42027 )

2023-12-20 19:54:48 -08:00

README.md

docs: bump minSdk to 23 (#42034 )

2023-12-21 22:29:00 -08:00

runXcodeTests.sh

Use realpath instead of readlink

2022-02-22 02:23:02 -08:00

settings.gradle.kts

Remove ReactNative/Flipper Integration (#40935 )

2023-10-16 05:32:55 -07:00

yarn.lock

Deploy 0.225.1 to xplat (#42027 )

2023-12-20 19:54:48 -08:00

README.md

React Native

Learn once, write anywhere:
Build mobile apps with React.

Getting Started · Learn the Basics · Showcase · Contribute · Community · Support

React Native brings React's declarative UI framework to iOS and Android. With React Native, you use native UI controls and have full access to the native platform.

Declarative. React makes it painless to create interactive UIs. Declarative views make your code more predictable and easier to debug.
Component-Based. Build encapsulated components that manage their state, then compose them to make complex UIs.
Developer Velocity. See local changes in seconds. Changes to JavaScript code can be live reloaded without rebuilding the native app.
Portability. Reuse code across iOS, Android, and other platforms.

React Native is developed and supported by many companies and individual core contributors. Find out more in our ecosystem overview.

Requirements
Building your first React Native app
Documentation
Upgrading
How to Contribute
Code of Conduct
License

📋 Requirements

React Native apps may target iOS 13.4 and Android 6.0 (API 23) or newer. You may use Windows, macOS, or Linux as your development operating system, though building and running iOS apps is limited to macOS. Tools like Expo can be used to work around this.

🎉 Building your first React Native app

Follow the Getting Started guide. The recommended way to install React Native depends on your project. Here you can find short guides for the most common scenarios:

📖 Documentation

The full documentation for React Native can be found on our website.

The React Native documentation discusses components, APIs, and topics that are specific to React Native. For further documentation on the React API that is shared between React Native and React DOM, refer to the React documentation.

The source for the React Native documentation and website is hosted on a separate repo, @facebook/react-native-website.

🚀 Upgrading

Upgrading to new versions of React Native may give you access to more APIs, views, developer tools, and other goodies. See the Upgrading Guide for instructions.

React Native releases are discussed in this discussion repo.

👏 How to Contribute

The main purpose of this repository is to continue evolving React Native core. We want to make contributing to this project as easy and transparent as possible, and we are grateful to the community for contributing bug fixes and improvements. Read below to learn how you can take part in improving React Native.

Good First Issues

We have a list of good first issues that contain bugs which have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.

Discussions

Larger discussions and proposals are discussed in @react-native-community/discussions-and-proposals.

📄 License

React Native is MIT licensed, as found in the LICENSE file.

React Native documentation is Creative Commons licensed, as found in the LICENSE-docs file.

README.md

React Native

Getting Started · Learn the Basics · Showcase · Contribute · Community · Support

Contents

📋 Requirements

🎉 Building your first React Native app

📖 Documentation

🚀 Upgrading

👏 How to Contribute

Code of Conduct

Contributing Guide

Open Source Roadmap

Good First Issues

Discussions

📄 License