mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Gabriel RoganandFacebook GitHub Bot
9e169da3ae
Summary: The `sed` workaround here in `__apply_Xcode_12_5_M1_post_install_workaround`: https://github.com/facebook/react-native/blob/main/scripts/react_native_pods.rb#L293-L298 does not work when the react native project has a parent folder with a space in the the name, for example: `/Users/myuser/Some Folder/my-project/ios/Pods/RCT-Folly/folly/portability/Time.h` This is because the `sed` command thinks that the part after the space is a separate argument. This bug caused one of our engineers to not be able to run our React Native project through no fault of his own, so I would like to propose this change to help other engineers avoid this in the future. ## Changelog Add single quotes around the file parameter in the `sed` command [iOS] [Fixed] - Fixed Time.h:52:17: error when a folder in the file path has a space Pull Request resolved: https://github.com/facebook/react-native/pull/34510 Test Plan: Checkout the main branch. Create a React Native project in a folder that has a space in the name. When you run `pod install`, you should notice a `sed` error indicating that the text replacement failed. Run the build to reproduce the `Time.h:52:17: error`. Checkout this branch. Run `pod install` and notice the `sed` error is gone. Run the build, the error should be gone. Reviewed By: sammy-SC Differential Revision: D39082262 Pulled By: cipolleschi fbshipit-source-id: 211099234edc6c9ee959bb61a760a6ca04a7a301