Mateo Hrastnik
d816ba0a70
Summary: I've implemented a feature that automatically bundles the Metro Bundler's IP address into Android builds. This change aligns the Android development experience with iOS, allowing the app to maintain a connection to the Metro Bundler even when disconnected from USB. Currently, in iOS builds, the IP address of the computer running the Metro Bundler is automatically bundled into the app, ensuring seamless connectivity even when the device is disconnected from USB. In contrast, Android developers must manually input the IP address if the USB connection is lost, which can be tedious and error-prone. More info in discussion thread: https://github.com/react-native-community/discussions-and-proposals/issues/870 I anticipate that a change where making IP the default method of connection will result in a lot of people running into issues where they can't connect to Metro server (for example, if they're on a different network, or they disable wifi). So I also changed the default error message you get in case the app can't connect to the bundler and updated the "Change Bundle Location" dev menu. The previous error message ``` Unable to load script. Make sure you're either running Metro (run 'npx react-native start') or that your bundle 'RNTesterApp.android.bundle' is packaged correctly for release. ``` was changed to: ``` Unable to load script. Make sure you're running Metro (npx react-native start) or that your bundle 'RNTesterApp.android.bundle' is packaged correctly for release. The device must be on the same WiFi as your laptop to connect to Metro. To use USB instead, shake the device to open the dev menu and set the bundler location to 'localhost: 8081' and run: adb reverse tcp:8081 tcp:8081 ```  And the new dev menu UI looks like this:  The two buttons with "10.0.2.2:8081" and "localhost:8081" are suggestions which when tapped fill the input with the text from the button. The first button suggests the IP of the development machine, and the second one is hardcoded to localhost:8081. ## Changelog: [ANDROID] [CHANGED] - Automatically use Metro bundler IP address when installing apps on Android Pull Request resolved: https://github.com/facebook/react-native/pull/49166 Test Plan: I've tested the implementation on a physical device and on emulator and it's working solid. However, I would invite further testing in order to catch possible edge cases. I've recorded common scenarios Scenario 1: Device doesn't have the app installed. We connect the device via USB, install the app and open it. Device is on the same network as the dev machine. Bundler location is by default set to the IP of the dev machine. When starting app, the app is able to connect to the dev machine and download the bundle. Scenario 2: Device doesn't have the app installed. Wi-Fi is turned off on the device but device is connected via USB We install the app and open it. Bundler location is by default set to the IP of the dev machine. When starting app, the app is not able to connect to the dev machine and shows the error message. After opening the dev menu we see that the IP is set to the IP of the dev machine. We click the "localhost" option in the dev menu and click apply After that the app is able to connect to the dev machine and download the bundle (via USB) since the traffic is forwarded using adb reverse. Notes: When we set an IP in the dev menu, the app will persist it. If we connect the device via USB and reinstall the app the persisted data stays the same, so the previously set IP will be used. However, the IP of the dev machine will be displayed as an option in the dev menu. https://github.com/user-attachments/assets/cc2da5d4-de07-4980-a61c-68ca53db74c7 https://github.com/user-attachments/assets/407b8871-8b83-4a6b-a833-f87ddc0afc82 Reviewed By: huntie Differential Revision: D69664231 Pulled By: cortinico fbshipit-source-id: 5a339be50a17a59202416b99e72f4397d8ff4805
React Native
Learn once, write anywhere:
Build mobile apps with React.
Getting Started · Learn the Basics · Showcase · Contribute · Community · Support
React Native brings React's declarative UI framework to iOS and Android. With React Native, you use native UI controls and have full access to the native platform.
- Declarative. React makes it painless to create interactive UIs. Declarative views make your code more predictable and easier to debug.
- Component-Based. Build encapsulated components that manage their state, then compose them to make complex UIs.
- Developer Velocity. See local changes in seconds. Changes to JavaScript code can be live reloaded without rebuilding the native app.
- Portability. Reuse code across iOS, Android, and other platforms.
React Native is developed and supported by many companies and individual core contributors. Find out more in our ecosystem overview.
Contents
- Requirements
- Building your first React Native app
- Documentation
- Upgrading
- How to Contribute
- Code of Conduct
- License
📋 Requirements
React Native apps may target iOS 15.1 and Android 7.0 (API 24) or newer. You may use Windows, macOS, or Linux as your development operating system, though building and running iOS apps is limited to macOS. Tools like Expo can be used to work around this.
🎉 Building your first React Native app
Follow the Getting Started guide. The recommended way to install React Native depends on your project. Here you can find short guides for the most common scenarios:
📖 Documentation
The full documentation for React Native can be found on our website.
The React Native documentation discusses components, APIs, and topics that are specific to React Native. For further documentation on the React API that is shared between React Native and React DOM, refer to the React documentation.
The source for the React Native documentation and website is hosted on a separate repository, @facebook/react-native-website.
🚀 Upgrading
Upgrading to new versions of React Native may give you access to more APIs, views, developer tools, and other goodies. See the Upgrading Guide for instructions.
React Native releases are discussed in this discussion repo.
👏 How to Contribute
The main purpose of this repository is to continue evolving React Native core. We want to make contributing to this project as easy and transparent as possible, and we are grateful to the community for contributing bug fixes and improvements. Read below to learn how you can take part in improving React Native.
Code of Conduct
Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please read the full text so that you can understand what actions will and will not be tolerated.
Contributing Guide
Read our Contributing Guide to learn about our development process, how to propose bugfixes and improvements, and how to build and test your changes to React Native.
Open Source Roadmap
You can learn more about our vision for React Native in the Roadmap.
Good First Issues
We have a list of good first issues that contain bugs which have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.
Discussions
Larger discussions and proposals are discussed in @react-native-community/discussions-and-proposals.
📄 License
React Native is MIT licensed, as found in the LICENSE file.
React Native documentation is Creative Commons licensed, as found in the LICENSE-docs file.