mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ruslan Shestopalyuk
14ab76ac30
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36312 ## Changelog: [Internal] - `clearMarks` and `clearMeasures` methods are incidental to the `NativePerformance` TurboModule functionality, as in reality this responsibility belongs more on the `NativePerformanceObserver` and `PerformanceEntryReporter` side. This is something that [the standard indirectly suggests](https://www.w3.org/TR/user-timing/#clearmarks-method) as well (referencing [performance entry buffer](https://www.w3.org/TR/performance-timeline/#dfn-performance-entry-buffer)). The new implementation should be also a little bit more efficient, as it avoids calling the predicate for each entry. Finally (and frankly, the main reason for this change, from my perspective), it will simplify mocking/testing the JS part of the PerfAPI code. Reviewed By: rubennorte Differential Revision: D43621174 fbshipit-source-id: c4217a0da1d8ecbce797240627f7b4f057d85b97