mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
nossbiggandFacebook Github Bot
168a67e4b2
Summary: This pull request enhances the Keyboard API event emitter for Android upon `keyboardDidHide` by returning a `KeyboardEvent` with a meaningful `endCoordinates` property (instead of emitting a null as of current implementation). This change standardizes the `keyboardDidHide` keyboard event emission across both iOS and Android, which makes it easier for developers to use the API. In particular, the semantics of `endCoordinates` emitted during the `keyboardDidHide` event on Android will match nicely with semantics of the same event emitted on iOS: - `screenY` will be height of the screen, as that the keyboard has collapsed to the bottom of the screen - `screenX` will be 0, as the keyboard will always be flush to the sides of the screen - `height` will be 0, as the keyboard has fully collapsed - `width` will be the width of the screen, as the keyboard will always extend to the width of the screen Also, the flowtypes for `KeyboardEvent` have been further improved and are more explicit to better highlight the different object shapes (see `IOSKeyboardEvent` and `AndroidKeyboardEvent`) depending on the platform. ## Changelog [Android] [Added] - Return endCoordinates for keyboardDidHide keyboard event Pull Request resolved: https://github.com/facebook/react-native/pull/24947 Differential Revision: D15413441 Pulled By: cpojer fbshipit-source-id: aa3998542b7068e9852467038f57310355018379