Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fallback to empty object when native module constants are not defined

Browse Source 
Summary: Force `getConstants` in native modules to return an empty object when they're not defined in their native implementations.

Reviewed By: fkgozali

Differential Revision: D15393585

fbshipit-source-id: cdda9df0d0f0a98ba226340d3cee67fec63e106c
This commit is contained in:
Rubén Norte
2019-05-17 10:04:49 -07:00
committed by Facebook Github Bot
parent ad4a5d9a3e
commit edb07c1f64
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/BatchedBridge/NativeModules.js
+1 -1
View File
@@ -64,7 +64,7 @@ function genModule(
Object.assign(module, constants);
if (module.getConstants == null) {
module.getConstants = () => constants;
module.getConstants = () => constants || Object.freeze({});
} else {
console.warn(
`Unable to define method 'getConstants()' on NativeModule '${moduleName}'. NativeModule '${moduleName}' already has a constant or method called 'getConstants'. Please remove it.`,