Rodolfo Gomez Sirimarco
bebd6531b5
Summary: There is a crash on iOS when trying to show an action sheet, but `RCTPresentedViewController` returns null. The code attempts to print an error but fails when casting values. The issue is that some values, like _title_ or _message_ could be `nil`, which causes a failure when casting them to use in `RCTLogError`. Fixes: https://github.com/facebook/react-native/issues/46549 ## Stacktrace: ``` *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]' 0 CoreFoundation 0x00000001804ae0f8 __exceptionPreprocess + 172 1 libobjc.A.dylib 0x0000000180087db4 objc_exception_throw + 56 2 CoreFoundation 0x000000018051c84c -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 660 3 CoreFoundation 0x00000001804ac9cc +[NSDictionary dictionaryWithObjects:forKeys:count:] + 48 4 AwesomeProject.debug.dylib 0x0000000106ed9138 __61-[RCTActionSheetManager showActionSheetWithOptions:callback:]_block_invoke_4 + 340 5 libdispatch.dylib 0x0000000103f3bec4 _dispatch_call_block_and_release + 24 6 libdispatch.dylib 0x0000000103f3d73c _dispatch_client_callout + 16 7 libdispatch.dylib 0x0000000103f4d3f8 _dispatch_main_queue_drain + 1228 8 libdispatch.dylib 0x0000000103f4cf1c _dispatch_main_queue_callback_4CF + 40 9 CoreFoundation 0x000000018040e960 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12 10 CoreFoundation 0x0000000180409078 __CFRunLoopRun + 1936 11 CoreFoundation 0x00000001804084d4 CFRunLoopRunSpecific + 572 12 GraphicsServices 0x000000018ef2aae4 GSEventRunModal + 160 13 UIKitCore 0x00000001853d0a28 -[UIApplication _run] + 868 14 UIKitCore 0x00000001853d46b0 UIApplicationMain + 124 15 AwesomeProject.debug.dylib 0x0000000106d47bec __debug_main_executable_dylib_entry_point + 96 16 dyld 0x0000000102fbd544 start_sim + 20 17 ??? 0x00000001030620e0 0x0 + 4345700576 18 ??? 0x4e6d800000000000 0x0 + 5651313844908195840 ``` ## Changelog: [IOS] [FIXED] - Fix ActionSheetIOS crash `attempt to insert nil object from objects` Pull Request resolved: https://github.com/facebook/react-native/pull/46550 Test Plan: I created an example project. Example: https://github.com/RodolfoGS/react-native-fix-ios-actionsheet ### How to reproduce using the example above: 1. `git clone git@github.com:RodolfoGS/react-native-fix-ios-actionsheet.git` 2. `cd react-native-fix-ios-actionsheet` 3. `npm install` 4. `npm run ios` 5. Tap on _Show Action Sheet_ button on the app 6. Notice the crash ### Steps to create the example from scratch and reproduce the crash: 1. `npx react-native-community/cli@latest init AwesomeProject` 2. `cd AwesomeProject` 3. Install `patch-package` and add this patch to simulate a situation where `RCTPresentedViewController` returns null (https://github.com/RodolfoGS/react-native-fix-ios-actionsheet/blob/main/patches/react-native%2B0.75.3.patch) 4. `npm run ios` 5. Tap on _Show Action Sheet_ button on the app 6. Notice the crash Reviewed By: caodoan Differential Revision: D62897554 Pulled By: philIip fbshipit-source-id: fb978c4648a6c4e36c609783e59367a5997e42cb
React Native
Learn once, write anywhere:
Build mobile apps with React.
Getting Started · Learn the Basics · Showcase · Contribute · Community · Support
React Native brings React's declarative UI framework to iOS and Android. With React Native, you use native UI controls and have full access to the native platform.
- Declarative. React makes it painless to create interactive UIs. Declarative views make your code more predictable and easier to debug.
- Component-Based. Build encapsulated components that manage their state, then compose them to make complex UIs.
- Developer Velocity. See local changes in seconds. Changes to JavaScript code can be live reloaded without rebuilding the native app.
- Portability. Reuse code across iOS, Android, and other platforms.
React Native is developed and supported by many companies and individual core contributors. Find out more in our ecosystem overview.
Contents
- Requirements
- Building your first React Native app
- Documentation
- Upgrading
- How to Contribute
- Code of Conduct
- License
📋 Requirements
React Native apps may target iOS 13.4 and Android 6.0 (API 23) or newer. You may use Windows, macOS, or Linux as your development operating system, though building and running iOS apps is limited to macOS. Tools like Expo can be used to work around this.
🎉 Building your first React Native app
Follow the Getting Started guide. The recommended way to install React Native depends on your project. Here you can find short guides for the most common scenarios:
📖 Documentation
The full documentation for React Native can be found on our website.
The React Native documentation discusses components, APIs, and topics that are specific to React Native. For further documentation on the React API that is shared between React Native and React DOM, refer to the React documentation.
The source for the React Native documentation and website is hosted on a separate repo, @facebook/react-native-website.
🚀 Upgrading
Upgrading to new versions of React Native may give you access to more APIs, views, developer tools, and other goodies. See the Upgrading Guide for instructions.
React Native releases are discussed in this discussion repo.
👏 How to Contribute
The main purpose of this repository is to continue evolving React Native core. We want to make contributing to this project as easy and transparent as possible, and we are grateful to the community for contributing bug fixes and improvements. Read below to learn how you can take part in improving React Native.
Code of Conduct
Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please read the full text so that you can understand what actions will and will not be tolerated.
Contributing Guide
Read our Contributing Guide to learn about our development process, how to propose bugfixes and improvements, and how to build and test your changes to React Native.
Open Source Roadmap
You can learn more about our vision for React Native in the Roadmap.
Good First Issues
We have a list of good first issues that contain bugs which have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.
Discussions
Larger discussions and proposals are discussed in @react-native-community/discussions-and-proposals.
📄 License
React Native is MIT licensed, as found in the LICENSE file.
React Native documentation is Creative Commons licensed, as found in the LICENSE-docs file.