mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
3093010ea5
Summary: This diff moves fabric C++ code from ReactCommon/fabric to ReactCommon/react/renderer As part of this diff I also refactored components, codegen and callsites on CatalystApp, FB4A and venice Script: P137350694 changelog: [internal] internal refactor Reviewed By: fkgozali Differential Revision: D22852139 fbshipit-source-id: f85310ba858b6afd81abfd9cbe6d70b28eca7415
222 lines
7.4 KiB
C++
222 lines
7.4 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <algorithm>
|
|
#include <memory>
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
|
|
#include <react/renderer/components/root/RootComponentDescriptor.h>
|
|
#include <react/renderer/components/scrollview/ScrollViewComponentDescriptor.h>
|
|
#include <react/renderer/components/view/ViewComponentDescriptor.h>
|
|
#include <react/renderer/element/ComponentBuilder.h>
|
|
#include <react/renderer/element/Element.h>
|
|
#include <react/renderer/element/testUtils.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
class YogaDirtyFlagTest : public ::testing::Test {
|
|
protected:
|
|
ComponentBuilder builder_;
|
|
std::shared_ptr<RootShadowNode> rootShadowNode_;
|
|
std::shared_ptr<ViewShadowNode> innerShadowNode_;
|
|
std::shared_ptr<ScrollViewShadowNode> scrollViewShadowNode_;
|
|
|
|
YogaDirtyFlagTest() : builder_(simpleComponentBuilder()) {
|
|
// clang-format off
|
|
auto element =
|
|
Element<RootShadowNode>()
|
|
.reference(rootShadowNode_)
|
|
.tag(1)
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.tag(2),
|
|
Element<ViewShadowNode>()
|
|
.tag(3)
|
|
.reference(innerShadowNode_)
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.tag(4)
|
|
.props([] {
|
|
/*
|
|
* Some non-default props.
|
|
*/
|
|
auto mutableViewProps = std::make_shared<ViewProps>();
|
|
auto &props = *mutableViewProps;
|
|
props.nativeId = "native Id";
|
|
props.opacity = 0.5;
|
|
props.yogaStyle.alignContent() = YGAlignBaseline;
|
|
props.yogaStyle.flexDirection() = YGFlexDirectionRowReverse;
|
|
return mutableViewProps;
|
|
}),
|
|
Element<ViewShadowNode>()
|
|
.tag(5),
|
|
Element<ViewShadowNode>()
|
|
.tag(6),
|
|
Element<ScrollViewShadowNode>()
|
|
.reference(scrollViewShadowNode_)
|
|
.tag(7)
|
|
})
|
|
});
|
|
// clang-format on
|
|
|
|
builder_.build(element);
|
|
|
|
/*
|
|
* Yoga nodes are dirty right after creation.
|
|
*/
|
|
EXPECT_TRUE(rootShadowNode_->layoutIfNeeded());
|
|
|
|
/*
|
|
* Yoga nodes are clean (not dirty) right after layout pass.
|
|
*/
|
|
EXPECT_FALSE(rootShadowNode_->layoutIfNeeded());
|
|
}
|
|
};
|
|
|
|
TEST_F(YogaDirtyFlagTest, cloningPropsWithoutChangingThem) {
|
|
/*
|
|
* Cloning props without changing them must *not* dirty a Yoga node.
|
|
*/
|
|
auto newRootShadowNode = rootShadowNode_->cloneTree(
|
|
innerShadowNode_->getFamily(), [](ShadowNode const &oldShadowNode) {
|
|
auto &componentDescriptor = oldShadowNode.getComponentDescriptor();
|
|
auto props = componentDescriptor.cloneProps(
|
|
oldShadowNode.getProps(), RawProps());
|
|
return oldShadowNode.clone(ShadowNodeFragment{props});
|
|
});
|
|
|
|
EXPECT_FALSE(
|
|
static_cast<RootShadowNode &>(*newRootShadowNode).layoutIfNeeded());
|
|
}
|
|
|
|
TEST_F(YogaDirtyFlagTest, changingNonLayoutSubPropsMustNotDirtyYogaNode) {
|
|
/*
|
|
* Changing *non-layout* sub-props must *not* dirty a Yoga node.
|
|
*/
|
|
auto newRootShadowNode = rootShadowNode_->cloneTree(
|
|
innerShadowNode_->getFamily(), [](ShadowNode const &oldShadowNode) {
|
|
auto viewProps = std::make_shared<ViewProps>();
|
|
auto &props = *viewProps;
|
|
|
|
props.nativeId = "some new native Id";
|
|
props.foregroundColor = whiteColor();
|
|
props.backgroundColor = blackColor();
|
|
props.opacity = props.opacity + 0.042;
|
|
props.zIndex = props.zIndex.value_or(0) + 42;
|
|
props.shouldRasterize = !props.shouldRasterize;
|
|
props.collapsable = !props.collapsable;
|
|
|
|
return oldShadowNode.clone(ShadowNodeFragment{viewProps});
|
|
});
|
|
|
|
EXPECT_FALSE(
|
|
static_cast<RootShadowNode &>(*newRootShadowNode).layoutIfNeeded());
|
|
}
|
|
|
|
TEST_F(YogaDirtyFlagTest, changingLayoutSubPropsMustDirtyYogaNode) {
|
|
/*
|
|
* Changing *layout* sub-props *must* dirty a Yoga node.
|
|
*/
|
|
auto newRootShadowNode = rootShadowNode_->cloneTree(
|
|
innerShadowNode_->getFamily(), [](ShadowNode const &oldShadowNode) {
|
|
auto viewProps = std::make_shared<ViewProps>();
|
|
auto &props = *viewProps;
|
|
|
|
props.yogaStyle.alignContent() = YGAlignBaseline;
|
|
props.yogaStyle.display() = YGDisplayNone;
|
|
|
|
return oldShadowNode.clone(ShadowNodeFragment{viewProps});
|
|
});
|
|
|
|
EXPECT_TRUE(
|
|
static_cast<RootShadowNode &>(*newRootShadowNode).layoutIfNeeded());
|
|
}
|
|
|
|
TEST_F(YogaDirtyFlagTest, removingAllChildrenMustDirtyYogaNode) {
|
|
/*
|
|
* Removing all children *must* dirty a Yoga node.
|
|
*/
|
|
auto newRootShadowNode = rootShadowNode_->cloneTree(
|
|
innerShadowNode_->getFamily(), [](ShadowNode const &oldShadowNode) {
|
|
return oldShadowNode.clone(
|
|
{ShadowNodeFragment::propsPlaceholder(),
|
|
ShadowNode::emptySharedShadowNodeSharedList()});
|
|
});
|
|
|
|
EXPECT_TRUE(
|
|
static_cast<RootShadowNode &>(*newRootShadowNode).layoutIfNeeded());
|
|
}
|
|
|
|
TEST_F(YogaDirtyFlagTest, removingLastChildMustDirtyYogaNode) {
|
|
/*
|
|
* Removing the last child *must* dirty the Yoga node.
|
|
*/
|
|
auto newRootShadowNode = rootShadowNode_->cloneTree(
|
|
innerShadowNode_->getFamily(), [](ShadowNode const &oldShadowNode) {
|
|
auto children = oldShadowNode.getChildren();
|
|
children.pop_back();
|
|
|
|
std::reverse(children.begin(), children.end());
|
|
|
|
return oldShadowNode.clone(
|
|
{ShadowNodeFragment::propsPlaceholder(),
|
|
std::make_shared<ShadowNode::ListOfShared const>(children)});
|
|
});
|
|
|
|
EXPECT_TRUE(
|
|
static_cast<RootShadowNode &>(*newRootShadowNode).layoutIfNeeded());
|
|
}
|
|
|
|
TEST_F(YogaDirtyFlagTest, reversingListOfChildrenMustDirtyYogaNode) {
|
|
/*
|
|
* Reversing a list of children *must* dirty a Yoga node.
|
|
*/
|
|
auto newRootShadowNode = rootShadowNode_->cloneTree(
|
|
innerShadowNode_->getFamily(), [](ShadowNode const &oldShadowNode) {
|
|
auto children = oldShadowNode.getChildren();
|
|
|
|
std::reverse(children.begin(), children.end());
|
|
|
|
return oldShadowNode.clone(
|
|
{ShadowNodeFragment::propsPlaceholder(),
|
|
std::make_shared<ShadowNode::ListOfShared const>(children)});
|
|
});
|
|
|
|
EXPECT_TRUE(
|
|
static_cast<RootShadowNode &>(*newRootShadowNode).layoutIfNeeded());
|
|
}
|
|
|
|
TEST_F(YogaDirtyFlagTest, updatingStateForScrollViewMistNotDirtyYogaNode) {
|
|
/*
|
|
* Updating a state for *some* (not all!) components must *not* dirty Yoga
|
|
* nodes.
|
|
*/
|
|
auto newRootShadowNode = rootShadowNode_->cloneTree(
|
|
scrollViewShadowNode_->getFamily(), [](ShadowNode const &oldShadowNode) {
|
|
auto state = ScrollViewState{};
|
|
state.contentOffset = Point{42, 9000};
|
|
|
|
auto &componentDescriptor = oldShadowNode.getComponentDescriptor();
|
|
auto newState = componentDescriptor.createState(
|
|
oldShadowNode.getFamily(),
|
|
std::make_shared<ScrollViewState>(state));
|
|
|
|
return oldShadowNode.clone({ShadowNodeFragment::propsPlaceholder(),
|
|
ShadowNodeFragment::childrenPlaceholder(),
|
|
newState});
|
|
});
|
|
|
|
EXPECT_FALSE(
|
|
static_cast<RootShadowNode &>(*newRootShadowNode).layoutIfNeeded());
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|