mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
14042fb76f
Summary:
This pull request fixes a potential `TypeError` in TaskQueue.js, that happens if a promise is added to the task queue, which is cancelled between the promise starting and resolving.
The exact error this resolves is
```js
TypeError: TaskQueue: Error resolving Promise in task gen1: Cannot set property ‘popable’ of undefined
167 | queueStackSize: this._queueStack.length,
168 | });
> 169 | this._queueStack[stackIdx].popable = true;
| ^
170 | this.hasTasksToProcess() && this._onMoreTasks();
171 | })
172 | .catch(ex => {
at Libraries/Interaction/TaskQueue.js:169:46
```
This specific error was also reported in https://github.com/facebook/react-native/issues/16321
## Changelog
[General] [Fixed] - Prevent TypeError in TaskQueue when cancelling a started but not resolved promise.
Pull Request resolved: https://github.com/facebook/react-native/pull/29969
Test Plan:
The added test demonstrates the error, if run without the fixed applied to TaskQueue.js.
This is a race condition error, so is difficult to replicate!
Reviewed By: yungsters
Differential Revision: D23785972
Pulled By: appden
fbshipit-source-id: ddb8d06b37d296ee934ff39815cf5c9026d73871
170 lines
4.6 KiB
JavaScript
170 lines
4.6 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @emails oncall+react_native
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const Promise = require('promise');
|
|
|
|
function expectToBeCalledOnce(fn) {
|
|
expect(fn.mock.calls.length).toBe(1);
|
|
}
|
|
|
|
function clearTaskQueue(taskQueue) {
|
|
do {
|
|
jest.runAllTimers();
|
|
taskQueue.processNext();
|
|
jest.runAllTimers();
|
|
} while (taskQueue.hasTasksToProcess());
|
|
}
|
|
|
|
describe('TaskQueue', () => {
|
|
let taskQueue;
|
|
let onMoreTasks;
|
|
let sequenceId;
|
|
function createSequenceTask(expectedSequenceId) {
|
|
return jest.fn(() => {
|
|
expect(++sequenceId).toBe(expectedSequenceId);
|
|
});
|
|
}
|
|
beforeEach(() => {
|
|
jest.resetModules();
|
|
onMoreTasks = jest.fn();
|
|
const TaskQueue = require('../TaskQueue');
|
|
taskQueue = new TaskQueue({onMoreTasks});
|
|
sequenceId = 0;
|
|
});
|
|
|
|
it('should run a basic task', () => {
|
|
const task1 = createSequenceTask(1);
|
|
taskQueue.enqueue({run: task1, name: 'run1'});
|
|
expect(taskQueue.hasTasksToProcess()).toBe(true);
|
|
taskQueue.processNext();
|
|
expectToBeCalledOnce(task1);
|
|
});
|
|
|
|
it('should handle blocking promise task', () => {
|
|
const task1 = jest.fn(() => {
|
|
return new Promise(resolve => {
|
|
setTimeout(() => {
|
|
expect(++sequenceId).toBe(1);
|
|
resolve();
|
|
}, 1);
|
|
});
|
|
});
|
|
const task2 = createSequenceTask(2);
|
|
taskQueue.enqueue({gen: task1, name: 'gen1'});
|
|
taskQueue.enqueue({run: task2, name: 'run2'});
|
|
|
|
taskQueue.processNext();
|
|
|
|
expectToBeCalledOnce(task1);
|
|
expect(task2).not.toBeCalled();
|
|
expect(onMoreTasks).not.toBeCalled();
|
|
expect(taskQueue.hasTasksToProcess()).toBe(false);
|
|
|
|
clearTaskQueue(taskQueue);
|
|
|
|
expectToBeCalledOnce(onMoreTasks);
|
|
expectToBeCalledOnce(task2);
|
|
});
|
|
|
|
it('should handle nested simple tasks', () => {
|
|
const task1 = jest.fn(() => {
|
|
expect(++sequenceId).toBe(1);
|
|
taskQueue.enqueue({run: task3, name: 'run3'});
|
|
});
|
|
const task2 = createSequenceTask(2);
|
|
const task3 = createSequenceTask(3);
|
|
taskQueue.enqueue({run: task1, name: 'run1'});
|
|
taskQueue.enqueue({run: task2, name: 'run2'}); // not blocked by task 1
|
|
|
|
clearTaskQueue(taskQueue);
|
|
|
|
expectToBeCalledOnce(task1);
|
|
expectToBeCalledOnce(task2);
|
|
expectToBeCalledOnce(task3);
|
|
});
|
|
|
|
it('should handle nested promises', () => {
|
|
const task1 = jest.fn(() => {
|
|
return new Promise(resolve => {
|
|
setTimeout(() => {
|
|
expect(++sequenceId).toBe(1);
|
|
taskQueue.enqueue({gen: task2, name: 'gen2'});
|
|
taskQueue.enqueue({run: resolve, name: 'resolve1'});
|
|
}, 1);
|
|
});
|
|
});
|
|
const task2 = jest.fn(() => {
|
|
return new Promise(resolve => {
|
|
setTimeout(() => {
|
|
expect(++sequenceId).toBe(2);
|
|
taskQueue.enqueue({run: task3, name: 'run3'});
|
|
taskQueue.enqueue({run: resolve, name: 'resolve2'});
|
|
}, 1);
|
|
});
|
|
});
|
|
const task3 = createSequenceTask(3);
|
|
const task4 = createSequenceTask(4);
|
|
taskQueue.enqueue({gen: task1, name: 'gen1'});
|
|
taskQueue.enqueue({run: task4, name: 'run4'}); // blocked by task 1 promise
|
|
|
|
clearTaskQueue(taskQueue);
|
|
|
|
expectToBeCalledOnce(task1);
|
|
expectToBeCalledOnce(task2);
|
|
expectToBeCalledOnce(task3);
|
|
expectToBeCalledOnce(task4);
|
|
});
|
|
|
|
it('should be able to cancel tasks', () => {
|
|
const task1 = jest.fn();
|
|
const task2 = createSequenceTask(1);
|
|
const task3 = jest.fn();
|
|
const task4 = createSequenceTask(2);
|
|
taskQueue.enqueue(task1);
|
|
taskQueue.enqueue(task2);
|
|
taskQueue.enqueue(task3);
|
|
taskQueue.enqueue(task4);
|
|
taskQueue.cancelTasks([task1, task3]);
|
|
clearTaskQueue(taskQueue);
|
|
expect(task1).not.toBeCalled();
|
|
expect(task3).not.toBeCalled();
|
|
expectToBeCalledOnce(task2);
|
|
expectToBeCalledOnce(task4);
|
|
expect(taskQueue.hasTasksToProcess()).toBe(false);
|
|
});
|
|
|
|
it('should not crash when last task is cancelled', () => {
|
|
const task1 = jest.fn();
|
|
taskQueue.enqueue(task1);
|
|
taskQueue.cancelTasks([task1]);
|
|
clearTaskQueue(taskQueue);
|
|
expect(task1).not.toBeCalled();
|
|
expect(taskQueue.hasTasksToProcess()).toBe(false);
|
|
});
|
|
|
|
it('should not crash when task is cancelled between being started and resolved', () => {
|
|
const task1 = jest.fn(() => {
|
|
return new Promise(resolve => {
|
|
setTimeout(() => {
|
|
resolve();
|
|
}, 1);
|
|
});
|
|
});
|
|
|
|
taskQueue.enqueue({gen: task1, name: 'gen1'});
|
|
taskQueue.processNext();
|
|
taskQueue.cancelTasks([task1]);
|
|
|
|
jest.runAllTimers();
|
|
});
|
|
});
|