mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel Susla
bcc4ab35da
Summary: changelog: [internal] For some reason, using `TextLayoutManager::Shared` in `TextInputShadowNode` trips up clang tidy linter. We have a plan to move away from `*::Shared` anyway, so let's remove it from `TextInputShadowNode` now. Why do we want to move away from `*::Shared`? Using `TextLayoutManager::Shared` is confusing for people unfamiliar with Fabric's codebase. It expresses a concept of immutability but uses term `shared`. Term shared is already used in C++ `std::shared_ptr`. Reviewed By: fkgozali Differential Revision: D33186422 fbshipit-source-id: 10ee588735997f5fedc372a1d1e3d9cd9684178a
44 lines
1.2 KiB
C++
44 lines
1.2 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <react/renderer/components/iostextinput/TextInputShadowNode.h>
|
|
#include <react/renderer/core/ConcreteComponentDescriptor.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
/*
|
|
* Descriptor for <TextInput> component.
|
|
*/
|
|
class TextInputComponentDescriptor final
|
|
: public ConcreteComponentDescriptor<TextInputShadowNode> {
|
|
public:
|
|
TextInputComponentDescriptor(ComponentDescriptorParameters const ¶meters)
|
|
: ConcreteComponentDescriptor<TextInputShadowNode>(parameters) {
|
|
textLayoutManager_ =
|
|
std::make_shared<TextLayoutManager const>(contextContainer_);
|
|
}
|
|
|
|
protected:
|
|
void adopt(ShadowNode::Unshared const &shadowNode) const override {
|
|
ConcreteComponentDescriptor::adopt(shadowNode);
|
|
|
|
auto concreteShadowNode =
|
|
std::static_pointer_cast<TextInputShadowNode>(shadowNode);
|
|
|
|
concreteShadowNode->setTextLayoutManager(textLayoutManager_);
|
|
}
|
|
|
|
private:
|
|
std::shared_ptr<TextLayoutManager const> textLayoutManager_;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|