Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
bcc4ab35da9bcd2ee9aa2be86d602a03dc3b475b
react-native/ReactCommon/react/renderer
T
History
Samuel Susla bcc4ab35da Remove use of TextLayoutManager::Shared and SharedTextLayoutManager 
Summary:
changelog: [internal]

For some reason, using `TextLayoutManager::Shared` in `TextInputShadowNode` trips up clang tidy linter. We have a plan to move away from `*::Shared` anyway, so let's remove it from `TextInputShadowNode` now.

Why do we want to move away from `*::Shared`?
Using `TextLayoutManager::Shared` is confusing for people unfamiliar with Fabric's codebase. It expresses a concept of immutability but uses term `shared`. Term shared is already used in C++  `std::shared_ptr`.

Reviewed By: fkgozali

Differential Revision: D33186422

fbshipit-source-id: 10ee588735997f5fedc372a1d1e3d9cd9684178a
2021-12-22 04:20:42 -08:00
..
animations
C++ - better => butter
2021-12-20 22:25:14 -08:00
attributedstring
C++ - better => butter
2021-12-20 22:25:14 -08:00
componentregistry
C++ - better => butter
2021-12-20 22:25:14 -08:00
components
Remove use of TextLayoutManager::Shared and SharedTextLayoutManager
2021-12-22 04:20:42 -08:00
core
C++ - better => butter
2021-12-20 22:25:14 -08:00
debug
C++ - better => butter
2021-12-20 22:25:14 -08:00
element
Remove compiler_flags from BUCK modules
2021-10-14 15:34:29 -07:00
graphics
C++ - better => butter
2021-12-20 22:25:14 -08:00
imagemanager
C++ - better => butter
2021-12-20 22:25:14 -08:00
leakchecker
Update LOCAL_SHARED_LIBRARIES to be a multiline string
2021-11-29 13:01:51 -08:00
mapbuffer
Update LOCAL_SHARED_LIBRARIES to be a multiline string
2021-11-29 13:01:51 -08:00
mounting
C++ - better => butter
2021-12-20 22:25:14 -08:00
runtimescheduler
C++ - better => butter
2021-12-20 22:25:14 -08:00
scheduler
C++ - better => butter
2021-12-20 22:25:14 -08:00
telemetry
C++ - better => butter
2021-12-20 22:25:14 -08:00
templateprocessor
Remove unused arguments
2021-12-20 11:22:43 -08:00
textlayoutmanager
Remove use of TextLayoutManager::Shared and SharedTextLayoutManager
2021-12-22 04:20:42 -08:00
timeline
C++ - better => butter
2021-12-20 22:25:14 -08:00
uimanager
C++ - better => butter
2021-12-20 22:25:14 -08:00
.clang-tidy
Enable modernize-deprecated-ios-base-aliases in clang-tidy
2021-12-20 11:22:43 -08:00