mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin SherginandFacebook Github Bot
c5f704b8e3
Summary: This is the first diff in the journey of removing `enable_shared_from_this` from `ShadowNode` class. In general, using `enable_shared_from_this` is fine, it's a normal standard feature and there is nothing wrong with that... besides the fact that using this thing is usually an indication of overall poor design. In Fabric, we don't really have a good reason for that, I think in all cases it can be avoided, so I think we should remove that. Removing that is also code-size and perf win. This particular diff changes the signature of `RootShadowNode::clone()` which allows removing the necessity of usage `.shared_from_this()` from callsites. The rest changes are purely cosmetical. Changelog: [Internal] Small Fabric-specific optimization. Reviewed By: sammy-SC Differential Revision: D17973958 fbshipit-source-id: 5539ceff9d11b4281a6ebe8d80e90d6bd90e44d8
85 lines
2.5 KiB
C++
85 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "RootShadowNode.h"
|
|
|
|
#include <react/components/view/conversions.h>
|
|
#include <react/debug/SystraceSection.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
const char RootComponentName[] = "RootView";
|
|
|
|
void RootShadowNode::layout(
|
|
std::vector<LayoutableShadowNode const *> *affectedNodes) {
|
|
SystraceSection s("RootShadowNode::layout");
|
|
ensureUnsealed();
|
|
|
|
auto layoutContext = getProps()->layoutContext;
|
|
layoutContext.affectedNodes = affectedNodes;
|
|
|
|
layout(layoutContext);
|
|
|
|
// This is the rare place where shadow node must layout (set `layoutMetrics`)
|
|
// itself because there is no a parent node which usually should do it.
|
|
if (getHasNewLayout()) {
|
|
setLayoutMetrics(layoutMetricsFromYogaNode(yogaNode_));
|
|
setHasNewLayout(false);
|
|
}
|
|
}
|
|
|
|
RootShadowNode::Unshared RootShadowNode::clone(
|
|
LayoutConstraints const &layoutConstraints,
|
|
LayoutContext const &layoutContext) const {
|
|
auto props = std::make_shared<RootProps const>(
|
|
*getProps(), layoutConstraints, layoutContext);
|
|
auto newRootShadowNode = std::make_shared<RootShadowNode>(
|
|
*this,
|
|
ShadowNodeFragment{
|
|
/* .tag = */ ShadowNodeFragment::tagPlaceholder(),
|
|
/* .surfaceId = */ ShadowNodeFragment::surfaceIdPlaceholder(),
|
|
/* .props = */ props,
|
|
});
|
|
return newRootShadowNode;
|
|
}
|
|
|
|
RootShadowNode::Unshared RootShadowNode::clone(
|
|
ShadowNode const &oldShadowNode,
|
|
ShadowNode::Shared const &newShadowNode) const {
|
|
auto ancestors = oldShadowNode.getAncestors(*this);
|
|
|
|
if (ancestors.size() == 0) {
|
|
return RootShadowNode::Unshared{nullptr};
|
|
}
|
|
|
|
auto childNode = newShadowNode;
|
|
|
|
for (auto it = ancestors.rbegin(); it != ancestors.rend(); ++it) {
|
|
auto &parentNode = it->first.get();
|
|
auto childIndex = it->second;
|
|
|
|
auto children = parentNode.getChildren();
|
|
assert(ShadowNode::sameFamily(*children.at(childIndex), *childNode));
|
|
children[childIndex] = childNode;
|
|
|
|
childNode = parentNode.clone({
|
|
ShadowNodeFragment::tagPlaceholder(),
|
|
ShadowNodeFragment::surfaceIdPlaceholder(),
|
|
ShadowNodeFragment::propsPlaceholder(),
|
|
ShadowNodeFragment::eventEmitterPlaceholder(),
|
|
std::make_shared<SharedShadowNodeList>(children),
|
|
});
|
|
}
|
|
|
|
return std::const_pointer_cast<RootShadowNode>(
|
|
std::static_pointer_cast<RootShadowNode const>(childNode));
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|