Tim YungandFacebook GitHub Bot b8425c8ee5 RN: Cleanup Existing ESLint Warnings ...

Summary:
Sometime over the past few months (and with changes such as migrating to the `hermes-eslint` parser), a bunch of lint warnings crept into the codebase.

This does a pass to clean them all up, ignore generated files, and refactor some code to be... better.

There should be no observable behavior changes as a result of this.

Changelog:
[Internal]

Reviewed By: NickGerleman

Differential Revision: D38646643

fbshipit-source-id: a7b55d1e4cd5700340cc5c21f928baf3ea1d5a58

2022-08-12 17:16:40 -07:00

..

__tests__

Circle CI: Create GiHub Release draft when bumping version

2022-07-14 13:42:08 -07:00

circleci

Isolate the buck OSS commands inside test_buck (#34378)

2022-08-11 02:46:00 -07:00

cocoapods

Enable Flipper for custom Xcode configurations (#34333)

2022-08-09 10:14:23 -07:00

codegen

RN: Cleanup Existing ESLint Warnings

2022-08-12 17:16:40 -07:00

hermes

Simplify logic to choose if we need to build hermes from source or not. (#34232)

2022-07-22 02:13:47 -07:00

react_native_pods_utils

Run script phases tests in CI and Sandcastle (#33802)

2022-05-11 10:00:28 -07:00

versiontemplates

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

xcode

Export REACT_NATIVE_PATH and fix find-node-for-xcode.sh fallback behavior (#33674)

2022-04-21 06:59:17 -07:00

.npmignore

Move cocoapods utilities to utils.rb - Part 1 (#33978)

2022-06-10 07:25:52 -07:00

.packager.env

Move YGStyle to seperate file and add constructors

2018-02-20 05:55:36 -08:00

.tests.env

Bump OSS Android build to SDK 31 (#32606)

2021-11-24 12:27:26 -08:00

android-e2e-test.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

android-setup.sh

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

bump-oss-version.js

Fix up lint errors under react-native-github (#33622)

2022-04-22 16:25:25 -07:00

compose-source-maps.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

download-kotlin-compiler-with-buck.sh

Download kotlin compiler JARs for Buck instead of checking them in (#33209)

2022-03-02 13:04:49 -08:00

find-node-for-xcode.sh

Reintroduce find-node.sh as mitigation measure (#33538)

2022-04-04 02:43:07 -07:00

generate-api-docs.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

generate-artifacts.js

Refactor generate-artifacts to improve testability.

2022-05-04 04:04:10 -07:00

generate-provider-cli.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

generate-specs-cli.js

Update CodeGen to leverage the outputDir as suggested in diff review (#33729)

2022-05-04 04:04:10 -07:00

ios-configure-glog.sh

fix (glog script): remove invalid param from sed (#33967)

2022-06-17 11:58:08 -07:00

launchPackager.bat

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

launchPackager.command

Use NODE_BINARY from .xcode.env when running packager from Xcode (#34121)

2022-07-12 05:52:22 -07:00

lint-java.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

native_modules.rb

Move cocoapods cli native_modules require from template to rn scripts (#34215)

2022-07-19 09:11:08 -07:00

node-binary.sh

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

objc-test.sh

fix: Make WebSocketTests work in CI (#33721)

2022-04-28 08:53:24 -07:00

packager-reporter.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

packager.sh

Use readlink instead of realpath in packager.sh (#34145)

2022-07-20 07:06:18 -07:00

prepare-package-for-release.js

Fix up lint errors under react-native-github (#33622)

2022-04-22 16:25:25 -07:00

process-podspecs.sh

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

publish-npm.js

Do not fail if -javadoc.jar are missing in the final NPM package (#33869)

2022-05-19 02:48:39 -07:00

react_native_pods.rb

#34214 for main (#34271)

2022-07-27 07:56:05 -07:00

react-native-xcode.sh

Fix USE_HERMES envvar check

2022-08-10 05:24:41 -07:00

run_ruby_tests.sh

Run script phases tests in CI and Sandcastle (#33802)

2022-05-11 10:00:28 -07:00

run-android-ci-instrumentation-tests.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

run-android-emulator.sh

Use realpath instead of readlink

2022-02-22 02:23:02 -08:00

run-android-local-integration-tests.sh

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

run-android-local-unit-tests.sh

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

run-ci-e2e-tests.js

Updating Yarn Cache path to fix broken CI (#32834)

2022-01-06 10:46:15 -08:00

run-ci-javascript-tests.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

run-instrumentation-tests-via-adb-shell.sh

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

set-rn-template-version.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

set-rn-version.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

sync-css-layout.sh

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

test-manual-e2e.sh

Fix test-manual-e2e on Android/Hermes for New App Template (#34294)

2022-07-28 06:23:11 -07:00

try-n-times.js

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

update_podfile_lock.sh

Use realpath instead of readlink

2022-02-22 02:23:02 -08:00

update-ruby.sh

Added Gemfile.lock to git add files when calling update-ruby.sh (#33484)

2022-03-25 08:01:41 -07:00

validate-android-device-env.sh

Update CONTRIBUTING.md, replace wiki links (#34035)

2022-06-21 19:30:23 -07:00

validate-android-sdk.sh

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

validate-android-test-env.sh

Update copyright headers from Facebook to Meta

2021-12-30 15:11:21 -08:00

validate-ios-test-env.sh

bump Node references from 12/14 to 14/16 (#32980)

2022-01-28 05:07:18 -08:00

version-utils.js

Use CircleCI API to trigger releases (#32937)

2022-01-24 14:08:43 -08:00