hublot
b675667a47
Summary: From the video below, we can see that the UI thread has dropped many frames, and it would become worse if there are multiple images. If an image is located in the sandbox of the disk, we cannot load it using `RCTLocalAssetImageLoader` because `RCTLocalAssetImageLoader.requiresScheduling` is set to true, which loads the data on the UI thread and causes main thread stuttering. This will affect libraries such as `react-native-code-push` and others that save images to the sandbox of the disk. Therefore, we should replace `RCTLocalAssetImageLoader.canLoadImageURL` from `RCTIsLocalAssetURL(url)` to `RCTIsBundleAssetURL(url)`. Similarly, we should rename the entire `RCTLocalAssetImageLoader` file with `RCTBundleAssetImageLoader`, which ignores images in the disk sandbox. And finally these images will be loaded from `NSURLRequest`, and our UI thread will run smoothly again. https://user-images.githubusercontent.com/20135674/236368418-8933a2c6-549c-40d3-a551-81b492fe41d5.mp4 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [Breaking] - Replace `RCTLocalAssetImageLoader` to `RCTBundleAssetImageLoader` Pull Request resolved: https://github.com/facebook/react-native/pull/37232 Test Plan: Test Code: ```javascript constructor(props) { super(props) this.state = { bundle_image: require('./large_image.png'), sandbox_image: '', source: null, isLoading: false, } } render() { console.log('render', this.state) return ( <View style={{ flex: 1, padding: 50, backgroundColor: 'white'}}> <View style={{ flexDirection: 'row', alignItems: 'center', height: 70}}> { [{ title: 'Save Image To SandBox', onPress: () => { let image = Image.resolveAssetSource(this.state.bundle_image) console.log(image.uri) this.setState({ isLoading: true }) RNFetchBlob.config({ fileCache: true, appendExt: "png" }).fetch("GET", image.uri).then(response => { let path = response.path() path = /^file:\/\//.test(path) ? path : 'file://' + path console.log(path) this.state.sandbox_image = path }).finally(() => this.setState({ isLoading: false })) }}, { title: 'Load From SandBox', onPress: () => { this.setState({ source: { uri: this.state.sandbox_image } }) }}, { title: 'Clear', onPress: () => { this.setState({ source: null, isLoading: false }) }}, { title: 'Load From Bundle', onPress: () => { this.setState({ source: this.state.bundle_image }) }}].map((item, index) => { return ( <Pressable key={index} style={{ height: '100%', justifyContent: 'center', flex: 1, borderWidth: 1, borderColor: 'black', marginLeft: index > 0 ? 15 : 0 }} onPress={item.onPress} > <Text style={{ textAlign: 'center' }}>{item.title}</Text> </Pressable> ) }) } </View> <ActivityIndicator style={{ marginTop: 10 }} animating={this.state.isLoading} /> <Image key={`${this.state.source}`} style={{ marginTop: 20, width: 200, height: 200 }} source={this.state.source} onProgress={({ nativeEvent }) => console.log(nativeEvent)} onLoadStart={() => this.setState({ isLoading: true })} onLoadEnd={() => this.setState({ isLoading: false })} /> </View> ) } ``` It needs to be tested in three environments: [Simulator_Debug, RealDevice_Debug, RealDevice_Release] 1. Open `Perf Monitor` (RealDevice_Release can be skipped) 2. Click `Save Image to SandBox` 3. Wait for the loading to end and click `Load From SandBox` 4. Verify that the image can be loaded successfully 5. Verify that the `UI thread` keeps `60 FPS` (RealDevice_Release can be skipped) 6. Click `Clear` 7. Repeat steps [3, 4, 5, 6] several times 8. Click `Load From Bundle` to verify that the bundle image can be loaded successfully Simulator_Debug https://user-images.githubusercontent.com/20135674/236369344-ee1b8ff1-2d49-49f3-a322-d973f4adf3e7.mp4 RealDevice_Debug https://user-images.githubusercontent.com/20135674/236369356-fe440b2b-f72a-49be-b63c-b4bf709dac8c.mp4 RealDevice_Release https://user-images.githubusercontent.com/20135674/236369365-8a6a5c2f-09ad-4c90-b6bd-41e8a5e3aa7f.mp4 Reviewed By: rshest Differential Revision: D46441513 Pulled By: dmytrorykun fbshipit-source-id: 652febd4147dbff6c1ceef03d84ce125b8c66770
React Native
Learn once, write anywhere:
Build mobile apps with React.
Getting Started · Learn the Basics · Showcase · Contribute · Community · Support
React Native brings React's declarative UI framework to iOS and Android. With React Native, you use native UI controls and have full access to the native platform.
- Declarative. React makes it painless to create interactive UIs. Declarative views make your code more predictable and easier to debug.
- Component-Based. Build encapsulated components that manage their state, then compose them to make complex UIs.
- Developer Velocity. See local changes in seconds. Changes to JavaScript code can be live reloaded without rebuilding the native app.
- Portability. Reuse code across iOS, Android, and other platforms.
React Native is developed and supported by many companies and individual core contributors. Find out more in our ecosystem overview.
Contents
- Requirements
- Building your first React Native app
- Documentation
- Upgrading
- How to Contribute
- Code of Conduct
- License
📋 Requirements
React Native apps may target iOS 13.4 and Android 5.0 (API 21) or newer. You may use Windows, macOS, or Linux as your development operating system, though building and running iOS apps is limited to macOS. Tools like Expo can be used to work around this.
🎉 Building your first React Native app
Follow the Getting Started guide. The recommended way to install React Native depends on your project. Here you can find short guides for the most common scenarios:
📖 Documentation
The full documentation for React Native can be found on our website.
The React Native documentation discusses components, APIs, and topics that are specific to React Native. For further documentation on the React API that is shared between React Native and React DOM, refer to the React documentation.
The source for the React Native documentation and website is hosted on a separate repo, @facebook/react-native-website.
🚀 Upgrading
Upgrading to new versions of React Native may give you access to more APIs, views, developer tools, and other goodies. See the Upgrading Guide for instructions.
React Native releases are discussed in this discussion repo.
👏 How to Contribute
The main purpose of this repository is to continue evolving React Native core. We want to make contributing to this project as easy and transparent as possible, and we are grateful to the community for contributing bug fixes and improvements. Read below to learn how you can take part in improving React Native.
Code of Conduct
Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please read the full text so that you can understand what actions will and will not be tolerated.
Contributing Guide
Read our Contributing Guide to learn about our development process, how to propose bugfixes and improvements, and how to build and test your changes to React Native.
Open Source Roadmap
You can learn more about our vision for React Native in the Roadmap.
Good First Issues
We have a list of good first issues that contain bugs which have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.
Discussions
Larger discussions and proposals are discussed in @react-native-community/discussions-and-proposals.
📄 License
React Native is MIT licensed, as found in the LICENSE file.
React Native documentation is Creative Commons licensed, as found in the LICENSE-docs file.