mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Vojtech Novak
ca65d97d60
Summary: The Pressable component supports the `foreground` option for ripple. However, using it on old android api levels (e.g. android 5) crashes with ``` Error while updating property nativeForegroundAndroid' of a view managed by: RCTView null No virtual method setForeground(Landroid/ graphics/drawable/Drawable;)V in class Lcom/ facebook/react/views/view/ReactViewGroup; or its super classes ``` TouchableNativeFeedback.js has a check to make sure this does not happen [as seen here](https://github.com/facebook/react-native/blob/b0485bed0945061becace5af924fa60b17ab295f/packages/react-native/Libraries/Components/Touchable/TouchableNativeFeedback.js#L158) I also want to point out that this PR can be closed https://github.com/facebook/react-native/pull/30466 as it's already implemented ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID] [FIXED] - foreground ripple crashed on api < 23 For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: https://github.com/facebook/react-native/pull/37901 Test Plan: tested locally on [another project](https://github.com/react-navigation/react-navigation/pull/11386) because I wasn't able to get RN tester running Reviewed By: rshest Differential Revision: D46747310 Pulled By: NickGerleman fbshipit-source-id: 4ee9062f821f5d629a1a0151c2fef61d836d09a4