mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Andrew Coates
4d87d8c6b2
Summary: react-native-windows runs with a more strict set of warnings as errors. This fixes a bunch of warnings being hit while compiling core react-native code as part of react-native-windows. In particular warnings about mismatched signed/unsigned comparisons, lossy conversions, and variable names that conflict with names in outer scopes (yoga has a global for `leading` and `trailing` that conflicts with some local variable names) ## Changelog [Internal] [Fixed] - Fix various C++ warnings Pull Request resolved: https://github.com/facebook/react-native/pull/31399 Test Plan: I've run these changes in react-native-windows. -- Shouldn't have any functionality difference. Reviewed By: sammy-SC Differential Revision: D28290188 Pulled By: rozele fbshipit-source-id: 2f7cf87f58d73a3f43510ac888dbcb9ab177d134
101 lines
3.2 KiB
C++
101 lines
3.2 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "stubs.h"
|
|
|
|
#include <react/renderer/core/LayoutableShadowNode.h>
|
|
#include <react/renderer/core/ShadowNodeFragment.h>
|
|
#include <react/renderer/mounting/Differentiator.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
/*
|
|
* Sorting comparator for `reorderInPlaceIfNeeded`.
|
|
*/
|
|
static bool shouldFirstPairComesBeforeSecondOne(
|
|
ShadowViewNodePair const &lhs,
|
|
ShadowViewNodePair const &rhs) noexcept {
|
|
return lhs.shadowNode->getOrderIndex() < rhs.shadowNode->getOrderIndex();
|
|
}
|
|
|
|
/*
|
|
* Reorders pairs in-place based on `orderIndex` using a stable sort algorithm.
|
|
*/
|
|
static void reorderInPlaceIfNeeded(
|
|
ShadowViewNodePair::OwningList &pairs) noexcept {
|
|
// This is a simplified version of the function intentionally copied from
|
|
// `Differentiator.cpp`.
|
|
std::stable_sort(
|
|
pairs.begin(), pairs.end(), &shouldFirstPairComesBeforeSecondOne);
|
|
}
|
|
|
|
/*
|
|
* Generates `create` and `insert` instructions recursively traversing a shadow
|
|
* tree.
|
|
* This is a trivial implementation of diffing algorithm that can only "diff"
|
|
* an empty tree with some other one.
|
|
*/
|
|
static void calculateShadowViewMutationsForNewTree(
|
|
ShadowViewMutation::List &mutations,
|
|
ShadowView const &parentShadowView,
|
|
ShadowViewNodePair::OwningList newChildPairs) {
|
|
// Sorting pairs based on `orderIndex` if needed.
|
|
reorderInPlaceIfNeeded(newChildPairs);
|
|
|
|
for (size_t index = 0; index < newChildPairs.size(); index++) {
|
|
auto const &newChildPair = newChildPairs[index];
|
|
|
|
mutations.push_back(
|
|
ShadowViewMutation::CreateMutation(newChildPair.shadowView));
|
|
mutations.push_back(ShadowViewMutation::InsertMutation(
|
|
parentShadowView, newChildPair.shadowView, static_cast<int>(index)));
|
|
|
|
auto newGrandChildPairs =
|
|
sliceChildShadowNodeViewPairsLegacy(*newChildPair.shadowNode);
|
|
|
|
calculateShadowViewMutationsForNewTree(
|
|
mutations, newChildPair.shadowView, newGrandChildPairs);
|
|
}
|
|
}
|
|
|
|
StubViewTree buildStubViewTreeWithoutUsingDifferentiator(
|
|
ShadowNode const &rootShadowNode) {
|
|
auto mutations = ShadowViewMutation::List{};
|
|
mutations.reserve(256);
|
|
|
|
calculateShadowViewMutationsForNewTree(
|
|
mutations,
|
|
ShadowView(rootShadowNode),
|
|
sliceChildShadowNodeViewPairsLegacy(rootShadowNode));
|
|
|
|
auto emptyRootShadowNode = rootShadowNode.clone(ShadowNodeFragment{
|
|
ShadowNodeFragment::propsPlaceholder(),
|
|
ShadowNode::emptySharedShadowNodeSharedList()});
|
|
|
|
auto stubViewTree = StubViewTree(ShadowView(*emptyRootShadowNode));
|
|
stubViewTree.mutate(mutations);
|
|
return stubViewTree;
|
|
}
|
|
|
|
StubViewTree buildStubViewTreeUsingDifferentiator(
|
|
ShadowNode const &rootShadowNode) {
|
|
auto emptyRootShadowNode = rootShadowNode.clone(ShadowNodeFragment{
|
|
ShadowNodeFragment::propsPlaceholder(),
|
|
ShadowNode::emptySharedShadowNodeSharedList()});
|
|
|
|
auto mutations =
|
|
calculateShadowViewMutations(*emptyRootShadowNode, rootShadowNode, true);
|
|
|
|
auto stubViewTree = StubViewTree(ShadowView(*emptyRootShadowNode));
|
|
stubViewTree.mutate(mutations);
|
|
return stubViewTree;
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|