Mateo Guzmán
81cb166d10
Summary: While trying to write some test cases for `ReactOkHttpNetworkFetcher`, I found that the cache control headers are not being sent over the network request correctly. These cache control headers are always being overwritten by the rest of the headers hence all the logic to set this custom cache control doesn't seem to be working as expected. As per the [Request headers](https://github.com/square/okhttp/blob/2832a9e532ecbc6f1f84b3a07e8e64b75372789c/okhttp/src/main/kotlin/okhttp3/Request.kt#L256) docs, this seems to be the explanation: > /** Removes all headers on this builder and adds [headers]. */ open fun headers(headers: Headers) = commonHeaders(headers) With the new approach by setting the headers first, we ensure that the cache control headers don't get overwritten but they would get added on top of the passed headers. Notice that currently it seems to be overwriting these headers even if there are not headers passed from the Image component (AKA null/empty). See my reproduction example in the test plan. ## Changelog: [ANDROID] [FIXED] - ReactOkHttpNetworkFetcher – cache control headers getting overwritten by the rest of the headers Pull Request resolved: https://github.com/facebook/react-native/pull/47922 Test Plan: By creating the following component, we log the request headers using `FLog` with the previous and the new approach. See the difference on the outputs below: Component: ```tsx <Image source={{ uri: 'https://www.facebook.com/assets/fb_lite_messaging/E2EE-settings@3x.png?cacheBust=reload', cache: 'reload', headers: { 'some-header': 'some-header-value', }, }} /> ``` Setting the `headers` last (current approach): ```kt val request = Request.Builder() .cacheControl(cacheControlBuilder.build()) .url(uri.toString()) .headers(headers) .get() .build() FLog.w("RequestHeaders", request.headers.toString()) ``` Output (notice that the Cache-Control header is not present): ```bash RequestHeaders com.facebook.react.uiapp W some-header: some-header-value ``` <img width="561" alt="image" src="https://github.com/user-attachments/assets/797cd90a-2064-4772-99cc-5f9d39d73361"> --- New approach by setting the `headers` first: ```kt val request = Request.Builder() .headers(headers) .cacheControl(cacheControlBuilder.build()) .url(uri.toString()) .get() .build() FLog.w("RequestHeaders", request.headers.toString()) ``` Output (Cache-Control is present now along with the passed headers): ```bash RequestHeaders com.facebook.react.uiapp W some-header: some-header-value Cache-Control: no-cache, no-store ``` <img width="556" alt="image" src="https://github.com/user-attachments/assets/1b9f7865-926e-496b-ad3a-36e19ae92188"> Reviewed By: rshest Differential Revision: D66446820 Pulled By: javache fbshipit-source-id: 2640ea4b0e678a7aa919b919b0b44bedc0da0af4
React Native
Learn once, write anywhere:
Build mobile apps with React.
Getting Started · Learn the Basics · Showcase · Contribute · Community · Support
React Native brings React's declarative UI framework to iOS and Android. With React Native, you use native UI controls and have full access to the native platform.
- Declarative. React makes it painless to create interactive UIs. Declarative views make your code more predictable and easier to debug.
- Component-Based. Build encapsulated components that manage their state, then compose them to make complex UIs.
- Developer Velocity. See local changes in seconds. Changes to JavaScript code can be live reloaded without rebuilding the native app.
- Portability. Reuse code across iOS, Android, and other platforms.
React Native is developed and supported by many companies and individual core contributors. Find out more in our ecosystem overview.
Contents
- Requirements
- Building your first React Native app
- Documentation
- Upgrading
- How to Contribute
- Code of Conduct
- License
📋 Requirements
React Native apps may target iOS 13.4 and Android 6.0 (API 23) or newer. You may use Windows, macOS, or Linux as your development operating system, though building and running iOS apps is limited to macOS. Tools like Expo can be used to work around this.
🎉 Building your first React Native app
Follow the Getting Started guide. The recommended way to install React Native depends on your project. Here you can find short guides for the most common scenarios:
📖 Documentation
The full documentation for React Native can be found on our website.
The React Native documentation discusses components, APIs, and topics that are specific to React Native. For further documentation on the React API that is shared between React Native and React DOM, refer to the React documentation.
The source for the React Native documentation and website is hosted on a separate repository, @facebook/react-native-website.
🚀 Upgrading
Upgrading to new versions of React Native may give you access to more APIs, views, developer tools, and other goodies. See the Upgrading Guide for instructions.
React Native releases are discussed in this discussion repo.
👏 How to Contribute
The main purpose of this repository is to continue evolving React Native core. We want to make contributing to this project as easy and transparent as possible, and we are grateful to the community for contributing bug fixes and improvements. Read below to learn how you can take part in improving React Native.
Code of Conduct
Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please read the full text so that you can understand what actions will and will not be tolerated.
Contributing Guide
Read our Contributing Guide to learn about our development process, how to propose bugfixes and improvements, and how to build and test your changes to React Native.
Open Source Roadmap
You can learn more about our vision for React Native in the Roadmap.
Good First Issues
We have a list of good first issues that contain bugs which have a relatively limited scope. This is a great place to get started, gain experience, and get familiar with our contribution process.
Discussions
Larger discussions and proposals are discussed in @react-native-community/discussions-and-proposals.
📄 License
React Native is MIT licensed, as found in the LICENSE file.
React Native documentation is Creative Commons licensed, as found in the LICENSE-docs file.