mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin Shergin
a09ab53692
Summary: This diff changes the signature of ComponentDescriptor constructor to make it simpler and easier to support: now all arguments are passed via struct that contains all these arguments as fields. Now the ComponentDescriptor constructor accepts three arguments one of which is optional. This causes some confusion and the possibility of bugs in all subclasses that needs to implement a custom constructor. Mostly because in every case we need to ensure that the constructor: * Accepts and pass down all parameters/arguments; * Accepts the right types of those parameters (shared vs weak pointers, references vs values). * Accepts all thee arguments and pass them (including flavor!). We failed this point several times. Overal that makes the code simpler and allows changing the set of parameters relatively easy. (There is no plan for it!) Look at the LOC balance: less code! Changelog: [INTERNAL] Reviewed By: sammy-SC Differential Revision: D18548173 fbshipit-source-id: 5d038b135e004f6c054026b3235ed57db99c086d
53 lines
1.6 KiB
C++
53 lines
1.6 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "AndroidSwitchMeasurementsManager.h"
|
|
#include "AndroidSwitchShadowNode.h"
|
|
|
|
#include <react/core/ConcreteComponentDescriptor.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
/*
|
|
* Descriptor for <AndroidSwitch> component.
|
|
*/
|
|
class AndroidSwitchComponentDescriptor final
|
|
: public ConcreteComponentDescriptor<AndroidSwitchShadowNode> {
|
|
public:
|
|
AndroidSwitchComponentDescriptor(
|
|
ComponentDescriptorParameters const ¶meters)
|
|
: ConcreteComponentDescriptor(parameters),
|
|
measurementsManager_(std::make_shared<AndroidSwitchMeasurementsManager>(
|
|
contextContainer_)) {}
|
|
|
|
void adopt(UnsharedShadowNode shadowNode) const override {
|
|
ConcreteComponentDescriptor::adopt(shadowNode);
|
|
|
|
assert(std::dynamic_pointer_cast<AndroidSwitchShadowNode>(shadowNode));
|
|
auto androidSwitchShadowNode =
|
|
std::static_pointer_cast<AndroidSwitchShadowNode>(shadowNode);
|
|
|
|
// `AndroidSwitchShadowNode` uses `AndroidSwitchMeasurementsManager` to
|
|
// provide measurements to Yoga.
|
|
androidSwitchShadowNode->setAndroidSwitchMeasurementsManager(
|
|
measurementsManager_);
|
|
|
|
// All `AndroidSwitchShadowNode`s must have leaf Yoga nodes with properly
|
|
// setup measure function.
|
|
androidSwitchShadowNode->enableMeasurement();
|
|
}
|
|
|
|
private:
|
|
const std::shared_ptr<AndroidSwitchMeasurementsManager> measurementsManager_;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|