Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
61cd5961377e04f0bc91b88c78a8e6b8a8094de4
react-native/ReactCommon/fabric/mounting
T
History
Joshua Gross 90287ca536 Make ShadowTreeRegistry remove API safer 
Summary:
Currently the `remove` API returns an owned unique_ptr of the removed ShadowTree but it's not used anywhere, so we can simplify the API.

Because of that change, we can make the API safe even if the SurfaceId has already been removed.

For context, on Android there is a race between RootView.unmountReactApplication and C++ teardown which removes all SurfaceIds. This currently causes a crash, but after this diff the 2nd call to `remove` for a given SurfaceId will noop.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D22416471

fbshipit-source-id: dbba44c276aab8e81097b92a89e0becdcb7b28ba
2020-07-07 13:01:47 -07:00
..
stubs
Fabric: Improvements in StubView pretty-printing
2020-02-13 12:05:28 -08:00
tests
Fix KERN_INVALID_ADDRESS in LayoutAnimation
2020-06-05 16:11:11 -07:00
BUCK
use xplat BUCK attribution
2020-05-15 21:55:52 -07:00
Differentiator.cpp
Fabric: display: none nodes do not create views anymore
2020-07-01 20:54:58 -07:00
Differentiator.h
Remove branching for optimized differ QE
2020-05-14 05:30:48 -07:00
MountingCoordinator.cpp
LayoutAnimations: fix crashes
2020-06-15 17:33:07 -07:00
MountingCoordinator.h
Fix KERN_INVALID_ADDRESS in LayoutAnimation
2020-06-05 16:11:11 -07:00
MountingOverrideDelegate.h
Daily arc lint --take CLANGFORMAT
2020-05-21 10:13:22 -07:00
MountingTelemetry.cpp
Fabric: Improving precision and type-safety of Telemetry
2020-01-27 13:26:49 -08:00
MountingTelemetry.h
Fabric: Improving precision and type-safety of Telemetry
2020-01-27 13:26:49 -08:00
MountingTransaction.cpp
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
MountingTransaction.h
C++ Fabric Core LayoutAnimations
2020-05-20 19:45:49 -07:00
MountingTransactionMetadata.cpp
Tidy up license headers
2019-11-11 17:59:06 -08:00
MountingTransactionMetadata.h
Tidy up license headers
2019-11-11 17:59:06 -08:00
ShadowTree.cpp
Fix KERN_INVALID_ADDRESS in LayoutAnimation
2020-06-05 16:11:11 -07:00
ShadowTree.h
Fix KERN_INVALID_ADDRESS in LayoutAnimation
2020-06-05 16:11:11 -07:00
ShadowTreeDelegate.h
chore: fix typo in comments (#28269)
2020-03-09 15:37:33 -07:00
ShadowTreeRegistry.cpp
Make ShadowTreeRegistry remove API safer
2020-07-07 13:01:47 -07:00
ShadowTreeRegistry.h
Make ShadowTreeRegistry remove API safer
2020-07-07 13:01:47 -07:00
ShadowTreeRevision.cpp
C++ Fabric Core LayoutAnimations
2020-05-20 19:45:49 -07:00
ShadowTreeRevision.h
C++ Fabric Core LayoutAnimations
2020-05-20 19:45:49 -07:00
ShadowView.cpp
C++ Fabric Core LayoutAnimations
2020-05-20 19:45:49 -07:00
ShadowView.h
C++ Fabric Core LayoutAnimations
2020-05-20 19:45:49 -07:00
ShadowViewMutation.cpp
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ShadowViewMutation.h
Fabric: Making DebugStringConvertibleOptions a required parameter for all methods of static debug-printing infra
2019-12-09 15:37:59 -08:00
TreeStateReconciliation.cpp
Fix crash in state reconciliation
2020-02-19 14:31:22 -08:00
TreeStateReconciliation.h
Core: Add "state reconciliation" to commit phase, pre-layout
2020-02-08 11:33:43 -08:00