mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
03bd7d799e
Summary:
## Summary
Please check out D21035209.
## Changes
- Codemod all ObjC NativeModule `getTurboModuleWithJsInvoker:nativeInvoker:perfLogger` methods to `getTurboModule:(const ObjCTurboModule::Args)`
## Script
```
var withSpaces = (...args) => args.join('\s*')
var regexString = withSpaces(
'-',
'\(',
'std::shared_ptr',
'<',
'(?<turboModuleClass>(facebook::react::|react::|::|)TurboModule)',
'>',
'\)',
'getTurboModuleWithJsInvoker',
':',
'\(',
'std::shared_ptr',
'<',
'(?<fbNamespace>(facebook::react::|react::|::|))CallInvoker',
'>',
'\)',
'(?<jsInvokerInstance>[A-Za-z0-9]+)',
'nativeInvoker',
':',
'\(',
'std::shared_ptr',
'<',
'(facebook::react::|react::|::|)CallInvoker',
'>',
'\)',
'(?<nativeInvokerInstance>[A-Za-z0-9]+)',
'perfLogger',
':',
'\(',
'id',
'<',
'RCTTurboModulePerformanceLogger',
'>',
'\)',
'(?<perfLoggerInstance>[A-Za-z0-9]+)',
'{',
'return',
'std::make_shared',
'<',
'(?<specName>(facebook::react::|react::|::|)Native[%A-Za-z0-9]+SpecJSI)',
'>',
'\(',
'self',
',',
'\k<jsInvokerInstance>',
',',
'\k<nativeInvokerInstance>',
',',
'\k<perfLoggerInstance>',
'\)',
';',
'}',
)
var replaceString = `- (std::shared_ptr<$<turboModuleClass>>) getTurboModule:(const $<fbNamespace>ObjCTurboModule::InitParams &)params
{
return std::make_shared<$<specName>>(params);
}`
const exec = require('../lib/exec');
const abspath = require('../lib/abspath');
const relpath = require('../lib/relpath');
const readFile = (filename) => require('fs').readFileSync(filename, 'utf8');
const writeFile = (filename, content) => require('fs').writeFileSync(filename, content);
function main() {
const tmFiles = exec('cd ~/fbsource && xbgs -n 10000 -l getTurboModuleWithJsInvoker:').split('\n').filter(Boolean);
tmFiles
.filter((filename) => !filename.includes('microsoft-fork-of-react-native'))
.map(abspath)
.forEach((filename) => {
const source = readFile(filename);
const newSource = source.replace(new RegExp(regexString, 'g'), replaceString);
if (source == newSource) {
console.log(relpath(filename));
}
writeFile(filename, newSource);
});
}
if (!module.parent) {
main();
}
```
## Re-generating diff
```
> hg revert -r .^ --all
> node index.js # run script
```
Changelog: [iOS][Changed] - Make all ObjC NativeModules create TurboModules using ObjCTurboModule::Args
Reviewed By: PeteTheHeat
Differential Revision: D21036265
fbshipit-source-id: 404bcc548d1775ef23d793527606d02fe384a0a2
159 lines
5.0 KiB
Plaintext
159 lines
5.0 KiB
Plaintext
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import "RCTTestModule.h"
|
|
|
|
#import <React/RCTAssert.h>
|
|
#import <React/RCTEventDispatcher.h>
|
|
#import <React/RCTLog.h>
|
|
#import <React/RCTUIManager.h>
|
|
#import <ReactCommon/RCTTurboModule.h>
|
|
|
|
#import "FBSnapshotTestController.h"
|
|
|
|
#import "RCTTestPlugins.h"
|
|
|
|
@protocol NativeTestModuleSpec <RCTBridgeModule, RCTTurboModule>
|
|
|
|
- (void)markTestCompleted;
|
|
- (void)markTestPassed:(BOOL)success;
|
|
- (void)verifySnapshot:(RCTResponseSenderBlock)callback;
|
|
|
|
@end
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
/**
|
|
* ObjC++ class for module 'TestModule'
|
|
*/
|
|
|
|
class JSI_EXPORT NativeTestModuleSpecJSI : public ObjCTurboModule {
|
|
public:
|
|
NativeTestModuleSpecJSI(const ObjCTurboModule::InitParams ¶ms);
|
|
|
|
};
|
|
} // namespace react
|
|
} // namespace facebook
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
|
|
static facebook::jsi::Value __hostFunction_NativeTestModuleSpecJSI_markTestCompleted(facebook::jsi::Runtime& rt, TurboModule &turboModule, const facebook::jsi::Value* args, size_t count) {
|
|
return static_cast<ObjCTurboModule&>(turboModule).invokeObjCMethod(rt, VoidKind, "markTestCompleted", @selector(markTestCompleted), args, count);
|
|
}
|
|
|
|
static facebook::jsi::Value __hostFunction_NativeTestModuleSpecJSI_markTestPassed(facebook::jsi::Runtime& rt, TurboModule &turboModule, const facebook::jsi::Value* args, size_t count) {
|
|
return static_cast<ObjCTurboModule&>(turboModule).invokeObjCMethod(rt, VoidKind, "markTestPassed", @selector(markTestPassed:), args, count);
|
|
}
|
|
|
|
static facebook::jsi::Value __hostFunction_NativeTestModuleSpecJSI_verifySnapshot(facebook::jsi::Runtime& rt, TurboModule &turboModule, const facebook::jsi::Value* args, size_t count) {
|
|
return static_cast<ObjCTurboModule&>(turboModule).invokeObjCMethod(rt, VoidKind, "verifySnapshot", @selector(verifySnapshot:), args, count);
|
|
}
|
|
|
|
|
|
NativeTestModuleSpecJSI::NativeTestModuleSpecJSI(const ObjCTurboModule::InitParams ¶ms)
|
|
: ObjCTurboModule(params) {
|
|
|
|
methodMap_["markTestCompleted"] = MethodMetadata {0, __hostFunction_NativeTestModuleSpecJSI_markTestCompleted};
|
|
|
|
|
|
methodMap_["markTestPassed"] = MethodMetadata {1, __hostFunction_NativeTestModuleSpecJSI_markTestPassed};
|
|
|
|
|
|
methodMap_["verifySnapshot"] = MethodMetadata {1, __hostFunction_NativeTestModuleSpecJSI_verifySnapshot};
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|
|
|
|
@interface RCTTestModule() <NativeTestModuleSpec>
|
|
@end
|
|
|
|
@implementation RCTTestModule {
|
|
NSMutableDictionary<NSString *, NSNumber *> *_snapshotCounter;
|
|
}
|
|
|
|
@synthesize bridge = _bridge;
|
|
|
|
RCT_EXPORT_MODULE()
|
|
|
|
- (dispatch_queue_t)methodQueue
|
|
{
|
|
return _bridge.uiManager.methodQueue;
|
|
}
|
|
|
|
RCT_EXPORT_METHOD(verifySnapshot:(RCTResponseSenderBlock)callback)
|
|
{
|
|
RCTAssert(_controller != nil, @"No snapshot controller configured.");
|
|
|
|
[_bridge.uiManager addUIBlock:^(RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) {
|
|
NSString *testName = NSStringFromSelector(self->_testSelector);
|
|
if (!self->_snapshotCounter) {
|
|
self->_snapshotCounter = [NSMutableDictionary new];
|
|
}
|
|
|
|
NSNumber *counter = @([self->_snapshotCounter[testName] integerValue] + 1);
|
|
self->_snapshotCounter[testName] = counter;
|
|
|
|
NSError *error = nil;
|
|
NSString *identifier = [counter stringValue];
|
|
if (self->_testSuffix) {
|
|
identifier = [identifier stringByAppendingString:self->_testSuffix];
|
|
}
|
|
BOOL success = [self->_controller compareSnapshotOfView:self->_view
|
|
selector:self->_testSelector
|
|
identifier:identifier
|
|
error:&error];
|
|
if (!success) {
|
|
RCTLogInfo(@"Failed to verify snapshot %@ (error: %@)", identifier, error);
|
|
}
|
|
callback(@[@(success)]);
|
|
}];
|
|
}
|
|
|
|
RCT_EXPORT_METHOD(sendAppEvent:(NSString *)name body:(nullable id)body)
|
|
{
|
|
#pragma clang diagnostic push
|
|
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
|
|
[_bridge.eventDispatcher sendAppEventWithName:name body:body];
|
|
#pragma clang diagnostic pop
|
|
}
|
|
|
|
RCT_REMAP_METHOD(shouldResolve, shouldResolve_resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
|
|
{
|
|
resolve(@1);
|
|
}
|
|
|
|
RCT_REMAP_METHOD(shouldReject, shouldReject_resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
|
|
{
|
|
reject(nil, nil, nil);
|
|
}
|
|
|
|
RCT_EXPORT_METHOD(markTestCompleted)
|
|
{
|
|
[self markTestPassed:YES];
|
|
}
|
|
|
|
RCT_EXPORT_METHOD(markTestPassed:(BOOL)success)
|
|
{
|
|
[_bridge.uiManager addUIBlock:^(__unused RCTUIManager *uiManager, __unused NSDictionary<NSNumber *, UIView *> *viewRegistry) {
|
|
self->_status = success ? RCTTestStatusPassed : RCTTestStatusFailed;
|
|
}];
|
|
}
|
|
|
|
- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const facebook::react::ObjCTurboModule::InitParams &)params
|
|
{
|
|
return std::make_shared<facebook::react::NativeTestModuleSpecJSI>(params);
|
|
}
|
|
|
|
@end
|
|
|
|
Class RCTTestModuleCls(void) {
|
|
return RCTTestModule.class;
|
|
}
|