mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
7b9490b4b1
Summary: ## Impact Fix the Static ViewConfig for <View/>. This diff fixes the base ViewConfig for all HostComponents on both platforms. Consequently, it simplifies SVC reconciliation efforts, by nearly eliminating the first of these classes of SVC errors: 1. Unexpected properties in SVC 2. Missing properties in SVC 3. Not matching properites in SVC ## What is the base ViewConfig on each iOS/Android? **On iOS:** - All props come from ViewManagers - All HostComponent ViewManagers extend <View/> ViewManager https://pxl.cl/1SxdF Therefore, the base ViewConfig for all components should be <View/>'s static ViewConfig. **On Android:** The component model is a bit more complicated: https://pxl.cl/1Vmp5 Takeaways: - Props come from Shadow Nodes **and** ViewManagers - Nearly all HostComponent ViewManagers extend BaseViewManager. But, that's not <View/>'s ViewManager. - <View/>'s ViewManager is [ReactViewManager](https://fburl.com/code/0zalv8zk), which is a descendent of BaseViewManager, and declares its own ReactProps. So, on Android, it's not safe for the base ViewConfig to be <View>'s ViewConfig: 1. No components actualy incorportate <View/>'s props 2. Some components don't even incorporate BaseViewManager's props. So, what should the base ViewConfig be on Android? - Nearly all components extend BaseViewManager. BaseViewManager must have a shadow node [that extends LayoutShadowNode](https://www.internalfb.com/code/fbsource/[47d68ebc06e64d97da9d069f1ab662b392f0df8a]/xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java?lines=40). Therefore, we'll make the base ViewConfig on Android be generated by BaseViewManager + LayoutShadowNode. ## Changes In this diff, I removed ReactNativeViewViewConfig, and introduced a new view config called PlatformBaseViewConfig. This ViewConfig partial will capture all the props available on all HostComponents on **both** platforms. This may not necessarily be the props made available on <View/>. The only components that don't extend the base platform props are: RCTTextInlineImage. What we do with these components is TBD. Changelog: [Internal] Reviewed By: p-sun, yungsters Differential Revision: D33135055 fbshipit-source-id: 7299f60ae45ed499ce47c0d0a6309a047bff90bb
203 lines
5.1 KiB
JavaScript
203 lines
5.1 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow strict
|
|
* @format
|
|
*/
|
|
|
|
import {type ViewConfig} from '../Renderer/shims/ReactNativeTypes';
|
|
// $FlowFixMe[nonstrict-import]
|
|
import getNativeComponentAttributes from '../ReactNative/getNativeComponentAttributes';
|
|
// $FlowFixMe[nonstrict-import]
|
|
import {createViewConfig} from './ViewConfig';
|
|
import {isIgnored} from './ViewConfigIgnore';
|
|
|
|
type Difference =
|
|
| {
|
|
type: 'missing',
|
|
path: Array<string>,
|
|
nativeValue: mixed,
|
|
}
|
|
| {
|
|
type: 'unequal',
|
|
path: Array<string>,
|
|
nativeValue: mixed,
|
|
staticValue: mixed,
|
|
}
|
|
| {
|
|
type: 'unexpected',
|
|
path: Array<string>,
|
|
staticValue: mixed,
|
|
};
|
|
|
|
type ValidationResult = ValidResult | InvalidResult;
|
|
type ValidResult = {
|
|
type: 'valid',
|
|
};
|
|
type InvalidResult = {
|
|
type: 'invalid',
|
|
differences: Array<Difference>,
|
|
};
|
|
|
|
type ViewConfigValidationResult = {
|
|
componentName: string,
|
|
nativeViewConfig?: ?ViewConfig,
|
|
staticViewConfig?: ?ViewConfig,
|
|
validationResult?: ?ValidationResult,
|
|
};
|
|
|
|
// e.g. require('MyNativeComponent') where MyNativeComponent.js exports a HostComponent
|
|
type JSModule = $FlowFixMe;
|
|
|
|
export function validateStaticViewConfigs(
|
|
nativeComponent: JSModule,
|
|
): ViewConfigValidationResult {
|
|
const nativeViewConfig = getNativeComponentAttributes(
|
|
nativeComponent.default || nativeComponent,
|
|
);
|
|
|
|
const generatedPartialViewConfig = nativeComponent.__INTERNAL_VIEW_CONFIG;
|
|
const staticViewConfig: ?ViewConfig =
|
|
generatedPartialViewConfig && createViewConfig(generatedPartialViewConfig);
|
|
|
|
const componentName: string = nativeComponent.default || nativeComponent;
|
|
const validationResult: ?ValidationResult =
|
|
nativeViewConfig &&
|
|
staticViewConfig &&
|
|
validate(componentName, nativeViewConfig, staticViewConfig);
|
|
|
|
return {
|
|
componentName,
|
|
nativeViewConfig,
|
|
staticViewConfig,
|
|
validationResult,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* During the migration from native view configs to static view configs, this is
|
|
* used to validate that the two are equivalent.
|
|
*/
|
|
export function validate(
|
|
name: string,
|
|
nativeViewConfig: ViewConfig,
|
|
staticViewConfig: ViewConfig,
|
|
): ValidationResult {
|
|
const differences = [];
|
|
accumulateDifferences(
|
|
differences,
|
|
[],
|
|
{
|
|
bubblingEventTypes: nativeViewConfig.bubblingEventTypes,
|
|
directEventTypes: nativeViewConfig.directEventTypes,
|
|
uiViewClassName: nativeViewConfig.uiViewClassName,
|
|
validAttributes: nativeViewConfig.validAttributes,
|
|
},
|
|
{
|
|
bubblingEventTypes: staticViewConfig.bubblingEventTypes,
|
|
directEventTypes: staticViewConfig.directEventTypes,
|
|
uiViewClassName: staticViewConfig.uiViewClassName,
|
|
validAttributes: staticViewConfig.validAttributes,
|
|
},
|
|
);
|
|
|
|
if (differences.length === 0) {
|
|
return {type: 'valid'};
|
|
}
|
|
|
|
return {
|
|
type: 'invalid',
|
|
differences,
|
|
};
|
|
}
|
|
|
|
export function stringifyValidationResult(
|
|
name: string,
|
|
validationResult: InvalidResult,
|
|
): string {
|
|
const {differences} = validationResult;
|
|
return [
|
|
`StaticViewConfigValidator: Invalid static view config for '${name}'.`,
|
|
'',
|
|
...differences.map(difference => {
|
|
const {type, path} = difference;
|
|
switch (type) {
|
|
case 'missing':
|
|
return `- '${path.join('.')}' is missing.`;
|
|
case 'unequal':
|
|
return `- '${path.join('.')}' is the wrong value.`;
|
|
case 'unexpected':
|
|
return `- '${path.join('.')}' is present but not expected to be.`;
|
|
}
|
|
}),
|
|
'',
|
|
].join('\n');
|
|
}
|
|
|
|
function accumulateDifferences(
|
|
differences: Array<Difference>,
|
|
path: Array<string>,
|
|
nativeObject: {...},
|
|
staticObject: {...},
|
|
): void {
|
|
for (const nativeKey in nativeObject) {
|
|
const nativeValue = nativeObject[nativeKey];
|
|
|
|
if (!staticObject.hasOwnProperty(nativeKey)) {
|
|
differences.push({
|
|
path: [...path, nativeKey],
|
|
type: 'missing',
|
|
nativeValue,
|
|
});
|
|
continue;
|
|
}
|
|
|
|
const staticValue = staticObject[nativeKey];
|
|
|
|
const nativeValueIfObject = ifObject(nativeValue);
|
|
if (nativeValueIfObject != null) {
|
|
const staticValueIfObject = ifObject(staticValue);
|
|
if (staticValueIfObject != null) {
|
|
path.push(nativeKey);
|
|
accumulateDifferences(
|
|
differences,
|
|
path,
|
|
nativeValueIfObject,
|
|
staticValueIfObject,
|
|
);
|
|
path.pop();
|
|
continue;
|
|
}
|
|
}
|
|
|
|
if (nativeValue !== staticValue) {
|
|
differences.push({
|
|
path: [...path, nativeKey],
|
|
type: 'unequal',
|
|
nativeValue,
|
|
staticValue,
|
|
});
|
|
}
|
|
}
|
|
|
|
for (const staticKey in staticObject) {
|
|
if (
|
|
!nativeObject.hasOwnProperty(staticKey) &&
|
|
!isIgnored(staticObject[staticKey])
|
|
) {
|
|
differences.push({
|
|
path: [...path, staticKey],
|
|
type: 'unexpected',
|
|
staticValue: staticObject[staticKey],
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
function ifObject(value: mixed): ?{...} {
|
|
return typeof value === 'object' && !Array.isArray(value) ? value : null;
|
|
}
|